[Rt-commit] r8615 - in rt/branches/3.7-EXPERIMENTAL-TUNIS: . etc html/Elements/CollectionAsTable

[thayes at bestpractical.com]

Author: thayes
Date: Fri Aug 17 17:03:38 2007
New Revision: 8615

Modified:
   rt/branches/3.7-EXPERIMENTAL-TUNIS/   (props changed)
   rt/branches/3.7-EXPERIMENTAL-TUNIS/etc/RT_Config.pm.in
   rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Elements/CollectionAsTable/Row
   rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Ticket/Display.html

Log:
 r8853 at toth:  toth | 2007-08-17 16:42:31 -0400
 * Removed Locking section of RT Config (now covered in the README for RT-Extension-TicketLocking)
 * Very minor formatting changes to Collection-As-Row tables (to make the source a bit easier to read)
 * Moved ProcessArguments callback as it was getting an undefined ticket object where it was
 


Modified: rt/branches/3.7-EXPERIMENTAL-TUNIS/etc/RT_Config.pm.in
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL-TUNIS/etc/RT_Config.pm.in	(original)
+++ rt/branches/3.7-EXPERIMENTAL-TUNIS/etc/RT_Config.pm.in	Fri Aug 17 17:03:38 2007
@@ -694,19 +694,6 @@
 
 
 
-# {{{ Ticket Locking
-#
-# RT can be configured to use advisory locks on tickets, so that a user
-# can be notified if another user is making changes to a particular ticket.
-#
-# Locks have a maximum duration, which can be defined here (in seconds).
-
-Set($LockExpiry, 300);
-
-#}}}
-
-
-
 # {{{ Development Mode
 #
 # RT comes with a "Development mode" setting. 

Modified: rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Elements/CollectionAsTable/Row
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Elements/CollectionAsTable/Row	(original)
+++ rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Elements/CollectionAsTable/Row	Fri Aug 17 17:03:38 2007
@@ -56,7 +56,7 @@
 $Class     => 'RT__Ticket'
 </%ARGS>
 <%init>
-$m->out('<tr class="' . ( $Warning ? 'warnline' : $i % 2 ? 'oddline' : 'evenline' ) . '" >' );
+$m->out('<tr class="' . ( $Warning ? 'warnline' : $i % 2 ? 'oddline' : 'evenline' ) . '" >' . "\n" );
 my $item;
 foreach my $column ( @Format ) {
     if ( defined $column->{title} && $column->{title} eq 'NEWLINE' ) {
@@ -65,10 +65,10 @@
             $item++;
         }
         $item = 0;
-        $m->out('</tr>');
+        $m->out('</tr>' . "\n");
         $m->out('<tr class="'
               . ( $Warning ? 'warnline' : $i % 2 ? 'oddline' : 'evenline' )
-              . '" >' );
+              . '" >' . "\n" );
         next;
     }
 
@@ -115,7 +115,7 @@
         s/\n/<br \/>/gs for @out;
         $m->out( @out ) if @out;
     }
-    $m->out('</td>');
+    $m->out('</td>' . "\n");
 }
 $m->out('</tr>');
 </%init>

Modified: rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Ticket/Display.html
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Ticket/Display.html	(original)
+++ rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Ticket/Display.html	Fri Aug 17 17:03:38 2007
@@ -92,11 +92,6 @@
 my (@Actions, $Tickets);  
 
 
-$m->callback(CallbackName => 'ProcessArguments', 
-            Ticket => $TicketObj, 
-            ARGSref => \%ARGS, 
-            Actions => \@Actions);
-
 unless ($id || $TicketObj) {
     Abort('No ticket specified');
 }
@@ -136,7 +131,6 @@
         }
     }
 
-    
 #    if ( defined $ARGS{'Lock'} ) {
 #        if ( $ARGS{'Lock'} eq 'add' ) {
 #            if ( $TicketObj->Lock('Hard') ) {
@@ -154,6 +148,11 @@
 #        }
 #    }
 
+    $m->callback(CallbackName => 'ProcessArguments', 
+            Ticket => $TicketObj, 
+            ARGSref => \%ARGS, 
+            Actions => \@Actions);
+    
     $ARGS{'UpdateContent'} =~ s/\r\n/\n/g if defined $ARGS{'UpdateContent'};
     if ( $ARGS{'UpdateTimeWorked'} || (
         defined $ARGS{'UpdateContent'}