[Rt-commit] r8749 - rt/branches/3.7-EXPERIMENTAL-TUNIS/lib/RT

[ruz at bestpractical.com]

Author: ruz
Date: Mon Aug 27 17:48:12 2007
New Revision: 8749

Modified:
   rt/branches/3.7-EXPERIMENTAL-TUNIS/lib/RT/Test.pm

Log:
* my $x = ... unless ...; is not that good idea

Modified: rt/branches/3.7-EXPERIMENTAL-TUNIS/lib/RT/Test.pm
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL-TUNIS/lib/RT/Test.pm	(original)
+++ rt/branches/3.7-EXPERIMENTAL-TUNIS/lib/RT/Test.pm	Mon Aug 27 17:48:12 2007
@@ -245,11 +245,11 @@
         my @fields = qw(CorrespondAddress CommentAddress);
         foreach my $field ( @fields ) {
             next unless exists $args{ $field };
+            next if $args{ $field } eq $obj->$field;
             
             no warnings 'uninitialized';
             my $method = 'Set'. $field;
-            my ($val, $msg) = $obj->$method( $args{ $field } )
-                unless $args{ $field } eq $obj->$field;
+            my ($val, $msg) = $obj->$method( $args{ $field } );
             die "$msg" unless $val;
         }
     }