[Rt-commit] r8850 - rt/branches/3.7-EXPERIMENTAL/lib/RT

ruz at bestpractical.com ruz at bestpractical.com
Thu Aug 30 20:47:45 EDT 2007


Author: ruz
Date: Thu Aug 30 20:47:43 2007
New Revision: 8850

Modified:
   rt/branches/3.7-EXPERIMENTAL/lib/RT/SearchBuilder.pm

Log:
* minor

Modified: rt/branches/3.7-EXPERIMENTAL/lib/RT/SearchBuilder.pm
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL/lib/RT/SearchBuilder.pm	(original)
+++ rt/branches/3.7-EXPERIMENTAL/lib/RT/SearchBuilder.pm	Thu Aug 30 20:47:43 2007
@@ -67,10 +67,10 @@
 use DBIx::SearchBuilder "1.40";
 
 use strict;
-use vars qw(@ISA);
- at ISA = qw(DBIx::SearchBuilder RT::Base);
+use warnings;
+
+use base qw(DBIx::SearchBuilder RT::Base);
 
-# {{{ sub _Init 
 sub _Init  {
     my $self = shift;
     
@@ -83,13 +83,10 @@
     }
     $self->SUPER::_Init( 'Handle' => $RT::Handle);
 }
-# }}}
-
-# {{{ sub LimitToEnabled
 
 =head2 LimitToEnabled
 
-Only find items that haven\'t been disabled
+Only find items that haven't been disabled
 
 =cut
 
@@ -100,9 +97,6 @@
 		  VALUE => '0',
 		  OPERATOR => '=' );
 }
-# }}}
-
-# {{{ sub LimitToDisabled
 
 =head2 LimitToDeleted
 
@@ -119,9 +113,6 @@
 		  VALUE => '1'
 		);
 }
-# }}}
-
-# {{{ sub LimitAttribute
 
 =head2 LimitAttribute PARAMHASH
 
@@ -212,9 +203,6 @@
 	VALUE      => 'NULL',
     ) if $args{NULL};
 }
-# }}}
-
-# {{{ sub LimitCustomField
 
 =head2 LimitCustomField
 
@@ -273,8 +261,6 @@
     );
 }
 
-# {{{ sub FindAllRows
-
 =head2 FindAllRows
 
 Find all matching rows, regardless of whether they are disabled or not
@@ -285,8 +271,6 @@
     shift->{'find_disabled_rows'} = 1;
 }
 
-# {{{ sub Limit 
-
 =head2 Limit PARAMHASH
 
 This Limit sub calls SUPER::Limit, but defaults "CASESENSITIVE" to 1, thus
@@ -303,10 +287,6 @@
     return $self->SUPER::Limit(%args);
 }
 
-# }}}
-
-# {{{ sub ItemsOrderBy
-
 =head2 ItemsOrderBy
 
 If it has a SortOrder attribute, sort the array by SortOrder.
@@ -330,16 +310,11 @@
     return $items;
 }
 
-# }}}
-
-# {{{ sub ItemsArrayRef
-
 =head2 ItemsArrayRef
 
 Return this object's ItemsArray, in the order that ItemsOrderBy sorts
 it.
 
-
 =cut
 
 sub ItemsArrayRef {
@@ -349,13 +324,9 @@
     return $self->ItemsOrderBy($self->SUPER::ItemsArrayRef());
 }
 
-# }}}
-
 eval "require RT::SearchBuilder_Vendor";
 die $@ if ($@ && $@ !~ qr{^Can't locate RT/SearchBuilder_Vendor.pm});
 eval "require RT::SearchBuilder_Local";
 die $@ if ($@ && $@ !~ qr{^Can't locate RT/SearchBuilder_Local.pm});
 
 1;
-
-


More information about the Rt-commit mailing list