[Rt-commit] r10114 - in rt/branches/3.999-DANGEROUS: lib/RT/Model t/mail

[jesse at bestpractical.com]

Author: jesse
Date: Tue Dec 25 02:20:35 2007
New Revision: 10114

Modified:
   rt/branches/3.999-DANGEROUS/   (props changed)
   rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Model/TicketCollection.pm
   rt/branches/3.999-DANGEROUS/t/mail/sendmail.t

Log:
 r74162 at pinglin:  jesse | 2007-12-25 02:20:26 -0500
 * another 50 passing tests


Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm	Tue Dec 25 02:20:35 2007
@@ -2043,9 +2043,8 @@
 }
 # }}}
 
-# {{{ sub Correspond
 
-=head2 Correspond
+=head2 correspond
 
 Correspond on this ticket.
 Takes a hashref with the following attributes:
@@ -2064,7 +2063,7 @@
 
 =cut
 
-sub Correspond {
+sub correspond {
     my $self = shift;
     my %args = ( CcMessageTo  => undef,
                  BccMessageTo => undef,

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/TicketCollection.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/TicketCollection.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/TicketCollection.pm	Tue Dec 25 02:20:35 2007
@@ -84,6 +84,8 @@
 use RT::Model::CustomFieldCollection;
 use Jifty::DBI::Collection::Unique;
 
+# Override jifty default
+sub implicit_clauses {}
 # Configuration Tables:
 
 # FIELD_METADATA is a mapping of searchable Field name, to Type, and other
@@ -242,6 +244,7 @@
     );
 }
 
+
 =head1 Limit Helper Routines
 
 These routines are the targets of a dispatch table depending on the
@@ -1379,7 +1382,6 @@
     my $clause;
     my @res   = ();
     my $order = 0;
-
     foreach my $row (@args) {
         if ( $row->{alias} || $row->{column} !~ /\./ ) {
             push @res, $row;
@@ -1395,7 +1397,7 @@
                     = $users = ( $self->_Watcherjoin( $meta->[1] ) )[2];
             }
             push @res, { %$row, alias => $users, column => $subkey };
-       } elsif ( defined $meta->[0] && $meta->[0] =~ /customfield/i ) {
+       } elsif ( defined $meta->[0] && $meta->[0] =~ /CUSTOMFIELD/i ) {
            my ($queue, $field, $cfid ) = $self->_CustomFieldDecipher( $subkey );
            my $cfkey = $cfid ? $cfid : "$queue.$field";
            my ($TicketCFs, $CFs) = $self->_CustomFieldjoin( $cfkey, $cfid, $field );
@@ -1430,8 +1432,7 @@
            # PAW logic is "reversed"
            my $order = "ASC";
            if (exists $row->{order} ) {
-               my $o = $row->{order};
-               delete $row->{order};
+               my $o = delete $row->{order};
                $order = "DESC" if $o =~ /asc/i;
            }
 

Modified: rt/branches/3.999-DANGEROUS/t/mail/sendmail.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/mail/sendmail.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/mail/sendmail.t	Tue Dec 25 02:20:35 2007
@@ -83,6 +83,7 @@
 ok ($id,$create_msg);
 $tickets = RT::Model::TicketCollection->new(current_user => RT->system_user);
 $tickets->order_by({column => 'id', order => 'DESC'});
+
 $tickets->limit(column => 'id' ,operator => '>', value => '0');
  $tick = $tickets->first();
 ok ($tick->id, "found ticket ".$tick->id);