[Rt-commit] r8012 - in rt/branches/3.6-RELEASE: .

jesse at bestpractical.com jesse at bestpractical.com
Fri Jun 15 12:31:09 EDT 2007


Author: jesse
Date: Fri Jun 15 12:31:08 2007
New Revision: 8012

Modified:
   rt/branches/3.6-RELEASE/   (props changed)
   rt/branches/3.6-RELEASE/html/Elements/Error

Log:
 r58404 at pinglin:  jesse | 2007-06-15 12:30:51 -0400
 html/Element/Errors generates uninitialized value warnings if the parameter
 $Details is not passed in, and if the SessionType is undefined. The following
 patch quietens it. - Nicholas Clark.
 
 (slightly modified to be more masonic)
 
 


Modified: rt/branches/3.6-RELEASE/html/Elements/Error
==============================================================================
--- rt/branches/3.6-RELEASE/html/Elements/Error	(original)
+++ rt/branches/3.6-RELEASE/html/Elements/Error	Fri Jun 15 12:31:08 2007
@@ -61,7 +61,7 @@
 
 <%args>
 $Code => undef
-$Details => undef
+$Details =>''
 $Title => loc("RT Error")
 $Why => loc("the calling component did not specify why")
 </%args>
@@ -77,7 +77,7 @@
 
 $RT::Logger->error($error);
 
-if ( $session{'SessionType'} eq 'REST' ) {
+if ( defined ($session{'SessionType'} && $session{'SessionType'} eq 'REST' ) {
     $r->content_type('text/plain');
     $m->out( "Error: " . $Why . "\n" );
     $m->out( $Details . "\n" );


More information about the Rt-commit mailing list