[Rt-commit] r7894 - in rt/branches/3.7-EXPERIMENTAL-TUNIS: . html/Admin/Elements html/Admin/Groups html/Prefs

[clsung at bestpractical.com]

Author: clsung
Date: Thu May 17 03:58:01 2007
New Revision: 7894

Modified:
   rt/branches/3.7-EXPERIMENTAL-TUNIS/   (props changed)
   rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Admin/Elements/ObjectCustomFields
   rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Admin/Groups/History.html
   rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Admin/Groups/Modify.html
   rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Admin/Groups/index.html
   rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Elements/Error
   rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Prefs/Search.html

Log:
 r1079 at going04:  clsung | 2007-05-17 09:56:18 +0800
 - add defined() checking


Modified: rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Admin/Elements/ObjectCustomFields
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Admin/Elements/ObjectCustomFields	(original)
+++ rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Admin/Elements/ObjectCustomFields	Thu May 17 03:58:01 2007
@@ -74,7 +74,7 @@
 
 my $QualifiedType;
 my $FriendlySubTypes;
-if ($SubType =~/^RT::(.*)$/)  {
+if (defined $SubType && $SubType =~/^RT::(.*)$/)  {
     $FriendlySubTypes = RT::CustomField->new($session{'CurrentUser'})->FriendlyLookupType($Object->CustomFieldLookupType);
    $QualifiedType = "$Type-$1"; 
 } else {

Modified: rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Admin/Groups/History.html
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Admin/Groups/History.html	(original)
+++ rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Admin/Groups/History.html	Thu May 17 03:58:01 2007
@@ -64,5 +64,5 @@
 my $title = loc("History of the group [_1]", $GroupObj->Name);
 </%INIT>
 <%ARGS>
-$id => undef
+$id => '' unless defined $id
 </%ARGS>

Modified: rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Admin/Groups/Modify.html
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Admin/Groups/Modify.html	(original)
+++ rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Admin/Groups/Modify.html	Thu May 17 03:58:01 2007
@@ -166,5 +166,5 @@
 $Description => undef
 $SetEnabled => undef
 $Enabled => undef
-$id => undef
+$id => '' unless defined $id
 </%ARGS>

Modified: rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Admin/Groups/index.html
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Admin/Groups/index.html	(original)
+++ rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Admin/Groups/index.html	Thu May 17 03:58:01 2007
@@ -106,7 +106,7 @@
 }
 </%INIT>
 <%ARGS>
-$GroupString => undef
+$GroupString => '' unless defined $GroupString
 $GroupOp => '='
 $GroupField => 'Name'
 $FindDisabledGroups => 0

Modified: rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Elements/Error
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Elements/Error	(original)
+++ rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Elements/Error	Thu May 17 03:58:01 2007
@@ -76,7 +76,7 @@
 
 $RT::Logger->error($error);
 
-if ( $session{'SessionType'} eq 'REST' ) {
+if ( defined $session{'SessionType'} and $session{'SessionType'} eq 'REST' ) {
     $r->content_type('text/plain');
     $m->out( "Error: " . $Why . "\n" );
     $m->out( $Details . "\n" );

Modified: rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Prefs/Search.html
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Prefs/Search.html	(original)
+++ rt/branches/3.7-EXPERIMENTAL-TUNIS/html/Prefs/Search.html	Thu May 17 03:58:01 2007
@@ -77,10 +77,11 @@
 my $title = loc("Customize").' ';
 
 my @fields = qw(Format Order OrderBy RowsPerPage);
+$ARGS{name} ||= '';
 my ($class, $id) = ( $ARGS{name} =~ m/^(.*)-(\d+)$/ );
 
 Abort('No search specified')
-    unless $class eq 'RT::Attribute';
+    unless defined $class and $class eq 'RT::Attribute';
 
 my $search = $class->new ($session{'CurrentUser'});
 $search->LoadById ($id);