[Rt-commit] r7914 - rt/branches/3.7-EXPERIMENTAL-RTIR-2.4/lib/RT/Interface

[ruz at bestpractical.com]

Author: ruz
Date: Wed May 23 19:18:49 2007
New Revision: 7914

Modified:
   rt/branches/3.7-EXPERIMENTAL-RTIR-2.4/lib/RT/Interface/Web.pm

Log:
* C<if ( $args{$var} ) { $message_args{$var} .= ", $value"; }> looks wrong,
  most pobably is buggy
* refactor loop a little and get rid of useless block


Modified: rt/branches/3.7-EXPERIMENTAL-RTIR-2.4/lib/RT/Interface/Web.pm
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL-RTIR-2.4/lib/RT/Interface/Web.pm	(original)
+++ rt/branches/3.7-EXPERIMENTAL-RTIR-2.4/lib/RT/Interface/Web.pm	Wed May 23 19:18:49 2007
@@ -617,25 +617,20 @@
             TimeTaken    => $args{ARGSRef}->{'UpdateTimeWorked'});
 
 
-    if ( not  $args{'ARGRef'}->{'UpdateIgnoreAddressCheckboxes'}) {
+    unless ( $args{'ARGRef'}->{'UpdateIgnoreAddressCheckboxes'} ) {
         foreach my $key ( keys %{ $args{ARGSRef} } ) {
-            if ( $key =~ /^Update(Cc|Bcc)-(.*)$/ ) {
-                my $var   = ucfirst($1).'MessageTo';
-                my $value = $2;
-                {
-                    if ( $args{$var} ) {
-                        $message_args{$var} .= ", $value";
-                    } else {
-                        $message_args{$var} = $value;
-                    }
-                }
-            }
+            next unless $key =~ /^Update(Cc|Bcc)-(.*)$/;
 
+            my $var   = ucfirst($1).'MessageTo';
+            my $value = $2;
+            if ( $message_args{ $var } ) {
+                $message_args{ $var } .= ", $value";
+            } else {
+                $message_args{ $var } = $value;
+            }
         }
     }
 
-
-
     if ( $args{ARGSRef}->{'UpdateType'} =~ /^(private|public)$/ ) {
         my ( $Transaction, $Description, $Object ) = $args{TicketObj}->Comment(%message_args);
         push( @results, $Description );