[Rt-commit] r9189 - in rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms: queue

sunnavy at bestpractical.com sunnavy at bestpractical.com
Mon Oct 1 16:17:35 EDT 2007


Author: sunnavy
Date: Mon Oct  1 16:17:35 2007
New Revision: 9189

Modified:
   rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms/queue/default
   rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms/user/default

Log:
go on adding RT::CurrentUser object as argument of new method, fixed the bug of %data == 0

Modified: rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms/queue/default
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms/queue/default	(original)
+++ rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms/queue/default	Mon Oct  1 16:17:35 2007
@@ -56,7 +56,7 @@
 my @comments;
 my ($c, $o, $k, $e) = ("", [], {}, 0);
 my %data = %$changes;
-my $queue = new RT::Model::Queue ;
+my $queue = new RT::Model::Queue( $session{CurrentUser} ) ;
 my @fields = qw(Name Description CorrespondAddress CommentAddress
                 InitialPriority FinalPriority DefaultDueIn);
 my %fields = map { lc $_ => $_ } @fields;
@@ -116,7 +116,7 @@
     }
 }
 
-if (%data == 0) {
+if ( keys %data == 0) {
     my @data;
 
     push @data, [ id => "queue/".$queue->id ];

Modified: rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms/user/default
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms/user/default	(original)
+++ rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms/user/default	Mon Oct  1 16:17:35 2007
@@ -56,7 +56,7 @@
 my @comments;
 my ($c, $o, $k, $e) = ("", [], {}, 0);
 my %data = %$changes;
-my $user = new RT::Model::User ;
+my $user = new RT::Model::User( $session{CurrentUser} ) ;
 my @fields = qw(RealName NickName Gecos Organization Address1 Address2 City
                 State Zip Country HomePhone WorkPhone MobilePhone PagerPhone
                 FreeformContactInfo Comments Signature Lang EmailEncoding
@@ -71,7 +71,7 @@
     }
 }
 else {
-    if (%data == 0) {
+    if ( keys %data == 0) {
         return [
             "# Required: Name, EmailAddress",
             [ qw(id Name EmailAddress Organization Password Comments) ],
@@ -109,11 +109,11 @@
         $id = $user->id;
         delete $data{id};
         push(@comments, "# User $id Created.");
-        goto DONE if %data == 0;
+        goto DONE if keys %data == 0;
     }
 }
 
-if (%data == 0) {
+if (keys %data == 0) {
     my @data;
 
     push @data, [ id => "user/".$user->id ];


More information about the Rt-commit mailing list