[Rt-commit] r15095 - rt/3.8/trunk/lib/RT/Interface/Web

[ruz at bestpractical.com]

Author: ruz
Date: Tue Aug 12 18:19:43 2008
New Revision: 15095

Modified:
   rt/3.8/trunk/lib/RT/Interface/Web/Request.pm

Log:
* looks like our workaround is hiding a real bug (perl bug?).
  we suspect that a function can corrupt $_ in outer scope what
  result in undefs instead of component names in cache, however
  it's still unclear why request resubmission fixes problem

Modified: rt/3.8/trunk/lib/RT/Interface/Web/Request.pm
==============================================================================
--- rt/3.8/trunk/lib/RT/Interface/Web/Request.pm	(original)
+++ rt/3.8/trunk/lib/RT/Interface/Web/Request.pm	Tue Aug 12 18:19:43 2008
@@ -172,9 +172,9 @@
     }
 
     my @rv;
-    # we don't know why but we have to filter undefs as they end up in the list
-    push @rv, scalar $self->comp( $_, %args )
-        foreach grep defined && length, @$callbacks;
+    foreach my $cb ( @$callbacks ) {
+        push @rv, scalar $self->comp( $cb, %args );
+    }
     return @rv;
 }
 }