[Rt-commit] r15380 - in rt/branches/3.999-DANGEROUS: t/maildigest t/web

jesse at bestpractical.com jesse at bestpractical.com
Fri Aug 22 15:46:17 EDT 2008 

Author: jesse
Date: Fri Aug 22 15:46:15 2008
New Revision: 15380

Modified:
   rt/branches/3.999-DANGEROUS/   (props changed)
   rt/branches/3.999-DANGEROUS/t/maildigest/attributes.t
   rt/branches/3.999-DANGEROUS/t/web/dashboards-groups.t
   rt/branches/3.999-DANGEROUS/t/web/dashboards.t

Log:
 r44036 at 173-7-185-206:  jesse | 2008-08-22 15:46:02 -0400
  more small cleanups tp tests


Modified: rt/branches/3.999-DANGEROUS/t/maildigest/attributes.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/maildigest/attributes.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/maildigest/attributes.t	Fri Aug 22 15:46:15 2008
@@ -9,30 +9,30 @@
 
 my( $ret, $msg );
 my $user_n = RT::Model::User->new(current_user => RT->system_user );
-( $ret, $msg ) = $user_n->LoadOrCreateByEmail( $users[0] );
+( $ret, $msg ) = $user_n->load_or_create_by_email( $users[0] );
 ok( $ret, "user with default email prefs created: $msg" );
-$user_n->SetPrivileged( 1 );
+$user_n->set_privileged( 1 );
 
 my $user_d = RT::Model::User->new(current_user => RT->system_user );
-( $ret, $msg ) = $user_d->LoadOrCreateByEmail( $users[1] );
+( $ret, $msg ) = $user_d->load_or_create_by_email( $users[1] );
 ok( $ret, "user with daily digest email prefs created: $msg" );
 # Set a username & password for testing the interface.
-$user_d->SetPrivileged( 1 );
-$user_d->SetPreferences($RT::System => { %{ $user_d->Preferences( $RT::System ) || {}}, EmailFrequency => 'Daily digest'});
+$user_d->set_privileged( 1 );
+$user_d->set_preferences($RT::System => { %{ $user_d->Preferences( $RT::System ) || {}}, EmailFrequency => 'Daily digest'});
 
 
 
 my $user_w = RT::Model::User->new(current_user => RT->system_user );
-( $ret, $msg ) = $user_w->LoadOrCreateByEmail( $users[2] );
+( $ret, $msg ) = $user_w->load_or_create_by_email( $users[2] );
 ok( $ret, "user with weekly digest email prefs created: $msg" );
-$user_w->SetPrivileged( 1 );
-$user_w->SetPreferences($RT::System => { %{ $user_w->Preferences( $RT::System ) || {}}, EmailFrequency => 'Weekly digest'});
+$user_w->set_privileged( 1 );
+$user_w->set_preferences($RT::System => { %{ $user_w->Preferences( $RT::System ) || {}}, EmailFrequency => 'Weekly digest'});
 
 my $user_s = RT::Model::User->new(current_user => RT->system_user );
-( $ret, $msg ) = $user_s->LoadOrCreateByEmail( $users[3] );
+( $ret, $msg ) = $user_s->load_or_create_by_email( $users[3] );
 ok( $ret, "user with suspended email prefs created: $msg" );
-$user_s->SetPreferences($RT::System => { %{ $user_s->Preferences( $RT::System ) || {}}, EmailFrequency => 'Suspended'});
-$user_s->SetPrivileged( 1 );
+$user_s->set_preferences($RT::System => { %{ $user_s->Preferences( $RT::System ) || {}}, EmailFrequency => 'Suspended'});
+$user_s->set_privileged( 1 );
 
 
 is(RT::Config->Get('EmailFrequency' => $user_s), 'Suspended');

Modified: rt/branches/3.999-DANGEROUS/t/web/dashboards-groups.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/web/dashboards-groups.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/web/dashboards-groups.t	Fri Aug 22 15:46:15 2008
@@ -9,11 +9,11 @@
 
 # create user and queue {{{
 my $user_obj = RT::Model::User->new(current_user => RT->system_user);
-my ($ok, $msg) = $user_obj->LoadOrCreateByEmail('customer at example.com');
+my ($ok, $msg) = $user_obj->load_or_create_by_email('customer at example.com');
 ok($ok, 'ACL test user creation');
-$user_obj->SetName('customer');
-$user_obj->SetPrivileged(1);
-($ok, $msg) = $user_obj->SetPassword('customer');
+$user_obj->set_name('customer');
+$user_obj->set_privileged(1);
+($ok, $msg) = $user_obj->set_password('customer');
 $user_obj->principal_object->grant_right(Right => 'ModifySelf');
 my $currentuser = RT::CurrentUser->new($user_obj);
 
@@ -45,13 +45,13 @@
 
 ok($outer_group->has_member($inner_group->principal_id), "outer has inner");
 ok(!$outer_group->has_member($user_obj->principal_id), "outer doesn't have user directly");
-ok($outer_group->has_memberRecursively($inner_group->principal_id), "outer has inner recursively");
-ok($outer_group->has_memberRecursively($user_obj->principal_id), "outer has user recursively");
+ok($outer_group->has_member_recursively($inner_group->principal_id), "outer has inner recursively");
+ok($outer_group->has_member_recursively($user_obj->principal_id), "outer has user recursively");
 
 ok(!$inner_group->has_member($outer_group->principal_id), "inner doesn't have outer");
 ok($inner_group->has_member($user_obj->principal_id), "inner has user");
-ok(!$inner_group->has_memberRecursively($outer_group->principal_id), "inner doesn't have outer, even recursively");
-ok($inner_group->has_memberRecursively($user_obj->principal_id), "inner has user recursively");
+ok(!$inner_group->has_member_recursively($outer_group->principal_id), "inner doesn't have outer, even recursively");
+ok($inner_group->has_member_recursively($user_obj->principal_id), "inner has user recursively");
 # }}}
 
 ok $m->login(customer => 'customer'), "logged in";
@@ -59,14 +59,14 @@
 $m->get_ok("$url/Dashboards");
 
 $m->follow_link_ok({text => "New dashboard"});
-$m->form_name('ModifyDashboard');
+$m->form_name('modify_dashboard');
 is_deeply([$m->current_form->find_input('Privacy')->possible_values], ["RT::Model::User-" . $user_obj->Id], "the only selectable privacy is user");
 $m->content_lacks('Delete', "Delete button hidden because we are creating");
 
 $user_obj->principal_object->grant_right(Right => 'CreateGroupDashboard', Object => $inner_group);
 
 $m->follow_link_ok({text => "New dashboard"});
-$m->form_name('ModifyDashboard');
+$m->form_name('modify_dashboard');
 is_deeply([$m->current_form->find_input('Privacy')->possible_values], ["RT::Model::User-" . $user_obj->Id, "RT::Group-" . $inner_group->Id], "the only selectable privacies are user and inner group (not outer group)");
 $m->field("Name" => 'inner dashboard');
 $m->field("Privacy" => "RT::Group-" . $inner_group->Id);

Modified: rt/branches/3.999-DANGEROUS/t/web/dashboards.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/web/dashboards.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/web/dashboards.t	Fri Aug 22 15:46:15 2008
@@ -8,11 +8,11 @@
 my $url = $m->rt_base_url;
 
 my $user_obj = RT::Model::User->new(current_user => RT->system_user);
-my ($ret, $msg) = $user_obj->LoadOrCreateByEmail('customer at example.com');
+my ($ret, $msg) = $user_obj->load_or_create_by_email('customer at example.com');
 ok($ret, 'ACL test user creation');
-$user_obj->SetName('customer');
-$user_obj->SetPrivileged(1);
-($ret, $msg) = $user_obj->SetPassword('customer');
+$user_obj->set_name('customer');
+$user_obj->set_privileged(1);
+($ret, $msg) = $user_obj->set_password('customer');
 $user_obj->principal_object->grant_right(Right => 'ModifySelf');
 my $currentuser = RT::CurrentUser->new($user_obj);
 
@@ -48,7 +48,7 @@
 $m->content_contains("New dashboard", "'New dashboard' link because we now have ModifyOwnDashboard");
 
 $m->follow_link_ok({text => "New dashboard"});
-$m->form_name('ModifyDashboard');
+$m->form_name('modify_dashboard');
 $m->field("Name" => 'different dashboard');
 $m->content_lacks('Delete', "Delete button hidden because we are creating");
 $m->click_button(value => 'Save Changes');
@@ -168,7 +168,7 @@
 $m->get_ok("/Dashboards/Modify.html?id=$id");
 $m->content_contains('Delete', "Delete button shows because we have DeleteOwnDashboard");
 
-$m->form_name('ModifyDashboard');
+$m->form_name('modify_dashboard');
 $m->click_button(name => 'Delete');
 $m->content_contains("Deleted dashboard $id");

More information about the Rt-commit mailing list