[Rt-commit] r15593 - in rt/branches/3.999-DANGEROUS: .

[sunnavy at bestpractical.com]

Author: sunnavy
Date: Thu Aug 28 05:36:57 2008
New Revision: 15593

Modified:
   rt/branches/3.999-DANGEROUS/   (props changed)
   rt/branches/3.999-DANGEROUS/t/ticket/sort-by-queue.t
   rt/branches/3.999-DANGEROUS/t/ticket/sort-by-user.t

Log:
 r16243 at sunnavys-mb:  sunnavy | 2008-08-28 15:22:04 +0800
 name fixes


Modified: rt/branches/3.999-DANGEROUS/t/ticket/sort-by-queue.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/ticket/sort-by-queue.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/ticket/sort-by-queue.t	Thu Aug 28 05:36:57 2008
@@ -11,7 +11,7 @@
 use RT::Model::CustomField;
 
 #########################################################
-# Test sorting by Queue, we sort by its name
+# Test sorting by queue, we sort by its name
 #########################################################
 
 
@@ -63,6 +63,7 @@
 
             my ($order_ok, $last) = (1, $order eq 'ASC'? '-': 'zzzzzz');
             while ( my $t = $tix->next ) {
+                use Data::Dumper;
                 my $tmp;
                 if ( $order eq 'ASC' ) {
                     $tmp = ((split( /,/, $last))[0] cmp (split( /,/, $t->subject))[0]);
@@ -82,7 +83,7 @@
                 diag "Wrong SQL query:". $tix->build_select_query;
                 $tix->goto_first_item;
                 while ( my $t = $tix->next ) {
-                    diag sprintf "%02d %02d- %s", $t->queue_obj->id, $t->id, $t->subject;
+                    diag sprintf "%02d- %s", $t->id, $t->subject;
                 }
             }
         }
@@ -98,4 +99,3 @@
     { order => "queue" },
 );
 run_tests();
-

Modified: rt/branches/3.999-DANGEROUS/t/ticket/sort-by-user.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/ticket/sort-by-user.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/ticket/sort-by-user.t	Thu Aug 28 05:36:57 2008
@@ -11,7 +11,7 @@
 use RT::Model::CustomField;
 
 #########################################################
-# Test sorting by Owner, Creator and LastUpdatedBy
+# Test sorting by owner, creator and last_updated_by
 # we sort by user name
 #########################################################
 
@@ -58,15 +58,15 @@
         my %args = %{ shift(@data) };
 
         my ( $id, undef, $msg ) = $t->create( %args, queue => $queue->id );
-        if ( $args{'Owner'} ) {
-            is $t->owner, $args{'Owner'}, "owner is correct";
+        if ( $args{'owner'} ) {
+            is $t->owner, $args{'owner'}, "owner is correct";
         }
-        if ( $args{'Creator'} ) {
-            is $t->creator, $args{'Creator'}, "creator is correct";
+        if ( $args{'creator'} ) {
+            is $t->creator->id, $args{'creator'}, "creator is correct";
         }
         # hackish, but simpler
-        if ( $args{'LastUpdatedBy'} ) {
-            $t->__Set( field => 'LastUpdatedBy', value => $args{'LastUpdatedBy'} );
+        if ( $args{'last_updated_by'} ) {
+            $t->__set( column => 'last_updated_by', value => $args{'last_updated_by'} );
         }
         ok( $id, "ticket created" ) or diag("error: $msg");
         push @res, $t;
@@ -125,7 +125,7 @@
 );
 @tickets = add_tix_from_data();
 @test = (
-    { order => "Owner" },
+    { order => "owner" },
 );
 run_tests();
 
@@ -136,7 +136,7 @@
 );
 @tickets = add_tix_from_data();
 @test = (
-    { order => "Creator" },
+    { order => "creator" },
 );
 run_tests();