[Rt-commit] r17331 - in rt/3.8/trunk: .

falcone at bestpractical.com falcone at bestpractical.com
Wed Dec 24 13:15:53 EST 2008


Author: falcone
Date: Wed Dec 24 13:15:52 2008
New Revision: 17331

Modified:
   rt/3.8/trunk/   (props changed)
   rt/3.8/trunk/share/html/Elements/EditCustomField

Log:
 r42829 at ketch:  falcone | 2008-12-24 13:15:32 -0500
 * The only time we should be calling Count is if we're populating
   $Values inside the if block


Modified: rt/3.8/trunk/share/html/Elements/EditCustomField
==============================================================================
--- rt/3.8/trunk/share/html/Elements/EditCustomField	(original)
+++ rt/3.8/trunk/share/html/Elements/EditCustomField	Wed Dec 24 13:15:52 2008
@@ -59,10 +59,10 @@
     $Values = $Object->CustomFieldValues( $CustomField->id );
     $Values->Columns( qw( id CustomField ObjectType ObjectId Disabled Content ContentType ContentEncoding SortOrder Creator Created LastUpdatedBy LastUpdated ) );
     $NamePrefix ||= join('-', 'Object', ref($Object), $Object->Id, 'CustomField', '');
-}
 
-# Don't take care of $Values if there isn't values inside
-undef ( $Values ) unless ( $Values->Count );
+    # Don't take care of $Values if there isn't values inside
+    undef ( $Values ) unless ( $Values->Count );
+}
 
 # Always fill $Default with submited values if it's empty
 if ( not $Default ) {


More information about the Rt-commit mailing list