[Rt-commit] r10571 - in rt/branches/3.999-DANGEROUS/lib/RT/Shredder: .
ruz at bestpractical.com
ruz at bestpractical.com
Tue Jan 29 19:07:25 EST 2008
Author: ruz
Date: Tue Jan 29 19:07:25 2008
New Revision: 10571
Modified:
rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Attachment.pm
rt/branches/3.999-DANGEROUS/lib/RT/Shredder/CachedGroupMember.pm
rt/branches/3.999-DANGEROUS/lib/RT/Shredder/CustomField.pm
rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Exceptions.pm
rt/branches/3.999-DANGEROUS/lib/RT/Shredder/GroupMember.pm
rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Link.pm
rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Plugin/Summary.pm
rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Plugin/Users.pm
rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Record.pm
rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Ticket.pm
Log:
* lower method calls in shredder
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Attachment.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Attachment.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Attachment.pm Tue Jan 29 19:07:25 2008
@@ -102,7 +102,7 @@
# Parent, nested parts
if ( $self->parent ) {
- if ( $self->parent_obj && $self->ParentId ) {
+ if ( $self->parent_obj && $self->parent_id ) {
push( @$list, $self->parent_obj );
} else {
my $rec = $args{'Shredder'}->get_record( Object => $self );
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/CachedGroupMember.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/CachedGroupMember.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/CachedGroupMember.pm Tue Jan 29 19:07:25 2008
@@ -83,13 +83,13 @@
)
{
my $acl = RT::Model::ACECollection->new;
- $acl->limit_to_principal( id => $self->GroupId );
+ $acl->limit_to_principal( id => $self->group_id );
# look into all rights that have group
while ( my $ace = $acl->next ) {
my $delegations = RT::Model::ACECollection->new;
$delegations->delegated_from( id => $ace->id );
- $delegations->delegated_by( id => $self->MemberId );
+ $delegations->delegated_by( id => $self->member_id );
push( @$list, $delegations );
}
}
@@ -127,7 +127,7 @@
$self = $rec->{'Object'};
$rec->{'State'} |= INVALID;
$rec->{'Description'}
- = "Have no related Principal #" . $self->MemberId . " object.";
+ = "Have no related Principal #" . $self->member_id . " object.";
}
$obj = $self->group_obj;
@@ -138,7 +138,7 @@
$self = $rec->{'Object'};
$rec->{'State'} |= INVALID;
$rec->{'Description'}
- = "Have no related Principal #" . $self->GroupId . " object.";
+ = "Have no related Principal #" . $self->group_id . " object.";
}
$deps->_push_dependencies(
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/CustomField.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/CustomField.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/CustomField.pm Tue Jan 29 19:07:25 2008
@@ -100,7 +100,7 @@
# Queue
# Skip if it's global CF
- if ( $self->Queue ) {
+ if ( $self->queue ) {
if ( $self->queue_obj && $self->queue_obj->id ) {
push( @$list, $obj );
} else {
@@ -108,7 +108,7 @@
$self = $rec->{'Object'};
$rec->{'State'} |= INVALID;
$rec->{'Description'}
- = "Have no related queue #" . $self->Queue . " object";
+ = "Have no related queue #" . $self->queue . " object";
}
}
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Exceptions.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Exceptions.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Exceptions.pm Tue Jan 29 19:07:25 2008
@@ -54,7 +54,7 @@
use base qw(Exception::Class::Base);
BEGIN {
- __PACKAGE__->NoRefs(0);
+ __PACKAGE__->no_refs(0);
}
#sub NoRefs { return 0 }
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/GroupMember.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/GroupMember.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/GroupMember.pm Tue Jan 29 19:07:25 2008
@@ -70,8 +70,8 @@
my $list = [];
my $objs = RT::Model::CachedGroupMemberCollection->new;
- $objs->limit( column => 'MemberId', value => $self->MemberId );
- $objs->limit( column => 'ImmediateParentId', value => $self->GroupId );
+ $objs->limit( column => 'MemberId', value => $self->member_id );
+ $objs->limit( column => 'ImmediateParentId', value => $self->group_id );
push( @$list, $objs );
# XXX: right delegations should be cleaned here
@@ -165,7 +165,7 @@
$self = $rec->{'Object'};
$rec->{'State'} |= INVALID;
$rec->{'Description'}
- = "Have no related Principal #" . $self->MemberId . " object.";
+ = "Have no related Principal #" . $self->member_id . " object.";
}
$obj = $self->group_obj;
@@ -176,7 +176,7 @@
$self = $rec->{'Object'};
$rec->{'State'} |= INVALID;
$rec->{'Description'}
- = "Have no related Principal #" . $self->GroupId . " object.";
+ = "Have no related Principal #" . $self->group_id . " object.";
}
$deps->_push_dependencies(
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Link.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Link.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Link.pm Tue Jan 29 19:07:25 2008
@@ -84,7 +84,7 @@
operator => '=',
value => 'AddLink',
);
- $objs->limit( column => 'new_value', value => $self->Target );
+ $objs->limit( column => 'new_value', value => $self->target );
while ( my ( $k, $v ) = each %$map ) {
next unless $v->{'type'} eq $link_meta->{'type'};
next unless $v->{'Mode'} eq $link_meta->{'Mode'};
@@ -101,7 +101,7 @@
operator => '=',
value => 'AddLink',
);
- $objs->limit( column => 'new_value', value => $self->Base );
+ $objs->limit( column => 'new_value', value => $self->base );
while ( my ( $k, $v ) = each %$map ) {
next unless $v->{'type'} eq $link_meta->{'type'};
next unless $v->{'Mode'} eq $reverse{ $link_meta->{'Mode'} };
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Plugin/Summary.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Plugin/Summary.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Plugin/Summary.pm Tue Jan 29 19:07:25 2008
@@ -160,7 +160,7 @@
sub __make_hash {
my ( $self, $obj ) = @_;
my %hash;
- $hash{$_} = $obj->$_() foreach sort keys %{ $obj->_ClassAccessible };
+ $hash{$_} = $obj->$_() foreach sort keys %{ $obj->_class_accessible };
return \%hash;
}
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Plugin/Users.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Plugin/Users.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Plugin/Users.pm Tue Jan 29 19:07:25 2008
@@ -189,7 +189,7 @@
my %args = (@_);
my $t = $args{'TargetObject'};
foreach my $method (qw(Creator LastUpdatedBy)) {
- next unless $t->_Accessible( $method => 'read' );
+ next unless $t->_accessible( $method => 'read' );
$t->__set( column => $method, value => $uid );
}
};
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Record.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Record.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Record.pm Tue Jan 29 19:07:25 2008
@@ -186,7 +186,7 @@
if ( $self->can('Creator') ) {
my $obj = RT::Model::Principal->new;
- $obj->load( $self->Creator );
+ $obj->load( $self->creator );
if ( $obj && defined $obj->id ) {
push( @$list, $obj );
@@ -196,14 +196,14 @@
$rec->{'State'} |= INVALID;
push @{ $rec->{'Description'} },
"Have no related User(Creator) #"
- . $self->Creator
+ . $self->creator
. " object";
}
}
if ( $self->can('LastUpdatedBy') ) {
my $obj = RT::Model::Principal->new;
- $obj->load( $self->LastUpdatedBy );
+ $obj->load( $self->last_updated_by );
if ( $obj && defined $obj->id ) {
push( @$list, $obj );
@@ -213,7 +213,7 @@
$rec->{'State'} |= INVALID;
push @{ $rec->{'Description'} },
"Have no related User(LastUpdatedBy) #"
- . $self->LastUpdatedBy
+ . $self->last_updated_by
. " object";
}
}
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Ticket.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Ticket.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Ticket.pm Tue Jan 29 19:07:25 2008
@@ -110,7 +110,7 @@
$self = $rec->{'Object'};
$rec->{'State'} |= INVALID;
$rec->{'Description'}
- = "Have no related Queue #" . $self->Queue . " object";
+ = "Have no related Queue #" . $self->queue . " object";
}
$deps->_push_dependencies(
More information about the Rt-commit
mailing list