[Rt-commit] r10576 - in rt/branches/3.999-DANGEROUS/lib/RT: Model
ruz at bestpractical.com
ruz at bestpractical.com
Tue Jan 29 22:36:01 EST 2008
Author: ruz
Date: Tue Jan 29 22:36:00 2008
New Revision: 10576
Modified:
rt/branches/3.999-DANGEROUS/lib/RT/Model/ObjectCustomField.pm
rt/branches/3.999-DANGEROUS/lib/RT/Model/TicketCollection.pm
rt/branches/3.999-DANGEROUS/lib/RT/Model/Transaction.pm
rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/SendEmail.pm
Log:
* random API changes
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/ObjectCustomField.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/ObjectCustomField.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/ObjectCustomField.pm Tue Jan 29 22:36:00 2008
@@ -58,14 +58,14 @@
use Jifty::DBI::Schema;
use Jifty::DBI::Record schema {
column custom_field => type is 'int(11)', max_length is 11, default is '0';
- column Creator => type is 'int(11)', max_length is 11, default is '0';
+ column creator => type is 'int(11)', max_length is 11, default is '0';
column object_id => type is 'int(11)', max_length is 11, default is '0';
column
- LastUpdatedBy => type is 'int(11)',
+ last_updated_by => type is 'int(11)',
max_length is 11, default is '0';
- column SortOrder => type is 'int(11)', max_length is 11, default is '0';
- column Created => type is 'datetime', default is '';
- column LastUpdated => type is 'datetime', default is '';
+ column sort_order => type is 'int(11)', max_length is 11, default is '0';
+ column created => type is 'datetime', default is '';
+ column last_updated => type is 'datetime', default is '';
};
@@ -74,7 +74,7 @@
my %args = (
custom_field => 0,
object_id => 0,
- SortOrder => undef,
+ sort_order => undef,
@_
);
@@ -96,23 +96,23 @@
return $first->id;
}
- unless ( defined $args{'SortOrder'} ) {
+ unless ( defined $args{'sort_order'} ) {
my $ObjectCFs = RT::Model::ObjectCustomFieldCollection->new(
current_user => RT->system_user );
$ObjectCFs->limit_to_object_id( $args{'object_id'} );
$ObjectCFs->limit_to_lookup_type( $cf->lookup_type );
$ObjectCFs->order_by( column => 'sort_order', order => 'DESC' );
if ( my $first = $ObjectCFs->first ) {
- $args{'SortOrder'} = $first->sort_order + 1;
+ $args{'sort_order'} = $first->sort_order + 1;
} else {
- $args{'SortOrder'} = 0;
+ $args{'sort_order'} = 0;
}
}
return $self->SUPER::create(
custom_field => $args{'custom_field'},
object_id => $args{'object_id'},
- SortOrder => $args{'SortOrder'},
+ sort_order => $args{'sort_order'},
);
}
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/TicketCollection.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/TicketCollection.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/TicketCollection.pm Tue Jan 29 22:36:00 2008
@@ -1439,7 +1439,7 @@
entry_aggregator => 'AND'
);
- push @res, { %$row, alias => $CFvs, column => 'SortOrder' };
+ push @res, { %$row, alias => $CFvs, column => 'sort_order' };
push @res, { %$row, alias => $TicketCFs, column => 'content' };
} elsif ( $field eq "Custom" && $subkey eq "Ownership" ) {
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Transaction.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Transaction.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Transaction.pm Tue Jan 29 22:36:00 2008
@@ -40,9 +40,9 @@
type is 'varchar(255)', default is '';
column old_reference => max_length is 11, type is 'int(11)', default is '';
column new_reference => max_length is 11, type is 'int(11)', default is '';
- column Data => max_length is 255, type is 'varchar(255)', default is '';
- column Creator => max_length is 11, type is 'int(11)', default is '0';
- column Created => type is 'datetime', default is '';
+ column data => max_length is 255, type is 'varchar(255)', default is '';
+ column creator => max_length is 11, type is 'int(11)', default is '0';
+ column created => type is 'datetime', default is '';
};
@@ -87,7 +87,7 @@
-=head2 SetTimeTaken value
+=head2 set_time_taken value
Set time_taken to value.
@@ -121,7 +121,7 @@
-=head2 SetField value
+=head2 set_field value
Set field to value.
@@ -172,7 +172,7 @@
-=head2 SetReferenceType value
+=head2 set_reference_type value
Set reference_type to value.
@@ -189,7 +189,7 @@
-=head2 SetOldReference value
+=head2 set_old_reference value
Set old_reference to value.
@@ -206,7 +206,7 @@
-=head2 SetNewReference value
+=head2 set_new_reference value
Set new_reference to value.
@@ -216,35 +216,35 @@
=cut
-=head2 Data
+=head2 data
-Returns the current value of Data.
-(In the database, Data is stored as varchar(255).)
+Returns the current value of data.
+(In the database, data is stored as varchar(255).)
-=head2 SetData value
+=head2 set_data value
-Set Data to value.
+Set data to value.
Returns (1, 'Status message') on success and (0, 'Error Message') on failure.
-(In the database, Data will be stored as a varchar(255).)
+(In the database, data will be stored as a varchar(255).)
=cut
-=head2 Creator
+=head2 creator
-Returns the current value of Creator.
-(In the database, Creator is stored as int(11).)
+Returns the current value of creator.
+(In the database, creator is stored as int(11).)
=cut
-=head2 Created
+=head2 created
-Returns the current value of Created.
-(In the database, Created is stored as datetime.)
+Returns the current value of created.
+(In the database, created is stored as datetime.)
=cut
@@ -280,7 +280,7 @@
id => undef,
time_taken => 0,
type => 'undefined',
- Data => '',
+ data => '',
field => undef,
old_value => undef,
new_value => undef,
@@ -309,11 +309,11 @@
#lets create our transaction
my %params = (
type => $args{'type'},
- Data => $args{'Data'},
+ data => $args{'data'},
field => $args{'field'},
old_value => $args{'old_value'},
new_value => $args{'new_value'},
- Created => $args{'Created'},
+ created => $args{'created'},
object_type => $args{'object_type'},
object_id => $args{'object_id'},
reference_type => $args{'reference_type'},
@@ -323,7 +323,7 @@
# Parameters passed in during an import that we probably don't want to touch, otherwise
foreach my $attr
- qw(id Creator Created LastUpdated time_taken LastUpdatedBy) {
+ qw(id creator created last_updated time_taken last_updated_by) {
$params{$attr} = $args{$attr} if ( $args{$attr} );
}
@@ -373,7 +373,7 @@
=head2 Scrips
Returns the Scrips object for this transaction.
-This routine is only useful on a freshly Created transaction object.
+This routine is only useful on a freshly created transaction object.
Scrips do not get persisted to the database with transactions.
@@ -553,9 +553,9 @@
}
-# {{{ ContentObj
+# {{{ content_obj
-=head2 ContentObj
+=head2 content_obj
Returns the RT::Model::Attachment object which contains the content for this Transaction
@@ -717,9 +717,9 @@
# }}}
-# {{{ sub BriefDescription
+# {{{ sub brief_description
-=head2 BriefDescription
+=head2 brief_description
Returns a text string which briefly describes this transaction
@@ -996,9 +996,9 @@
# {{{ Utility methods
-# {{{ sub IsInbound
+# {{{ sub is_inbound
-=head2 IsInbound
+=head2 is_inbound
Returns true if the creator of the transaction is a requestor of the ticket.
Returns false otherwise
@@ -1170,7 +1170,7 @@
return _($type);
}
-=head2 UpdateCustomFields
+=head2 update_custom_fields
Takes a hash of
Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/SendEmail.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/SendEmail.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/SendEmail.pm Tue Jan 29 22:36:00 2008
@@ -407,7 +407,7 @@
);
}
-=head2 AttachTickets [@IDs]
+=head2 attach_tickets [@IDs]
Returns or set list of ticket's IDs that should be attached to an outgoing message.
@@ -419,7 +419,7 @@
{
my $list = [];
- sub AttachTickets {
+ sub attach_tickets {
my $self = shift;
$list = [ grep defined, @_ ] if @_;
return @$list;
More information about the Rt-commit
mailing list