[Rt-commit] r10602 - in rt/branches/3.999-DANGEROUS: . lib/RT lib/RT/Model

jesse at bestpractical.com jesse at bestpractical.com
Wed Jan 30 18:37:46 EST 2008


Author: jesse
Date: Wed Jan 30 18:37:46 2008
New Revision: 10602

Modified:
   rt/branches/3.999-DANGEROUS/   (props changed)
   rt/branches/3.999-DANGEROUS/html/Admin/Groups/index.html
   rt/branches/3.999-DANGEROUS/lib/RT/Model/Attachment.pm
   rt/branches/3.999-DANGEROUS/lib/RT/SearchBuilder.pm

Log:
 r75974 at pinglin:  jesse | 2008-01-30 18:36:45 -0500
 * It's useful not to name two subroutines the same thing. seperate out find_disabled_rows


Modified: rt/branches/3.999-DANGEROUS/html/Admin/Groups/index.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Admin/Groups/index.html	(original)
+++ rt/branches/3.999-DANGEROUS/html/Admin/Groups/index.html	Wed Jan 30 18:37:46 2008
@@ -89,7 +89,7 @@
 my $caption;
 
 if ($FinddisabledGroups) {
-    $Groups->find_all_rows();
+    $Groups->include_disabled_rows();
 }
 
 if (length $GroupString) {

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Attachment.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Attachment.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Attachment.pm	Wed Jan 30 18:37:46 2008
@@ -102,7 +102,7 @@
     $message_id =~ s/^<(.*?)>$/$1/o;
 
     #Get the filename
-    my $Filename = $Attachment->head->recommended_filename;
+    my $filename = $Attachment->head->recommended_filename;
 
 # If a message has no bodyhandle, that means that it has subparts (or appears to)
 # and we should act accordingly.
@@ -151,7 +151,7 @@
             headers         => $Attachment->head->as_string,
             subject         => $subject,
             content         => $Body,
-            Filename        => $Filename,
+            filename        => $filename,
             message_id       => $message_id,
         );
 

Modified: rt/branches/3.999-DANGEROUS/lib/RT/SearchBuilder.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/SearchBuilder.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/SearchBuilder.pm	Wed Jan 30 18:37:46 2008
@@ -239,13 +239,13 @@
     );
 }
 
-=head2 FindAllRows
+=head2 include_disabled_rows
 
 Find all matching rows, regardless of whether they are disabled or not
 
 =cut
 
-sub find_all_rows {
+sub include_disabled_rows {
     shift->{'find_disabled_rows'} = 1;
 }
 


More information about the Rt-commit mailing list