[Rt-commit] r13928 - in rt/3.8/trunk: .

[falcone at bestpractical.com]

Author: falcone
Date: Wed Jul  9 16:34:39 2008
New Revision: 13928

Modified:
   rt/3.8/trunk/   (props changed)
   rt/3.8/trunk/lib/RT/Links_Overlay.pm

Log:
 r35342 at ketch:  falcone | 2008-07-09 16:32:37 -0400
 * RTFM used to allow you to create a Link with a NULL Base or Target
   This is being fixed in RTFM, but previously you could not even view
   and Article with an invalid Link


Modified: rt/3.8/trunk/lib/RT/Links_Overlay.pm
==============================================================================
--- rt/3.8/trunk/lib/RT/Links_Overlay.pm	(original)
+++ rt/3.8/trunk/lib/RT/Links_Overlay.pm	Wed Jul  9 16:34:39 2008
@@ -153,6 +153,10 @@
     my $Link = $self->SUPER::Next();
     return $Link unless $Link && ref $Link;
 
+    # skip very invalid Link records
+    unless ($Link->Target && $Link->Base) {
+        return $self->Next;
+    }
     # Skip links to local objects thast are deleted
     if ( $Link->TargetURI->IsLocal and UNIVERSAL::isa($Link->TargetObj,"RT::Ticket")
              and $Link->TargetObj->__Value('status') eq "deleted") {