[Rt-commit] r13942 - in rt/3.8/trunk: lib/RT share/html/REST/1.0/Forms/ticket

[jesse at bestpractical.com]

Author: jesse
Date: Thu Jul 10 10:14:32 2008
New Revision: 13942

Modified:
   rt/3.8/trunk/lib/RT/Interface/REST.pm
   rt/3.8/trunk/lib/RT/Ticket_Overlay.pm
   rt/3.8/trunk/share/html/REST/1.0/Forms/ticket/history

Log:
* Cleaning up some uninit warnings.  Backing down some "critical" warnings which aren't to debug warning

Modified: rt/3.8/trunk/lib/RT/Interface/REST.pm
==============================================================================
--- rt/3.8/trunk/lib/RT/Interface/REST.pm	(original)
+++ rt/3.8/trunk/lib/RT/Interface/REST.pm	Thu Jul 10 10:14:32 2008
@@ -295,7 +295,7 @@
     my ($val) = @_;
     my ($line, $word, @words);
 
-    foreach $line (map {split /\n/} (ref $val eq 'ARRAY') ? @$val : $val)
+    foreach $line (map {split /\n/} (ref $val eq 'ARRAY') ? @$val : ($val||''))
     {
         # XXX: This should become a real parser, ? la Text::ParseWords.
         $line =~ s/^\s+//;

Modified: rt/3.8/trunk/lib/RT/Ticket_Overlay.pm
==============================================================================
--- rt/3.8/trunk/lib/RT/Ticket_Overlay.pm	(original)
+++ rt/3.8/trunk/lib/RT/Ticket_Overlay.pm	Thu Jul 10 10:14:32 2008
@@ -169,14 +169,14 @@
         my ($ticketid,$msg) = $self->LoadById($id);
 
         unless ($self->Id) {
-            $RT::Logger->crit("$self tried to load a bogus ticket: $id");
+            $RT::Logger->debug("$self tried to load a bogus ticket: $id");
             return (undef);
         }
     }
 
     #It's not a URI. It's not a numerical ticket ID. Punt!
     else {
-        $RT::Logger->warning("Tried to load a bogus ticket id: '$id'");
+        $RT::Logger->debug("Tried to load a bogus ticket id: '$id'");
         return (undef);
     }
 

Modified: rt/3.8/trunk/share/html/REST/1.0/Forms/ticket/history
==============================================================================
--- rt/3.8/trunk/share/html/REST/1.0/Forms/ticket/history	(original)
+++ rt/3.8/trunk/share/html/REST/1.0/Forms/ticket/history	Thu Jul 10 10:14:32 2008
@@ -148,7 +148,7 @@
 	my $attachlist;
 	my $attachments = $t->Attachments;
 	while (my $a = $attachments->Next) {
-	    my $size = length($a->Content);
+	    my $size = length($a->Content||'');
 	    if ($size > 1024) { $size  = int($size/102.4)/10 . "k" }
 	    else              { $size .= "b" }
 	    $attachlist .= "\n" . $a->Id.": ".($a->Filename || "untitled")." (".$size.")";