[Rt-commit] r14110 - in rt/branches/3.999-DANGEROUS: . lib/RT lib/RT/Graph lib/RT/ScripAction sbin share/html/Dashboards/Elements share/html/Ticket/Graphs/Elements

sunnavy at bestpractical.com sunnavy at bestpractical.com
Tue Jul 15 05:31:45 EDT 2008


Author: sunnavy
Date: Tue Jul 15 05:31:42 2008
New Revision: 14110

Modified:
   rt/branches/3.999-DANGEROUS/   (props changed)
   rt/branches/3.999-DANGEROUS/lib/RT/Dashboard.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Graph/Tickets.pm
   rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/LinearEscalate.pm
   rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm
   rt/branches/3.999-DANGEROUS/sbin/rt-email-dashboards.in
   rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/DashboardsForObject
   rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/Elements/ShowGraph
   rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/dhandler

Log:
 r14476 at sunnavys-mb:  sunnavy | 2008-07-15 14:33:33 +0800
 no $RT::Logger any more


Modified: rt/branches/3.999-DANGEROUS/lib/RT/Dashboard.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Dashboard.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Dashboard.pm	Tue Jul 15 05:31:42 2008
@@ -272,7 +272,7 @@
     my %args    = @_;
 
     if ( !defined($privacy) ) {
-        $RT::Logger->debug("No privacy provided to $self->_CurrentUserCan");
+        Jifty->log->debug("No privacy provided to $self->_CurrentUserCan");
         return 0;
     }
 
@@ -285,7 +285,7 @@
     elsif ( $object->isa('RT::Group') )  { $level = 'Group' }
     elsif ( $object->isa('RT::System') ) { $level = '' }
     else {
-        $RT::Logger->error("Unknown object $object from privacy $privacy");
+        Jifty->log->error("Unknown object $object from privacy $privacy");
         return 0;
     }
 

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Graph/Tickets.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Graph/Tickets.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Graph/Tickets.pm	Tue Jul 15 05:31:42 2008
@@ -206,7 +206,7 @@
     foreach my $property (@properties) {
         my ( $key, @subkeys ) = $self->_SplitProperty($property);
         unless ( $property_cb{$key} ) {
-            $RT::Logger->error(
+            Jifty->log->error(
 "Couldn't find property handler for '$key' and '@subkeys' subkeys"
             );
             next;
@@ -254,7 +254,7 @@
             $value = $property_cb{$key}->( $args{'Ticket'}, @subkeys );
         }
         else {
-            $RT::Logger->error("Couldn't find property callback for '$key'");
+            Jifty->log->error("Couldn't find property callback for '$key'");
         }
         if ( defined $value && length $value && $value =~ /\S/ ) {
             my $fill = $fill_cache{$value};

Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/LinearEscalate.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/LinearEscalate.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/LinearEscalate.pm	Tue Jul 15 05:31:42 2008
@@ -159,25 +159,25 @@
 
     my $due = $ticket->DueObj->Unix;
     unless ( $due > 0 ) {
-        $RT::Logger->debug('Due is not set. Not escalating.');
+        Jifty->log->debug('Due is not set. Not escalating.');
         return 1;
     }
 
     my $priority_range = $ticket->FinalPriority - $ticket->InitialPriority;
     unless ($priority_range) {
-        $RT::Logger->debug(
+        Jifty->log->debug(
             'Final and Initial priorities are equal. Not escalating.');
         return 1;
     }
 
     if ( $ticket->Priority >= $ticket->FinalPriority && $priority_range > 0 ) {
-        $RT::Logger->debug(
+        Jifty->log->debug(
             'Current priority is greater than final. Not escalating.');
         return 1;
     }
     elsif ( $ticket->Priority <= $ticket->FinalPriority && $priority_range < 0 )
     {
-        $RT::Logger->debug(
+        Jifty->log->debug(
             'Current priority is lower than final. Not escalating.');
         return 1;
     }
@@ -193,7 +193,7 @@
 
     # do nothing if we didn't reach starts or created date
     if ( $starts > $now ) {
-        $RT::Logger->debug('Starts(Created) is in future. Not escalating.');
+        Jifty->log->debug('Starts(Created) is in future. Not escalating.');
         return 1;
     }
 
@@ -227,16 +227,16 @@
         my $arg = $self->Argument || '';
         if ( $arg =~ /RecordTransaction:\s*(\d+)/i ) {
             $record = $1;
-            $RT::Logger->debug("Overrode RecordTransaction: $record");
+            Jifty->log->debug("Overrode RecordTransaction: $record");
         }
         if ( $arg =~ /UpdateLastUpdated:\s*(\d+)/i ) {
             $update = $1;
-            $RT::Logger->debug("Overrode UpdateLastUpdated: $update");
+            Jifty->log->debug("Overrode UpdateLastUpdated: $update");
         }
         $update = 1 if $record;
     }
 
-    $RT::Logger->debug( 'Linearly escalating priority of ticket #'
+    Jifty->log->debug( 'Linearly escalating priority of ticket #'
           . $ticket->Id
           . ' from '
           . $ticket->Priority . ' to '
@@ -267,7 +267,7 @@
     }
 
     unless ($val) {
-        $RT::Logger->error("Couldn't set new priority value: $msg");
+        Jifty->log->error("Couldn't set new priority value: $msg");
         return ( 0, $msg );
     }
     return 1;

Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm	Tue Jul 15 05:31:42 2008
@@ -107,15 +107,15 @@
     my $obj = RT::Principal->new($RT::SystemUser);
     $obj->Load($instance);
     unless ( $obj->id ) {
-        $RT::Logger->error("Couldn't load principal #$instance");
+        Jifty->log->error("Couldn't load principal #$instance");
         return;
     }
     if ( $obj->Disabled ) {
-        $RT::Logger->info("Principal #$instance is disabled => skip");
+        Jifty->log->info("Principal #$instance is disabled => skip");
         return;
     }
     if ( !$obj->PrincipalType ) {
-        $RT::Logger->crit("Principal #$instance has empty type");
+        Jifty->log->crit("Principal #$instance has empty type");
     }
     elsif ( lc $obj->PrincipalType eq 'user' ) {
         $self->__HandleUserArgument( $obj->Object );
@@ -124,7 +124,7 @@
         $self->__HandleGroupArgument( $obj->Object );
     }
     else {
-        $RT::Logger->info("Principal #$instance has unsupported type");
+        Jifty->log->info("Principal #$instance has unsupported type");
     }
     return;
 }
@@ -135,7 +135,7 @@
 
     my $uea = $obj->EmailAddress;
     unless ($uea) {
-        $RT::Logger->warning( "User #" . $obj->id . " has no email address" );
+        Jifty->log->warn( "User #" . $obj->id . " has no email address" );
         return;
     }
     $self->__PushUserAddress($uea);

Modified: rt/branches/3.999-DANGEROUS/sbin/rt-email-dashboards.in
==============================================================================
--- rt/branches/3.999-DANGEROUS/sbin/rt-email-dashboards.in	(original)
+++ rt/branches/3.999-DANGEROUS/sbin/rt-email-dashboards.in	Tue Jul 15 05:31:42 2008
@@ -116,8 +116,8 @@
 # helper functions
 sub verbose  { print loc(@_), "\n" if $opts{verbose} || $opts{verbose}; 1 }
 sub debug    { print loc(@_), "\n" if $opts{debug}; 1 }
-sub error    { $RT::Logger->error(loc(@_)); verbose(@_); 1 }
-sub warning  { $RT::Logger->warning(loc(@_)); verbose(@_); 1 }
+sub error    { Jifty->log->error(loc(@_)); verbose(@_); 1 }
+sub warning  { Jifty->log->warn(loc(@_)); verbose(@_); 1 }
 
 my $now = $opts{epoch} || time;
 verbose "Using time [_1]", scalar localtime($now);

Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/DashboardsForObject
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/DashboardsForObject	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/DashboardsForObject	Tue Jul 15 05:31:42 2008
@@ -61,7 +61,7 @@
         my ($ok, $msg) = $dashboard->Load($privacy, $attr->id);
 
         if (!$ok) {
-            $RT::Logger->debug("Unable to load dashboard $ok (privacy $privacy): $msg");
+            Jifty->log->debug("Unable to load dashboard $ok (privacy $privacy): $msg");
             next;
         }
 

Modified: rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/Elements/ShowGraph
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/Elements/ShowGraph	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/Elements/ShowGraph	Tue Jul 15 05:31:42 2008
@@ -58,7 +58,7 @@
 my $ticket = RT::Ticket->new( $session{'CurrentUser'} );
 $ticket->Load( $id );
 unless ( $ticket->id ) {
-    $RT::Logger->error("Couldn't load ticket $id");
+    Jifty->log->error("Couldn't load ticket $id");
     return;
 }
 $ARGS{'id'} = $id = $ticket->id;

Modified: rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/dhandler
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/dhandler	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/dhandler	Tue Jul 15 05:31:42 2008
@@ -58,7 +58,7 @@
 my $ticket = RT::Ticket->new($session{'CurrentUser'} );
 $ticket->Load( $id );
 unless ( $ticket->id ) {
-    $RT::Logger->error("Couldn't load ticket #$id");
+    Jifty->log->error("Couldn't load ticket #$id");
     return $m->abort( 404 );
 }
 


More information about the Rt-commit mailing list