[Rt-commit] r14119 - in rt/branches/3.999-DANGEROUS: . lib/RT lib/RT/Graph lib/RT/ScripAction share/html/Admin/Groups share/html/Dashboards share/html/Dashboards/Elements share/html/Elements share/html/Elements/RT__Model__Ticket share/html/Elements/RT__Scrip share/html/NoAuth/iCal share/html/REST/1.0/Forms/ticket share/html/Search share/html/Ticket/Elements share/html/Tools/Reports t/api

sunnavy at bestpractical.com sunnavy at bestpractical.com
Tue Jul 15 09:27:33 EDT 2008


Author: sunnavy
Date: Tue Jul 15 09:27:31 2008
New Revision: 14119

Modified:
   rt/branches/3.999-DANGEROUS/   (props changed)
   rt/branches/3.999-DANGEROUS/lib/RT/Dashboard.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Graph/Tickets.pm
   rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/ExtractSubjectTag.pm
   rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/LinearEscalate.pm
   rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm
   rt/branches/3.999-DANGEROUS/sbin/rt-email-dashboards.in
   rt/branches/3.999-DANGEROUS/sbin/rt-email-digest.in
   rt/branches/3.999-DANGEROUS/sbin/rt-email-group-admin.in
   rt/branches/3.999-DANGEROUS/share/html/Admin/Groups/Members.html
   rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/DashboardsForObject
   rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/SelectPrivacy
   rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/ShowDashboards
   rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/Tabs
   rt/branches/3.999-DANGEROUS/share/html/Dashboards/Modify.html
   rt/branches/3.999-DANGEROUS/share/html/Dashboards/Queries.html
   rt/branches/3.999-DANGEROUS/share/html/Dashboards/Render.html
   rt/branches/3.999-DANGEROUS/share/html/Dashboards/Subscription.html
   rt/branches/3.999-DANGEROUS/share/html/Elements/RT__Model__Ticket/ColumnMap
   rt/branches/3.999-DANGEROUS/share/html/Elements/RT__Scrip/ColumnMap
   rt/branches/3.999-DANGEROUS/share/html/Elements/ShowLinks
   rt/branches/3.999-DANGEROUS/share/html/Elements/ShowUserConcise
   rt/branches/3.999-DANGEROUS/share/html/NoAuth/iCal/dhandler
   rt/branches/3.999-DANGEROUS/share/html/REST/1.0/Forms/ticket/default
   rt/branches/3.999-DANGEROUS/share/html/Search/Results.tsv
   rt/branches/3.999-DANGEROUS/share/html/Ticket/Elements/ShowDates
   rt/branches/3.999-DANGEROUS/share/html/Tools/Reports/CreatedByDates.html
   rt/branches/3.999-DANGEROUS/share/html/Tools/Reports/ResolvedByDates.html
   rt/branches/3.999-DANGEROUS/t/api/date.t

Log:
 r14494 at sunnavys-mb:  sunnavy | 2008-07-15 21:21:17 +0800
 many name fixes


Modified: rt/branches/3.999-DANGEROUS/lib/RT/Dashboard.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Dashboard.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Dashboard.pm	Tue Jul 15 09:27:31 2008
@@ -126,7 +126,7 @@
     if ( $status && $args->{'Name'} ) {
         ( $status, $msg ) =
           $self->{'Attribute'}->set_description( $args->{'Name'} )
-          unless $self->Name eq $args->{'Name'};
+          unless $self->name eq $args->{'Name'};
     }
 
     if ( $status && $args->{'Privacy'} ) {

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Graph/Tickets.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Graph/Tickets.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Graph/Tickets.pm	Tue Jul 15 09:27:31 2008
@@ -111,7 +111,7 @@
 our ( %fill_cache, @available_colors ) = ();
 
 our %property_cb = (
-    Queue => sub { return $_[0]->QueueObj->Name || $_[0]->Queue },
+    Queue => sub { return $_[0]->queue_obj->name || $_[0]->queue },
     CF => sub {
         my $values = $_[0]->CustomFieldValues( $_[1] );
         return join ', ', map $_->Content, @{ $values->ItemsArrayRef };
@@ -123,7 +123,7 @@
 foreach my $field (qw(Creator LastUpdatedBy Owner)) {
     $property_cb{$field} = sub {
         my $method = $field . 'Obj';
-        return $_[0]->$method->Name;
+        return $_[0]->$method->name;
     };
 }
 foreach my $field (qw(Requestor Cc AdminCc)) {
@@ -135,18 +135,18 @@
 foreach my $field (qw(Told Starts Started Due Resolved LastUpdated Created)) {
     $property_cb{$field} = sub {
         my $method = $field . 'Obj';
-        return $_[0]->$method->AsString;
+        return $_[0]->$method->as_string;
     };
 }
 foreach my $field (qw(Members DependedOnBy ReferredToBy)) {
     $property_cb{$field} = sub {
-        return join ', ', map $_->BaseObj->id,
+        return join ', ', map $_->base_obj->id,
           @{ $_[0]->$field->ItemsArrayRef };
     };
 }
 foreach my $field (qw(MemberOf DependsOn RefersTo)) {
     $property_cb{$field} = sub {
-        return join ', ', map $_->TargetObj->id,
+        return join ', ', map $_->target_obj->id,
           @{ $_[0]->$field->ItemsArrayRef };
     };
 }
@@ -166,13 +166,13 @@
     $cfs->OrderBy( FIELD => 'Name' );
     my ( $first, %seen ) = (1);
     while ( my $cf = $cfs->Next ) {
-        next if $seen{ lc $cf->Name }++;
+        next if $seen{ lc $cf->name }++;
         next if $cf->Type eq 'Image';
         if ($first) {
             push @res, 'CustomFields', [];
             $first = 0;
         }
-        push @{ $res[-1] }, 'CF.{' . $cf->Name . '}';
+        push @{ $res[-1] }, 'CF.{' . $cf->name . '}';
     }
     return @res;
 }
@@ -328,10 +328,10 @@
         while ( my $link = $links->Next ) {
             next if $args{'SeenEdge'}{ $link->id }++;
 
-            my $target = $link->TargetObj;
+            my $target = $link->target_obj;
             next unless $target && $target->isa('RT::Model::Ticket');
 
-            my $base = $link->BaseObj;
+            my $base = $link->base_obj;
             next unless $base && $base->isa('RT::Model::Ticket');
 
             my $next = $target->id == $args{'Ticket'}->id ? $base : $target;

Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/ExtractSubjectTag.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/ExtractSubjectTag.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/ExtractSubjectTag.pm	Tue Jul 15 09:27:31 2008
@@ -61,13 +61,13 @@
 
 sub Commit {
     my $self            = shift;
-    my $Transaction     = $self->TransactionObj;
+    my $Transaction     = $self->transaction_obj;
     my $FirstAttachment = $Transaction->Attachments->First;
     return 1 unless ($FirstAttachment);
 
-    my $Ticket = $self->TicketObj;
+    my $Ticket = $self->ticket_obj;
 
-    my $TicketSubject      = $self->TicketObj->Subject;
+    my $TicketSubject      = $self->ticket_obj->Subject;
     my $origTicketSubject  = $TicketSubject;
     my $TransactionSubject = $FirstAttachment->Subject;
 
@@ -79,7 +79,7 @@
         $TicketSubject .= " $tag" unless ( $TicketSubject =~ /\Q$tag\E/ );
     }
 
-    $self->TicketObj->SetSubject($TicketSubject)
+    $self->ticket_obj->SetSubject($TicketSubject)
       if ( $TicketSubject ne $origTicketSubject );
 
     return (1);

Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/LinearEscalate.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/LinearEscalate.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/LinearEscalate.pm	Tue Jul 15 09:27:31 2008
@@ -155,9 +155,9 @@
 sub Prepare {
     my $self = shift;
 
-    my $ticket = $self->TicketObj;
+    my $ticket = $self->ticket_obj;
 
-    my $due = $ticket->DueObj->Unix;
+    my $due = $ticket->due_obj->unix;
     unless ( $due > 0 ) {
         Jifty->log->debug('Due is not set. Not escalating.');
         return 1;
@@ -187,8 +187,8 @@
     # now we know we have a due date. for every day that passes,
     # increment priority according to the formula
 
-    my $starts = $ticket->StartsObj->Unix;
-    $starts = $ticket->CreatedObj->Unix unless $starts > 0;
+    my $starts = $ticket->starts_obj->unix;
+    $starts = $ticket->created_obj->unix unless $starts > 0;
     my $now = time;
 
     # do nothing if we didn't reach starts or created date
@@ -216,7 +216,7 @@
     my $new_value = $self->{'new_priority'};
     return 1 unless defined $new_value;
 
-    my $ticket = $self->TicketObj;
+    my $ticket = $self->ticket_obj;
 
     # if the priority hasn't changed do nothing
     return 1 if $ticket->Priority == $new_value;

Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm	Tue Jul 15 09:27:31 2008
@@ -90,7 +90,7 @@
         $self->_HandleArgument($_);
     }
 
-    my $creator = $self->TransactionObj->CreatorObj->EmailAddress();
+    my $creator = $self->transaction_obj->creator_obj->email();
     unless ($RT::NotifyActor) {
         @{ $self->{'To'} } = grep ( !/^\Q$creator\E$/, @{ $self->{'To'} } );
     }
@@ -133,7 +133,7 @@
     my $self = shift;
     my $obj  = shift;
 
-    my $uea = $obj->EmailAddress;
+    my $uea = $obj->email;
     unless ($uea) {
         Jifty->log->warn( "User #" . $obj->id . " has no email address" );
         return;

Modified: rt/branches/3.999-DANGEROUS/sbin/rt-email-dashboards.in
==============================================================================
--- rt/branches/3.999-DANGEROUS/sbin/rt-email-dashboards.in	(original)
+++ rt/branches/3.999-DANGEROUS/sbin/rt-email-dashboards.in	Tue Jul 15 09:27:31 2008
@@ -130,16 +130,16 @@
 $Users->LimitToPrivileged;
 
 while (defined(my $user = $Users->Next)) {
-    if ($user->PrincipalObj->Disabled) {
+    if ($user->principal_object->Disabled) {
         debug "Skipping over "
-            . $user->Name
+            . $user->name
             . " due to having a disabled account.";
         next;
     }
 
     unless (email_of($user)) {
         debug "Skipping over "
-            . $user->Name
+            . $user->name
             . " due to lack of EmailAddress.";
         next;
     }
@@ -147,10 +147,10 @@
     my ($hour, $dow, $dom) = hour_dow_dom_in($user->Timezone || RT->config->get('Timezone'));
     $hour .= ':00';
     debug "Checking [_1]'s subscriptions: hour [_2], dow [_3], dom [_4]",
-          $user->Name, $hour, $dow, $dom;
+          $user->name, $hour, $dow, $dom;
 
     my $currentuser = RT::CurrentUser->new;
-    $currentuser->LoadByName($user->Name);
+    $currentuser->LoadByName($user->name);
 
     # look through this user's subscriptions, are any supposed to be generated
     # right now?
@@ -194,7 +194,7 @@
         warning "Unable to load dashboard [_1] of subscription [_2] for user [_3]: [_4]",
             $subscription->SubValue('DashboardId'),
             $subscription->Id,
-            $currentuser->Name,
+            $currentuser->name,
             $msg;
 
         my $ok = RT::Interface::Email::SendEmailUsingTemplate(
@@ -217,20 +217,20 @@
             }
         }
         else {
-            warning("Unable to notify [_1] of an obsolete subscription", $currentuser->Name);
+            warning("Unable to notify [_1] of an obsolete subscription", $currentuser->name);
         }
 
         return;
     }
 
     verbose 'Creating dashboard "[_1]" for user "[_2]":',
-            $dashboard->Name,
-            $currentuser->Name;
+            $dashboard->name,
+            $currentuser->name;
 
     if ($opts{'dryrun'}) {
         print << "SUMMARY";
-    Dashboard: @{[ $dashboard->Name ]}
-    User:   @{[ $currentuser->Name ]} <@{[ email_of($currentuser) ]}>
+    Dashboard: @{[ $dashboard->name ]}
+    User:   @{[ $currentuser->name ]} <@{[ email_of($currentuser) ]}>
 SUMMARY
         return;
     }
@@ -260,14 +260,14 @@
     my ($currentuser, $dashboard, $subscription, $content) = @_;
 
     verbose 'Sending dashboard "[_1]" to user [_2] <[_3]>',
-            $dashboard->Name,
-            $currentuser->Name,
+            $dashboard->name,
+            $currentuser->name,
             email_of($currentuser);
 
     my $subject = sprintf '[%s] ' .  RT->config->get('DashboardSubject'),
         RT->config->get('rtname'),
         ucfirst($subscription->SubValue('Frequency')),
-        $dashboard->Name;
+        $dashboard->name;
 
     my $entity = build_email(
         $content, $from, email_of($currentuser), $subject,
@@ -278,11 +278,11 @@
     );
 
     debug "Done sending dashboard to [_1] <[_2]>",
-          $currentuser->Name, email_of($currentuser)
+          $currentuser->name, email_of($currentuser)
               and return if $ok;
 
     error 'Failed to email dashboard to user [_1] <[_2]>',
-          $currentuser->Name, email_of($currentuser);
+          $currentuser->name, email_of($currentuser);
 }
 
 sub build_email {
@@ -341,8 +341,8 @@
 
 sub email_of {
     my $user = shift;
-    return $user->EmailAddress if $user->EmailAddress;
-    return $user->Name if $user->Name =~ /\S@\S/;
+    return $user->email if $user->email;
+    return $user->name if $user->name =~ /\S@\S/;
     return undef;
 }
 

Modified: rt/branches/3.999-DANGEROUS/sbin/rt-email-digest.in
==============================================================================
--- rt/branches/3.999-DANGEROUS/sbin/rt-email-digest.in	(original)
+++ rt/branches/3.999-DANGEROUS/sbin/rt-email-digest.in	Tue Jul 15 09:27:31 2008
@@ -246,7 +246,7 @@
     $txns->Limit(
         FIELD    => 'Created',
         OPERATOR => '>',
-        VALUE    => $since_date->ISO
+        VALUE    => $since_date->iso
     );
 
     # Next limit to ticket transactions.
@@ -261,10 +261,10 @@
 
     while ( my $txn = $txns->Next ) {
         my $ticket = $txn->Ticket;
-        my $queue  = $txn->TicketObj->QueueObj->Name;
+        my $queue  = $txn->ticket_obj->queue_obj->name;
         # Xxx todo - may clobber if two queues have the same name
         foreach my $user ( $txn->DeferredRecipients($frequency) ) {
-            $all_digest->{$user}->{$queue}->{$ticket}->{ $txn->id } = $txn->ContentObj;
+            $all_digest->{$user}->{$queue}->{$ticket}->{ $txn->id } = $txn->content_obj;
             $sent_transactions->{$user}->{ $txn->id } = $txn;
         }
     }
@@ -283,7 +283,7 @@
     # behalf?
     my $user_obj = RT::Model::User->new( RT->SystemUser );
     $user_obj->LoadByEmail($user);
-    if ( $user_obj->PrincipalObj->Disabled ) {
+    if ( $user_obj->principal_object->Disabled ) {
         print STDERR loc("Skipping disabled user") . " $user\n";
         next;
     }
@@ -300,7 +300,7 @@
             # Spit out the index entry for this ticket.
             my $ticket_title = sprintf(
                 "#%d %s [%s]\t%s\n",
-                $ticket, $ticket_obj->Status, $ticket_obj->OwnerObj->Name,
+                $ticket, $ticket_obj->Status, $ticket_obj->owner_obj->name,
                 $ticket_obj->Subject
             );
             $contents_list .= $ticket_title;
@@ -323,7 +323,7 @@
                         Value  => $txn_obj->Created
                     );
                     $date = strftime( '%a, %d %b %Y %H:%M:%S %z',
-                        @{ [ localtime( $date_obj->Unix ) ] } );
+                        @{ [ localtime( $date_obj->unix ) ] } );
                 }
                 $contents_body .= "Date: $date\n\n";
                 $contents_body .= $msg->Content . "\n";

Modified: rt/branches/3.999-DANGEROUS/sbin/rt-email-group-admin.in
==============================================================================
--- rt/branches/3.999-DANGEROUS/sbin/rt-email-group-admin.in	(original)
+++ rt/branches/3.999-DANGEROUS/sbin/rt-email-group-admin.in	Tue Jul 15 09:27:31 2008
@@ -224,7 +224,7 @@
 sub _list {
     my $action = shift;
 
-    print "Name: ". $action->Name() ."\n";
+    print "Name: ". $action->name() ."\n";
     print "Module: ". $action->ExecModule() ."\n";
 
     my @princ = argument_to_list( $action );
@@ -236,7 +236,7 @@
         next unless $obj->id;
 
         print "\t". $obj->PrincipalType;
-        print "\t=> ". $obj->Object->Name;
+        print "\t=> ". $obj->Object->name;
         print "(Disabled!!!)" if $obj->Disabled;
         print "\n";
     }

Modified: rt/branches/3.999-DANGEROUS/share/html/Admin/Groups/Members.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Admin/Groups/Members.html	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Admin/Groups/Members.html	Tue Jul 15 09:27:31 2008
@@ -80,7 +80,7 @@
 <ul>
 % while ( my $user = $Users->next ) {
 % $UsersSeen{ $user->id } = 1 if $SkipSeenUsers;
-<li><input type="checkbox" class="checkbox" name="delete_member-<% $user->principal_obj->id %>" value="1" />
+<li><input type="checkbox" class="checkbox" name="delete_member-<% $user->principal_object->id %>" value="1" />
 <& '/Elements/ShowUser', User => $user &></li>
 % }
 </ul>

Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/DashboardsForObject
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/DashboardsForObject	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/DashboardsForObject	Tue Jul 15 09:27:31 2008
@@ -56,7 +56,7 @@
 my $privacy = RT::Dashboard->_build_privacy($Object);
 
 while (my $attr = $Object->Attributes->Next) {
-    if ($attr->Name =~ /^Dashboard\b/) {
+    if ($attr->name =~ /^Dashboard\b/) {
         my $dashboard = RT::Dashboard->new(Jifty->web->current_user);
         my ($ok, $msg) = $dashboard->Load($privacy, $attr->id);
 
@@ -72,7 +72,7 @@
             push @{ $dashboards{personal} }, $dashboard;
         }
         elsif ($Object->isa('RT::Model::Group')) {
-            push @{ $dashboards{group}{$Object->Name} }, $dashboard;
+            push @{ $dashboards{group}{$Object->name} }, $dashboard;
         }
     }
 }

Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/SelectPrivacy
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/SelectPrivacy	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/SelectPrivacy	Tue Jul 15 09:27:31 2008
@@ -58,7 +58,7 @@
 % if (ref($object) eq 'RT::Model::User' && $object->id == Jifty->web->current_user->Id) {
 <option <%$selected|n%> value="<%$privacy%>"><&|/l&>My dashboards</&></option>
 % } else {
-<option <%$selected|n%> value="<%$privacy%>"><&|/l, $object->Name&>[_1]'s dashboards</&></option>
+<option <%$selected|n%> value="<%$privacy%>"><&|/l, $object->name&>[_1]'s dashboards</&></option>
 % }
 % }
 </select>

Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/ShowDashboards
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/ShowDashboards	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/ShowDashboards	Tue Jul 15 09:27:31 2008
@@ -85,7 +85,7 @@
 %       my $url = sprintf '%s/Dashboards/%d/%s',
 %                 RT->config->get('WebPath'),
 %                 $dashboard->Id,
-%                 $dashboard->Name;
+%                 $dashboard->name;
 
         <tr class="collection-as-table <% ++$i % 2 ? 'oddline' : 'evenline' %>">
 % if ($Verbose) {
@@ -97,7 +97,7 @@
 % }
             <td class="collection-as-table">
                 <a href="<% $url %>">
-                    <% $dashboard->Name %>
+                    <% $dashboard->name %>
                 </a>
             </td>
             <td class="collection-as-table">

Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/Tabs
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/Tabs	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/Tabs	Tue Jul 15 09:27:31 2008
@@ -56,14 +56,14 @@
 my $real_subtab = $current_subtab;
 if ( $DashboardObj and $DashboardObj->Id ) {
 
-    my $name = $DashboardObj->Name;
+    my $name = $DashboardObj->name;
 
     my $modify  = "Dashboards/Modify.html?id=" . $DashboardObj->Id;
     my $queries = "Dashboards/Queries.html?id=" . $DashboardObj->Id;
     my $render  = "Dashboards/" . $DashboardObj->Id . "/$name";
 
     $tabs->{"this"} = {
-        title   => $DashboardObj->Name,
+        title   => $DashboardObj->name,
         path    => $modify,
         current_subtab  => $current_subtab,
         subtabs => {

Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Modify.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Modify.html	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Modify.html	Tue Jul 15 09:27:31 2008
@@ -64,7 +64,7 @@
 <tr><td align="right">
 <&|/l&>Name</&>:
 </td>
-<td><input name="Name" value="<%$Dashboard->Name%>" /></td>
+<td><input name="Name" value="<%$Dashboard->name%>" /></td>
 </tr>
 <tr><td align="right">
 <&|/l&>Privacy</&>:
@@ -119,7 +119,7 @@
     }
 
     if ($id) {
-        $title = loc("Modify the dashboard [_1]", $Dashboard->Name);
+        $title = loc("Modify the dashboard [_1]", $Dashboard->name);
         $current_subtab = 'Dashboards/Modify.html?id=' . $id;
     }	
     # If the create failed

Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Queries.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Queries.html	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Queries.html	Tue Jul 15 09:27:31 2008
@@ -85,7 +85,7 @@
 my $Dashboard = new RT::Dashboard(Jifty->web->current_user);
 my ($ok, $msg) = $Dashboard->LoadById($id);
 $ok || Abort(loc("Couldn't load dashboard [_1]: [_2]", $id, $msg));
-my $title = loc("Modify the queries of dashboard [_1]", $Dashboard->Name);
+my $title = loc("Modify the queries of dashboard [_1]", $Dashboard->name);
 
 my %desc_of;
 my @items;

Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Render.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Render.html	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Render.html	Tue Jul 15 09:27:31 2008
@@ -94,7 +94,7 @@
 }
 
 my $rows = $Loaded ? $SubscriptionObj->SubValue('Rows') : 20;
-my $title = $DashboardObj->Name;
+my $title = $DashboardObj->name;
 
 </%INIT>
 <%ARGS>

Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Subscription.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Subscription.html	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Subscription.html	Tue Jul 15 09:27:31 2008
@@ -65,7 +65,7 @@
 <tr><td class="label">
 <&|/l&>Dashboard</&>:
 </td><td class="value">
-<% $DashboardObj->Name %>
+<% $DashboardObj->name %>
 </td></tr>
 
 <tr><td class="label">
@@ -78,10 +78,10 @@
 <ol>
 %    for my $query (@searches) {
 %       my $name;
-%       if ($query->{Attribute}->Name =~ /^Search - (.*)$/) {
+%       if ($query->{Attribute}->name =~ /^Search - (.*)$/) {
 %           $name = $1;
 %       } else {
-%           $name = $query->Name;
+%           $name = $query->name;
 %       }
         <li>
             <% loc($name, $fields{'Rows'}) %>
@@ -244,9 +244,9 @@
             Content     => \%fields,
         );
         if ($val) {
-            push @results, loc("Subscribed to dashboard [_1]", $DashboardObj->Name);
+            push @results, loc("Subscribed to dashboard [_1]", $DashboardObj->name);
             push @results, loc("Warning: you have no email address set, so you will not receive this dashboard until you have it set")
-                unless Jifty->web->current_user->EmailAddress;
+                unless Jifty->web->current_user->email;
         }
         else {
             push @results, loc('Subscription could not be created: [_1]', $msg);
@@ -255,10 +255,10 @@
 }
 
 if ($SubscriptionObj->Id) {
-    $title = loc("Modify the subscription to dashboard [_1]", $DashboardObj->Name);
+    $title = loc("Modify the subscription to dashboard [_1]", $DashboardObj->name);
 }
 else {
-    $title = loc("Subscribe to dashboard [_1]", $DashboardObj->Name);
+    $title = loc("Subscribe to dashboard [_1]", $DashboardObj->name);
 }
 
 </%INIT>

Modified: rt/branches/3.999-DANGEROUS/share/html/Elements/RT__Model__Ticket/ColumnMap
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Elements/RT__Model__Ticket/ColumnMap	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Elements/RT__Model__Ticket/ColumnMap	Tue Jul 15 09:27:31 2008
@@ -78,7 +78,7 @@
     queue => {
         attribute => 'queue',
         title     => 'Queue id',
-        value     => sub { return $_[0]->Queue }
+        value     => sub { return $_[0]->queue }
     },
     Queuename => {
         attribute => 'queue',
@@ -190,7 +190,7 @@
         value     => sub  { 
             my $date = $_[0]->due_obj;
             # Highlight the date if it was due in the past, and it's still active
-            if ( $date && $date->Unix > 0 && $date->Diff < 0 && $_[0]->queue_obj->is_active_status($_[0]->status)) {
+            if ( $date && $date->unix > 0 && $date->diff < 0 && $_[0]->queue_obj->is_active_status($_[0]->status)) {
                 return (\'<span class="overdue">' , $date->age_as_string , \'</span>');
             } else {
                 return $date->age_as_string;

Modified: rt/branches/3.999-DANGEROUS/share/html/Elements/RT__Scrip/ColumnMap
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Elements/RT__Scrip/ColumnMap	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Elements/RT__Scrip/ColumnMap	Tue Jul 15 09:27:31 2008
@@ -60,28 +60,28 @@
     Queue => {
         title     => 'Queue',
         value     => sub {
-            return $_[0]->QueueObj->Name if $_[0]->Queue;
+            return $_[0]->queue_obj->name if $_[0]->queue;
             return $_[0]->loc('Global');
         },
     },
     Condition => {
         title     => 'Condition',
-        value     => sub { return $_[0]->loc( $_[0]->ScripConditionObj->Name ) },
+        value     => sub { return $_[0]->loc( $_[0]->ScripConditionObj->name ) },
     },
     Action => {
         title     => 'Action',
-        value     => sub { return $_[0]->loc( $_[0]->ScripActionObj->Name ) },
+        value     => sub { return $_[0]->loc( $_[0]->ScripActionObj->name ) },
     },
     Template => {
         title     => 'Template',
-        value     => sub { return $_[0]->loc( $_[0]->TemplateObj->Name ) },
+        value     => sub { return $_[0]->loc( $_[0]->template_obj->name ) },
     },
     Autodescription => {
         title     => 'Condition, Action and Template',
         value     => sub { return $_[0]->loc( "[_1] [_2] with template [_3]",
-            $_[0]->loc($_[0]->ConditionObj->Name),
-            $_[0]->loc($_[0]->ActionObj->Name),
-            $_[0]->loc($_[0]->TemplateObj->Name),
+            $_[0]->loc($_[0]->condition_obj->name),
+            $_[0]->loc($_[0]->action_obj->name),
+            $_[0]->loc($_[0]->template_obj->name),
         ) },
     },
 };

Modified: rt/branches/3.999-DANGEROUS/share/html/Elements/ShowLinks
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Elements/ShowLinks	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Elements/ShowLinks	Tue Jul 15 09:27:31 2008
@@ -134,7 +134,7 @@
 my $path
     = RT->config->get('WebPath')
     . '/Ticket/Create.html?Queue='
-    . $Ticket->Queue
+    . $Ticket->queue
     . '&CloneTicket='
     . $Ticket->id;
 

Modified: rt/branches/3.999-DANGEROUS/share/html/Elements/ShowUserConcise
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Elements/ShowUserConcise	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Elements/ShowUserConcise	Tue Jul 15 09:27:31 2008
@@ -50,16 +50,16 @@
 if ($User) {
     my $printable;
     if ( $User->Privileged ) {
-             $printable = $User->RealName
-          || $User->NickName
-          || $User->Name
-          || $User->EmailAddress;
+             $printable = $User->real_name
+          || $User->nickname
+          || $User->name
+          || $User->email;
     }
     else {
-             $printable = $User->EmailAddress
-          || $User->Name
-          || $User->RealName
-          || $User->NickName;
+             $printable = $User->email
+          || $User->name
+          || $User->real_name
+          || $User->nickname;
     }
     $m->out( $printable);
 }

Modified: rt/branches/3.999-DANGEROUS/share/html/NoAuth/iCal/dhandler
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/NoAuth/iCal/dhandler	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/NoAuth/iCal/dhandler	Tue Jul 15 09:27:31 2008
@@ -86,18 +86,18 @@
 $feed->add_properties('prodid'   => ["-//" . RT->config->get('rtname') ."//"]);
 
 while (my $t = $tickets->Next) {
-    next unless $t->DueObj->Unix > 0;
+    next unless $t->due_obj->unix > 0;
 
-    my $starttime = $t->StartsObj->Unix > 0 ? $t->StartsObj : $t->CreatedObj;
+    my $starttime = $t->starts_obj->unix > 0 ? $t->starts_obj : $t->created_obj;
 
-    my $now = RT::Date->new; $now->SetToNow;
+    my $now = RT::Date->new; $now->set_to_now;
     my $start = Data::ICal::Entry::Event->new;
     my $end   = Data::ICal::Entry::Event->new;
     $_->add_properties(
         url       => RT->config->get('WebURL') . "?q=".$t->id,
-        organizer => $t->OwnerObj->Name,
+        organizer => $t->owner_obj->name,
         dtstamp   => $now->iCal,
-        created   => $t->CreatedObj->iCal,
+        created   => $t->created_obj->iCal,
        'last-modified' => $t->LastUpdatedObj->iCal,
     ) for $start, $end;
 
@@ -108,8 +108,8 @@
     );
     $end->add_properties(
         summary   => "Due: ".$t->Subject,
-        dtstart   => $t->DueObj->iCalDate,
-        dtend     => $t->DueObj->iCalDate,
+        dtstart   => $t->due_obj->iCalDate,
+        dtend     => $t->due_obj->iCalDate,
     );
 
     $feed->add_entry($start);

Modified: rt/branches/3.999-DANGEROUS/share/html/REST/1.0/Forms/ticket/default
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/REST/1.0/Forms/ticket/default	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/REST/1.0/Forms/ticket/default	Tue Jul 15 09:27:31 2008
@@ -134,7 +134,7 @@
             if ($dates{lc $k}) {
                 my $time = new RT::Date Jifty->web->current_user;
                 $time->set(format => 'unknown', value => $data{$k});
-                $data{$k} = $time->ISO;
+                $data{$k} = $time->iso;
             }
 
             if (exists $create{lc $k}) {
@@ -281,7 +281,7 @@
             next if ($val =~ /^not set$/i || $val eq $time->as_string);
 
             $time->set(format => 'unknown', value => $val);
-            ($n, $s) = $ticket->$set($time->ISO);
+            ($n, $s) = $ticket->$set($time->iso);
         }
         elsif (exists $people{$key}) {
             $key = $people{$key};

Modified: rt/branches/3.999-DANGEROUS/share/html/Search/Results.tsv
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Search/Results.tsv	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Search/Results.tsv	Tue Jul 15 09:27:31 2008
@@ -81,7 +81,7 @@
             $row->{$attr} = "";
         } else {
             my $method = '$Ticket->'.$attr.'()';
-            $method =~ s/->ISO\(\)$/->ISO( Timezone => 'user' )/;
+            $method =~ s/->iso\(\)$/->iso( Timezone => 'user' )/;
             $row->{$attr} = eval $method;
             if ($@) {die "Failed to find $attr - ". $@}; 
         }

Modified: rt/branches/3.999-DANGEROUS/share/html/Ticket/Elements/ShowDates
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Ticket/Elements/ShowDates	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Ticket/Elements/ShowDates	Tue Jul 15 09:27:31 2008
@@ -65,10 +65,10 @@
   <tr>
     <td class="label date due"><&|/l&>Due</&>:</td>
 % my $due = $Ticket->due_obj;
-% if ( $due && $due->Unix > 0 && $due->Diff < 0 ) {
-    <td class="value date due"><span class="overdue"><% $due->AsString  %></span></td>
+% if ( $due && $due->unix > 0 && $due->diff < 0 ) {
+    <td class="value date due"><span class="overdue"><% $due->as_string  %></span></td>
 % } else {
-    <td class="value date due"><% $due->AsString  %></td>
+    <td class="value date due"><% $due->as_string  %></td>
 % }
   </tr>
   <tr>

Modified: rt/branches/3.999-DANGEROUS/share/html/Tools/Reports/CreatedByDates.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Tools/Reports/CreatedByDates.html	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Tools/Reports/CreatedByDates.html	Tue Jul 15 09:27:31 2008
@@ -86,9 +86,9 @@
 
 <br /><&|/l&>Queue</&>: <& /Elements/SelectQueue, name => 'queue', named_values => 1, default => $q->id &>
 <br /><&|/l&>Tickets Created after</&>: 
-<& /Elements/SelectDate, name => 'CreatedAfter', default => ($CreatedAfter) ? $after->ISO : ''&>
+<& /Elements/SelectDate, name => 'CreatedAfter', default => ($CreatedAfter) ? $after->iso : ''&>
 <br /><&|/l&>Tickets Created before</&>: 
-<& /Elements/SelectDate, name => 'CreatedBefore', default => ($CreatedBefore) ? $before->ISO : ''&>
+<& /Elements/SelectDate, name => 'CreatedBefore', default => ($CreatedBefore) ? $before->iso : ''&>
 
 <& /Elements/Submit&>
 </form>

Modified: rt/branches/3.999-DANGEROUS/share/html/Tools/Reports/ResolvedByDates.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Tools/Reports/ResolvedByDates.html	(original)
+++ rt/branches/3.999-DANGEROUS/share/html/Tools/Reports/ResolvedByDates.html	Tue Jul 15 09:27:31 2008
@@ -87,9 +87,9 @@
 
 <br /><&|/l&>Queue</&>: <& /Elements/SelectQueue, name => 'queue', named_values => 1, default => $q->id &>
 <br /><&|/l&>Tickets resolved after</&>: 
-<& /Elements/SelectDate, name => 'ResolvedAfter', default => ($ResolvedAfter) ? $after->ISO : ''&>
+<& /Elements/SelectDate, name => 'ResolvedAfter', default => ($ResolvedAfter) ? $after->iso : ''&>
 <br /><&|/l&>Tickets resolved before</&>: 
-<& /Elements/SelectDate, name => 'ResolvedBefore', default => ($ResolvedBefore) ? $before->ISO : ''&>
+<& /Elements/SelectDate, name => 'ResolvedBefore', default => ($ResolvedBefore) ? $before->iso : ''&>
 
 <& /Elements/Submit&>
 </form>

Modified: rt/branches/3.999-DANGEROUS/t/api/date.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/api/date.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/api/date.t	Tue Jul 15 09:27:31 2008
@@ -391,9 +391,9 @@
 # XXX: TODO, doesn't work with Test::Warn
 #    TODO: {
 #        local $TODO = "BUG or subject to change Date handling to support unix time <= 0";
-#        $date->Unix(0);
+#        $date->unix(0);
 #        $date->AddSeconds(-2);
-#        ok($date->Unix > 0);
+#        ok($date->unix > 0);
 #    }
 
     $date->unix(0);


More information about the Rt-commit mailing list