[Rt-commit] r14121 - in rt/branches/3.999-DANGEROUS: . lib/RT lib/RT/Graph lib/RT/ScripAction share/html/Dashboards share/html/Dashboards/Elements share/html/Elements share/html/NoAuth/iCal share/html/Search/Elements
sunnavy at bestpractical.com
sunnavy at bestpractical.com
Tue Jul 15 10:31:03 EDT 2008
Author: sunnavy
Date: Tue Jul 15 10:30:35 2008
New Revision: 14121
Modified:
rt/branches/3.999-DANGEROUS/ (props changed)
rt/branches/3.999-DANGEROUS/lib/RT/Graph/Tickets.pm
rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm
rt/branches/3.999-DANGEROUS/lib/RT/Search.pm
rt/branches/3.999-DANGEROUS/sbin/rt-email-dashboards.in
rt/branches/3.999-DANGEROUS/sbin/rt-email-digest.in
rt/branches/3.999-DANGEROUS/sbin/rt-email-group-admin.in
rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/DashboardsForObject
rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/Tabs
rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/dashboardsfor_object
rt/branches/3.999-DANGEROUS/share/html/Dashboards/Modify.html
rt/branches/3.999-DANGEROUS/share/html/Dashboards/Queries.html
rt/branches/3.999-DANGEROUS/share/html/Dashboards/index.html
rt/branches/3.999-DANGEROUS/share/html/Elements/Dashboards
rt/branches/3.999-DANGEROUS/share/html/Elements/ShowSearch
rt/branches/3.999-DANGEROUS/share/html/NoAuth/iCal/dhandler
rt/branches/3.999-DANGEROUS/share/html/Search/Elements/EditSearches
Log:
r14503 at sunnavys-mb: sunnavy | 2008-07-15 22:12:46 +0800
name fixes
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Graph/Tickets.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Graph/Tickets.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Graph/Tickets.pm Tue Jul 15 10:30:35 2008
@@ -165,7 +165,7 @@
$cfs->LimitToLookupType('RT::Model::Queue-RT::Model::Ticket');
$cfs->OrderBy( FIELD => 'Name' );
my ( $first, %seen ) = (1);
- while ( my $cf = $cfs->Next ) {
+ while ( my $cf = $cfs->next ) {
next if $seen{ lc $cf->name }++;
next if $cf->Type eq 'Image';
if ($first) {
@@ -325,7 +325,7 @@
foreach my $type ( $args{'LeadingLink'}, @{ $args{'ShowLinks'} } ) {
my $links = $args{'Ticket'}->$type();
$links->GotoFirstItem;
- while ( my $link = $links->Next ) {
+ while ( my $link = $links->next ) {
next if $args{'SeenEdge'}{ $link->id }++;
my $target = $link->target_obj;
Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm Tue Jul 15 10:30:35 2008
@@ -146,7 +146,7 @@
my $obj = shift;
my $members = $obj->UserMembersObj;
- while ( my $m = $members->Next ) {
+ while ( my $m = $members->next ) {
$self->__HandleUserArgument($m);
}
}
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Search.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Search.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Search.pm Tue Jul 15 10:30:35 2008
@@ -57,7 +57,7 @@
my $foo = RT::Search->new(argument => $arg,
tickets_obj => $tickets);
$foo->prepare();
- while ( my $ticket = $foo->Next ) {
+ while ( my $ticket = $foo->next ) {
# Do something with each ticket we've found
}
Modified: rt/branches/3.999-DANGEROUS/sbin/rt-email-dashboards.in
==============================================================================
--- rt/branches/3.999-DANGEROUS/sbin/rt-email-dashboards.in (original)
+++ rt/branches/3.999-DANGEROUS/sbin/rt-email-dashboards.in Tue Jul 15 10:30:35 2008
@@ -129,7 +129,7 @@
my $Users = RT::Model::UserCollection->new(RT->system_user);
$Users->LimitToPrivileged;
-while (defined(my $user = $Users->Next)) {
+while (defined(my $user = $Users->next)) {
if ($user->principal_object->Disabled) {
debug "Skipping over "
. $user->name
@@ -154,7 +154,7 @@
# look through this user's subscriptions, are any supposed to be generated
# right now?
- for my $subscription ($user->Attributes->Named('Subscription')) {
+ for my $subscription ($user->attributes->Named('Subscription')) {
if (!$opts{all}) {
debug "Checking against subscription with frequency [_1], hour [_2], dow [_3], dom [_4]", $subscription->SubValue('Frequency'), $subscription->SubValue('Hour'), $subscription->SubValue('Dow'), $subscription->SubValue('Dom');
Modified: rt/branches/3.999-DANGEROUS/sbin/rt-email-digest.in
==============================================================================
--- rt/branches/3.999-DANGEROUS/sbin/rt-email-digest.in (original)
+++ rt/branches/3.999-DANGEROUS/sbin/rt-email-digest.in Tue Jul 15 10:30:35 2008
@@ -259,7 +259,7 @@
my $all_digest = {};
my $sent_transactions = {};
- while ( my $txn = $txns->Next ) {
+ while ( my $txn = $txns->next ) {
my $ticket = $txn->Ticket;
my $queue = $txn->ticket_obj->queue_obj->name;
# Xxx todo - may clobber if two queues have the same name
Modified: rt/branches/3.999-DANGEROUS/sbin/rt-email-group-admin.in
==============================================================================
--- rt/branches/3.999-DANGEROUS/sbin/rt-email-group-admin.in (original)
+++ rt/branches/3.999-DANGEROUS/sbin/rt-email-group-admin.in Tue Jul 15 10:30:35 2008
@@ -215,7 +215,7 @@
sub list {
my $actions = _get_our_actions();
- while( my $a = $actions->Next ) {
+ while( my $a = $actions->next ) {
_list( $a );
}
return;
@@ -382,7 +382,7 @@
$scrips->Limit( FIELD => 'ScripAction', VALUE => $action->id );
if ( $scrips->Count ) {
my @sid;
- while( my $s = $scrips->Next ) {
+ while( my $s = $scrips->next ) {
push @sid, $s->id;
}
print STDERR "ScripAction '". $opts->{'name'} ."'"
Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/DashboardsForObject
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/DashboardsForObject (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/DashboardsForObject Tue Jul 15 10:30:35 2008
@@ -55,7 +55,7 @@
my %dashboards;
my $privacy = RT::Dashboard->_build_privacy($Object);
-while (my $attr = $Object->Attributes->Next) {
+while (my $attr = $Object->attributes->next) {
if ($attr->name =~ /^Dashboard\b/) {
my $dashboard = RT::Dashboard->new(Jifty->web->current_user);
my ($ok, $msg) = $dashboard->Load($privacy, $attr->id);
Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/Tabs
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/Tabs (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/Tabs Tue Jul 15 10:30:35 2008
@@ -100,7 +100,7 @@
path => "Dashboards/index.html" };
my $dashboard = RT::Dashboard->new(Jifty->web->current_user);
-my @objects = $dashboard->_PrivacyObjects(Create => 1);
+my @objects = $dashboard->_privacy_objects(Create => 1);
if (@objects) {
$tabs->{"B"} = { title => loc('New dashboard'),
Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/dashboardsfor_object
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/dashboardsfor_object (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/dashboardsfor_object Tue Jul 15 10:30:35 2008
@@ -55,7 +55,7 @@
my @dashboards;
my $privacy = RT::Dashboard->_build_privacy($object);
-while (my $attr = $object->Attributes->next) {
+while (my $attr = $object->attributes->next) {
if ($attr->name =~ /^Dashboard\b/) {
my $dashboard = RT::Dashboard->new();
my ($ok) = $dashboard->load($privacy, $attr->id);
Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Modify.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Modify.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Modify.html Tue Jul 15 10:30:35 2008
@@ -89,7 +89,7 @@
use RT::Dashboard;
my $Dashboard = RT::Dashboard->new(Jifty->web->current_user);
-my @privacies = $Dashboard->_PrivacyObjects(($Create ? 'Create' : 'Modify') => 1);
+my @privacies = $Dashboard->_privacy_objects(($Create ? 'Create' : 'Modify') => 1);
Abort(loc("Permission denied")) if @privacies == 0;
Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Queries.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Queries.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Queries.html Tue Jul 15 10:30:35 2008
@@ -102,7 +102,7 @@
my $sys = RT::System->new(Jifty->web->current_user);
my @objs = ($sys);
-push @objs, RT::SavedSearches->new( Jifty->web->current_user )->_PrivacyObjects
+push @objs, RT::SavedSearches->new( Jifty->web->current_user )->_privacy_objects
if Jifty->web->current_user->HasRight( Right => 'LoadSavedSearch',
Object => $RT::System );
Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/index.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/index.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/index.html Tue Jul 15 10:30:35 2008
@@ -73,7 +73,7 @@
my $title = loc("Dashboards");
use RT::Dashboard;
-my @objs = RT::Dashboard->new(Jifty->web->current_user)->_PrivacyObjects;
+my @objs = RT::Dashboard->new(Jifty->web->current_user)->_privacy_objects;
my $dashboards = $m->comp("/Dashboards/Elements/DashboardsForObjects", Objects => \@objs);
my @actions;
Modified: rt/branches/3.999-DANGEROUS/share/html/Elements/Dashboards
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Elements/Dashboards (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Elements/Dashboards Tue Jul 15 10:30:35 2008
@@ -58,7 +58,7 @@
<%INIT>
use RT::Dashboard;
-my @objs = RT::Dashboard->new(Jifty->web->current_user)->_PrivacyObjects(ShowSystem => 1);
+my @objs = RT::Dashboard->new(Jifty->web->current_user)->_privacy_objects(ShowSystem => 1);
my $dashboard_map = $m->comp("/Dashboards/Elements/DashboardsForObjects", Objects => \@objs);
my @dashboards = (
Modified: rt/branches/3.999-DANGEROUS/share/html/Elements/ShowSearch
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Elements/ShowSearch (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Elements/ShowSearch Tue Jul 15 10:30:35 2008
@@ -107,9 +107,9 @@
# ProcessedSearchArg is a search with overridings, but for link we use
# orginal search's poperties
+$SearchArg ||= {};
my $ProcessedSearchArg = $SearchArg;
$ProcessedSearchArg = { %$SearchArg, %Override } if keys %Override;
-
$m->callback(
%ARGS,
Callbackname => 'ModifySearch',
Modified: rt/branches/3.999-DANGEROUS/share/html/NoAuth/iCal/dhandler
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/NoAuth/iCal/dhandler (original)
+++ rt/branches/3.999-DANGEROUS/share/html/NoAuth/iCal/dhandler Tue Jul 15 10:30:35 2008
@@ -85,7 +85,7 @@
$feed->add_properties('method' => ['publish']);
$feed->add_properties('prodid' => ["-//" . RT->config->get('rtname') ."//"]);
-while (my $t = $tickets->Next) {
+while (my $t = $tickets->next) {
next unless $t->due_obj->unix > 0;
my $starttime = $t->starts_obj->unix > 0 ? $t->starts_obj : $t->created_obj;
Modified: rt/branches/3.999-DANGEROUS/share/html/Search/Elements/EditSearches
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Search/Elements/EditSearches (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Search/Elements/EditSearches Tue Jul 15 10:30:35 2008
@@ -183,7 +183,7 @@
}
elsif ( $ARGS{'SavedSearchCopy'} ) {
my ($container, $id ) = _parse_saved_search( $ARGS{'SavedSearchid'} );
- $SavedSearch->{'object'} = $container->Attributes->Withid( $id );
+ $SavedSearch->{'object'} = $container->attributes->Withid( $id );
if ( $ARGS{'saved_search_description'} && $ARGS{'saved_search_description'} ne $SavedSearch->{'object'}->description ) {
$SavedSearch->{'description'} = $ARGS{'saved_search_description'};
} else {
More information about the Rt-commit
mailing list