[Rt-commit] r14149 - in rt/branches/3.999-DANGEROUS: . docs/design_docs etc lib/RT lib/RT/Graph lib/RT/Interface lib/RT/Interface/Web lib/RT/Model lib/RT/Report lib/RT/ScripAction lib/RT/Shredder sbin share/html/Admin/Tools/Shredder share/html/Admin/Users share/html/Dashboards share/html/Dashboards/Elements share/html/Elements share/html/Elements/GnuPG share/html/Elements/RT__Scrip share/html/Install share/html/NoAuth/iCal share/html/Search/Elements share/html/Ticket share/html/Ticket/Elements share/html/Ticket/Graphs share/html/Ticket/Graphs/Elements share/html/User t/api temp_refactoring_tools
sunnavy at bestpractical.com
sunnavy at bestpractical.com
Wed Jul 16 04:21:29 EDT 2008
Author: sunnavy
Date: Wed Jul 16 04:21:29 2008
New Revision: 14149
Modified:
rt/branches/3.999-DANGEROUS/ (props changed)
rt/branches/3.999-DANGEROUS/docs/design_docs/TransactionTypes.txt
rt/branches/3.999-DANGEROUS/docs/design_docs/realflow.txt
rt/branches/3.999-DANGEROUS/docs/design_docs/string-extraction-guide.txt
rt/branches/3.999-DANGEROUS/etc/initialdata
rt/branches/3.999-DANGEROUS/lib/RT/Condition.pm
rt/branches/3.999-DANGEROUS/lib/RT/Config.pm
rt/branches/3.999-DANGEROUS/lib/RT/Date.pm
rt/branches/3.999-DANGEROUS/lib/RT/Graph/Tickets.pm
rt/branches/3.999-DANGEROUS/lib/RT/Installer.pm
rt/branches/3.999-DANGEROUS/lib/RT/Interface/Web.pm
rt/branches/3.999-DANGEROUS/lib/RT/Interface/Web/Standalone.pm
rt/branches/3.999-DANGEROUS/lib/RT/Model/Template.pm
rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm
rt/branches/3.999-DANGEROUS/lib/RT/Model/Transaction.pm
rt/branches/3.999-DANGEROUS/lib/RT/Report/Tickets.pm
rt/branches/3.999-DANGEROUS/lib/RT/ScripAction.pm
rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/ExtractSubjectTag.pm
rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/LinearEscalate.pm
rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm
rt/branches/3.999-DANGEROUS/lib/RT/Shredder.pm
rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Exceptions.pm
rt/branches/3.999-DANGEROUS/lib/RT/System.pm
rt/branches/3.999-DANGEROUS/sbin/rt-dump-database.in
rt/branches/3.999-DANGEROUS/sbin/rt-email-dashboards.in
rt/branches/3.999-DANGEROUS/sbin/rt-email-digest.in
rt/branches/3.999-DANGEROUS/sbin/rt-email-group-admin.in
rt/branches/3.999-DANGEROUS/sbin/rt-server.in
rt/branches/3.999-DANGEROUS/share/html/Admin/Tools/Shredder/index.html
rt/branches/3.999-DANGEROUS/share/html/Admin/Users/Modify.html
rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/DashboardsForObject
rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/SelectPrivacy
rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/ShowDashboards
rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/ShowSubscription
rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/Tabs
rt/branches/3.999-DANGEROUS/share/html/Dashboards/Modify.html
rt/branches/3.999-DANGEROUS/share/html/Dashboards/Queries.html
rt/branches/3.999-DANGEROUS/share/html/Dashboards/Render.html
rt/branches/3.999-DANGEROUS/share/html/Dashboards/Subscription.html
rt/branches/3.999-DANGEROUS/share/html/Dashboards/index.html
rt/branches/3.999-DANGEROUS/share/html/Elements/Dashboards
rt/branches/3.999-DANGEROUS/share/html/Elements/EditCustomFieldSelect
rt/branches/3.999-DANGEROUS/share/html/Elements/GnuPG/KeyIssues
rt/branches/3.999-DANGEROUS/share/html/Elements/RT__Scrip/ColumnMap
rt/branches/3.999-DANGEROUS/share/html/Elements/ShowCustomFieldText
rt/branches/3.999-DANGEROUS/share/html/Elements/ShowLink
rt/branches/3.999-DANGEROUS/share/html/Elements/ShowSearch
rt/branches/3.999-DANGEROUS/share/html/Elements/ShowUserConcise
rt/branches/3.999-DANGEROUS/share/html/Install/Basics.html
rt/branches/3.999-DANGEROUS/share/html/Install/DatabaseDetails.html
rt/branches/3.999-DANGEROUS/share/html/Install/DatabaseType.html
rt/branches/3.999-DANGEROUS/share/html/Install/Finish.html
rt/branches/3.999-DANGEROUS/share/html/Install/Global.html
rt/branches/3.999-DANGEROUS/share/html/Install/Initialize.html
rt/branches/3.999-DANGEROUS/share/html/Install/Sendmail.html
rt/branches/3.999-DANGEROUS/share/html/Install/autohandler
rt/branches/3.999-DANGEROUS/share/html/NoAuth/iCal/dhandler
rt/branches/3.999-DANGEROUS/share/html/Search/Elements/EditSearches
rt/branches/3.999-DANGEROUS/share/html/Search/Elements/ResultViews
rt/branches/3.999-DANGEROUS/share/html/Ticket/Create.html
rt/branches/3.999-DANGEROUS/share/html/Ticket/Display.html
rt/branches/3.999-DANGEROUS/share/html/Ticket/Elements/PreviewScrips
rt/branches/3.999-DANGEROUS/share/html/Ticket/Elements/Tabs
rt/branches/3.999-DANGEROUS/share/html/Ticket/Elements/UpdateCc
rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/Elements/EditGraphProperties
rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/Elements/ShowGraph
rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/dhandler
rt/branches/3.999-DANGEROUS/share/html/Ticket/Update.html
rt/branches/3.999-DANGEROUS/share/html/User/Prefs.html
rt/branches/3.999-DANGEROUS/t/api/date.t
rt/branches/3.999-DANGEROUS/t/ticket/search.t
rt/branches/3.999-DANGEROUS/temp_refactoring_tools/lower_method_calls.pl
Log:
r14509 at sunnavys-mb: sunnavy | 2008-07-16 16:15:45 +0800
keep renaming
Modified: rt/branches/3.999-DANGEROUS/docs/design_docs/TransactionTypes.txt
==============================================================================
--- rt/branches/3.999-DANGEROUS/docs/design_docs/TransactionTypes.txt (original)
+++ rt/branches/3.999-DANGEROUS/docs/design_docs/TransactionTypes.txt Wed Jul 16 04:21:29 2008
@@ -34,7 +34,7 @@
- used by all UIs to create menues of possible (user) actions (one TransactionType is a user action)
The UIs should call sth like
-$Ticket->AddTransaction($Transactionname), which should be equivalent
+$Ticket->add_transaction($Transactionname), which should be equivalent
with i.e. $Ticket->correspond when $Transactionname is 'Correspond'
(AUTOLOAD should call the do-sub if exists
RT->config->get('TransactionTypes')->{$Transactionname})
Modified: rt/branches/3.999-DANGEROUS/docs/design_docs/realflow.txt
==============================================================================
--- rt/branches/3.999-DANGEROUS/docs/design_docs/realflow.txt (original)
+++ rt/branches/3.999-DANGEROUS/docs/design_docs/realflow.txt Wed Jul 16 04:21:29 2008
@@ -113,7 +113,7 @@
-> Rule: xxx
isa_ok( $Approval->type, 'RT::Model::Ticket' );
-is( $Approval->Workflow->name, 'W' );
+is( $Approval->workflow->name, 'W' );
is( $Approval->stage->name, 'Approval' );
[Queue: A]
@@ -130,8 +130,8 @@
[stage: TOP]
-> Rule: OnCreate Runstage Approval
-ok( TicketA->Rules->has_entry($ApprovalRule) )
-ok( TicketB->Rules->has_entry($ApprovalRule) )
+ok( TicketA->rules->has_entry($ApprovalRule) )
+ok( TicketB->rules->has_entry($ApprovalRule) )
[Rule: Approval]
-> Rule: OnResolve Runstage SUCCESS
@@ -162,14 +162,14 @@
`==> [stage2] ==>'
OnTransaction:
- $self->ticket->Queues->scrips->apply
+ $self->ticket->queues->scrips->apply
OnTransaction:
- $self->ticket->Queues->scrips->apply
+ $self->ticket->queues->scrips->apply
->scrips->apply
OnTransaction:
- $self->ticket->Queues->scrips->apply
+ $self->ticket->queues->scrips->apply
->stages->scrips->apply
[QueueX]
Modified: rt/branches/3.999-DANGEROUS/docs/design_docs/string-extraction-guide.txt
==============================================================================
--- rt/branches/3.999-DANGEROUS/docs/design_docs/string-extraction-guide.txt (original)
+++ rt/branches/3.999-DANGEROUS/docs/design_docs/string-extraction-guide.txt Wed Jul 16 04:21:29 2008
@@ -84,9 +84,9 @@
When returning or localizing a single string, the "extra" set of parenthesis () should be omitted.
-The code return ("subject changed to ". $self->Data );
+The code return ("subject changed to ". $self->data );
-should become return _( "subject changed to %1", $self->Data );
+should become return _( "subject changed to %1", $self->data );
It is important not to localize the names of rights or statuses within RT's core, as there is logic that depends on them as string identifiers. The proper place to localize these values is when they're presented for display in the web or commandline interfaces.
Modified: rt/branches/3.999-DANGEROUS/etc/initialdata
==============================================================================
--- rt/branches/3.999-DANGEROUS/etc/initialdata (original)
+++ rt/branches/3.999-DANGEROUS/etc/initialdata Wed Jul 16 04:21:29 2008
@@ -442,14 +442,14 @@
RT will remove this subscription as it is no longer useful. Here's the information RT had about your subscription:
-DashboardID: { $subscription_obj->SubValue('Dashboardid') }
-Frequency: { $subscription_obj->SubValue('Frequency') }
-Hour: { $subscription_obj->SubValue('Hour') }
+DashboardID: { $subscription_obj->sub_value('Dashboardid') }
+Frequency: { $subscription_obj->sub_value('Frequency') }
+Hour: { $subscription_obj->sub_value('Hour') }
{
- $subscription_obj->SubValue('Frequency') eq 'weekly'
- ? "Day of week: " . $subscription_obj->SubValue('Dow')
- : $subscription_obj->SubValue('Frequency') eq 'monthly'
- ? "Day of month: " . $subscription_obj->SubValue('Dom')
+ $subscription_obj->sub_value('Frequency') eq 'weekly'
+ ? "Day of week: " . $subscription_obj->sub_value('Dow')
+ : $subscription_obj->sub_value('Frequency') eq 'monthly'
+ ? "Day of month: " . $subscription_obj->sub_value('Dom')
: ''
}
}
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Condition.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Condition.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Condition.pm Wed Jul 16 04:21:29 2008
@@ -60,7 +60,7 @@
Argument => $arg,
Type => $type);
- if ($foo->IsApplicable) {
+ if ($foo->is_applicable) {
# do something
}
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Config.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Config.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Config.pm Wed Jul 16 04:21:29 2008
@@ -212,7 +212,7 @@
my $ret = { Values => [], values_label => {} };
my $q = new RT::Model::Queues(
$HTML::Mason::Commands::session{'current_user'} );
- $q->Unlimit;
+ $q->unlimit;
while ( my $queue = $q->next ) {
next unless $queue->current_user_has_right("CreateTicket");
push @{ $ret->{Values} }, $queue->id;
@@ -284,7 +284,7 @@
if ( $gpg->{'enable'} ) {
require RT::Crypt::GnuPG;
- unless ( RT::Crypt::GnuPG->Probe() ) {
+ unless ( RT::Crypt::GnuPG->probe() ) {
Jifty->log->debug(
"RT's GnuPG libraries couldn't successfully execute gpg."
. " PGP support has been disabled" );
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Date.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Date.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Date.pm Wed Jul 16 04:21:29 2008
@@ -729,7 +729,7 @@
sub iCal {
my $self = shift;
my ( $sec, $min, $hour, $mday, $mon, $year, $wday, $ydaym, $isdst, $offset )
- = $self->Localtime("UTC");
+ = $self->localtime("UTC");
return sprintf( '%04d%02d%02dT%02d%02d%02dZ',
$year, $mon, $mday, $hour, $min, $sec );
@@ -744,7 +744,7 @@
sub iCalDate {
my $self = shift;
my ( $sec, $min, $hour, $mday, $mon, $year, $wday, $ydaym, $isdst, $offset )
- = $self->Localtime("UTC");
+ = $self->localtime("UTC");
return sprintf( '%04d%02d%02dZ', $year, $mon, $mday );
}
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Graph/Tickets.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Graph/Tickets.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Graph/Tickets.pm Wed Jul 16 04:21:29 2008
@@ -113,8 +113,8 @@
our %property_cb = (
Queue => sub { return $_[0]->queue_obj->name || $_[0]->queue },
CF => sub {
- my $values = $_[0]->CustomFieldValues( $_[1] );
- return join ', ', map $_->Content, @{ $values->items_array_ref };
+ my $values = $_[0]->custom_field_values( $_[1] );
+ return join ', ', map $_->content, @{ $values->items_array_ref };
},
);
foreach my $field (qw(Subject Status TimeLeft TimeWorked TimeEstimated)) {
@@ -162,12 +162,12 @@
[qw(MemberOf Members DependsOn DependedOnBy RefersTo ReferredToBy)],
);
my $cfs = RT::Model::CustomFieldCollection->new($user);
- $cfs->LimitToLookupType('RT::Model::Queue-RT::Model::Ticket');
- $cfs->OrderBy( FIELD => 'Name' );
+ $cfs->limit_to_lookup_type('RT::Model::Queue-RT::Model::Ticket');
+ $cfs->order_by( field => 'Name' );
my ( $first, %seen ) = (1);
while ( my $cf = $cfs->next ) {
next if $seen{ lc $cf->name }++;
- next if $cf->Type eq 'Image';
+ next if $cf->type eq 'Image';
if ($first) {
push @res, 'CustomFields', [];
$first = 0;
@@ -204,7 +204,7 @@
my @fields;
foreach my $property (@properties) {
- my ( $key, @subkeys ) = $self->_SplitProperty($property);
+ my ( $key, @subkeys ) = $self->_split_property($property);
unless ( $property_cb{$key} ) {
Jifty->log->error(
"Couldn't find property handler for '$key' and '@subkeys' subkeys"
@@ -231,13 +231,13 @@
my %node_style = (
style => 'filled,rounded',
- %{ $ticket_status_style{ $args{'Ticket'}->Status } || {} },
+ %{ $ticket_status_style{ $args{'Ticket'}->status } || {} },
URL => $RT::WebPath . '/Ticket/Display.html?id=' . $args{'Ticket'}->id,
tooltip =>
- gv_escape( $args{'Ticket'}->Subject || '#' . $args{'Ticket'}->id ),
+ gv_escape( $args{'Ticket'}->subject || '#' . $args{'Ticket'}->id ),
);
- my @fields = $self->_PropertiesToFields(%args);
+ my @fields = $self->_properties_to_fields(%args);
if (@fields) {
unshift @fields, $args{'Ticket'}->id;
my $label = join ' | ', map { s/(?=[{}|])/\\/g; $_ } @fields;
@@ -248,7 +248,7 @@
}
if ( $args{'FillUsing'} ) {
- my ( $key, @subkeys ) = $self->_SplitProperty( $args{'FillUsing'} );
+ my ( $key, @subkeys ) = $self->_split_property( $args{'FillUsing'} );
my $value;
if ( $property_cb{$key} ) {
$value = $property_cb{$key}->( $args{'Ticket'}, @subkeys );
@@ -312,7 +312,7 @@
$args{'Seen'} ||= {};
return $args{'Graph'} if $args{'Seen'}{ $args{'Ticket'}->id }++;
- $self->AddTicket(%args);
+ $self->add_ticket(%args);
return $args{'Graph'}
if $args{'MaxDepth'} && $args{'CurrentDepth'} >= $args{'MaxDepth'};
@@ -324,7 +324,7 @@
foreach my $type ( $args{'LeadingLink'}, @{ $args{'ShowLinks'} } ) {
my $links = $args{'Ticket'}->$type();
- $links->GotoFirstItem;
+ $links->goto_first_item;
while ( my $link = $links->next ) {
next if $args{'SeenEdge'}{ $link->id }++;
@@ -336,7 +336,7 @@
my $next = $target->id == $args{'Ticket'}->id ? $base : $target;
- $self->TicketLinks(
+ $self->ticket_links(
%args,
Ticket => $next,
$type eq $args{'LeadingLink'}
@@ -352,10 +352,10 @@
$args{'Graph'}->add_edge(
# we revers order of member links to get better layout
- $link->Type eq 'MemberOf'
+ $link->type eq 'MemberOf'
? ( $target->id => $base->id, dir => 'back' )
: ( $base->id => $target->id ),
- %{ $link_style{ $link->Type } || {} },
+ %{ $link_style{ $link->type } || {} },
$desc ? ( label => gv_escape $desc) : (),
);
}
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Installer.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Installer.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Installer.pm Wed Jul 16 04:21:29 2008
@@ -287,7 +287,7 @@
sub SaveConfig {
my $class = shift;
- my $file = $class->ConfigFile;
+ my $file = $class->config_file;
my $content;
@@ -333,7 +333,7 @@
=head1 SYNOPSYS
use RT::Installer;
- my $meta = RT::Installer->Meta;
+ my $meta = RT::Installer->meta;
=head1 DESCRIPTION
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Interface/Web.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Interface/Web.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Interface/Web.pm Wed Jul 16 04:21:29 2008
@@ -568,7 +568,7 @@
{
if ( $args{args_ref}->{'UpdateTimeWorked'} ) {
$args{args_ref}->{TimeWorked} =
- $args{ticket_obj}->TimeWorked +
+ $args{ticket_obj}->time_worked +
delete $args{args_ref}->{'UpdateTimeWorked'};
}
return;
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Interface/Web/Standalone.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Interface/Web/Standalone.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Interface/Web/Standalone.pm Wed Jul 16 04:21:29 2008
@@ -81,7 +81,7 @@
$self->SUPER::handle_request($cgi);
Jifty->log->fatal($@) if $@ && Jifty->log;
warn $@ if $@ && !Jifty->log;
- RT::Interface::Web::Handler->CleanupRequest();
+ RT::Interface::Web::Handler->cleanup_request();
}
sub net_server {
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Template.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Template.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Template.pm Wed Jul 16 04:21:29 2008
@@ -339,7 +339,7 @@
( $rv, $msg ) = $self->_parse(@_);
}
-# We only HTMLify things if the template includes at least one Transaction->Content call.
+# We only HTMLify things if the template includes at least one Transaction->content call.
return ( $rv, $msg ) unless $rv and $self->content =~ /->\s*Content\b/;
my $orig_entity = $self->mime_obj;
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm Wed Jul 16 04:21:29 2008
@@ -1350,7 +1350,7 @@
if ($status) {
# On queue change, change queue for reminders too
- my $reminder_collection = $self->Reminders->Collection;
+ my $reminder_collection = $self->reminders->collection;
while ( my $reminder = $reminder_collection->next ) {
my ( $status, $msg ) = $reminder->set_queue($NewQueue);
Jifty->log->error( 'Queue change failed for reminder #'
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Transaction.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Transaction.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Transaction.pm Wed Jul 16 04:21:29 2008
@@ -1309,7 +1309,7 @@
return () unless ($attr);
- my $deferred = $attr->Content;
+ my $deferred = $attr->content;
return () unless ( ref($deferred) eq 'HASH' && exists $deferred->{$freq} );
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Report/Tickets.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Report/Tickets.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Report/Tickets.pm Wed Jul 16 04:21:29 2008
@@ -200,7 +200,7 @@
}
elsif ( $field =~ /^(?:Watcher|(Requestor|Cc|AdminCc))$/ ) {
my $type = $1;
- my ( $g_alias, $gm_alias, $u_alias ) = $self->_Watcherjoin($type);
+ my ( $g_alias, $gm_alias, $u_alias ) = $self->_watcherjoin($type);
@args{qw(alias column)} = ( $u_alias, 'name' );
}
return %args;
Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction.pm Wed Jul 16 04:21:29 2008
@@ -74,7 +74,7 @@
my $class = ref($proto) || $proto;
my $self = {};
bless( $self, $class );
- $self->_Init(@_);
+ $self->_init(@_);
return $self;
}
@@ -97,7 +97,7 @@
);
$self->{'Argument'} = $args{'Argument'};
- $self->CurrentUser( $args{'CurrentUser'} );
+ $self->current_user( $args{'CurrentUser'} );
$self->{'ScripActionObj'} = $args{'ScripActionObj'};
$self->{'ScripObj'} = $args{'ScripObj'};
$self->{'TemplateObj'} = $args{'TemplateObj'};
Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/ExtractSubjectTag.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/ExtractSubjectTag.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/ExtractSubjectTag.pm Wed Jul 16 04:21:29 2008
@@ -62,14 +62,14 @@
sub Commit {
my $self = shift;
my $Transaction = $self->transaction_obj;
- my $FirstAttachment = $Transaction->Attachments->First;
+ my $FirstAttachment = $Transaction->attachments->first;
return 1 unless ($FirstAttachment);
my $Ticket = $self->ticket_obj;
- my $TicketSubject = $self->ticket_obj->Subject;
+ my $TicketSubject = $self->ticket_obj->subject;
my $origTicketSubject = $TicketSubject;
- my $TransactionSubject = $FirstAttachment->Subject;
+ my $TransactionSubject = $FirstAttachment->subject;
my $match = RT->config->get('ExtractSubjectTagMatch');
my $nomatch = RT->config->get('ExtractSubjectTagNoMatch');
@@ -79,7 +79,7 @@
$TicketSubject .= " $tag" unless ( $TicketSubject =~ /\Q$tag\E/ );
}
- $self->ticket_obj->SetSubject($TicketSubject)
+ $self->ticket_obj->set_subject($TicketSubject)
if ( $TicketSubject ne $origTicketSubject );
return (1);
Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/LinearEscalate.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/LinearEscalate.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/LinearEscalate.pm Wed Jul 16 04:21:29 2008
@@ -163,19 +163,19 @@
return 1;
}
- my $priority_range = $ticket->FinalPriority - $ticket->InitialPriority;
+ my $priority_range = $ticket->final_priority - $ticket->initial_priority;
unless ($priority_range) {
Jifty->log->debug(
'Final and Initial priorities are equal. Not escalating.');
return 1;
}
- if ( $ticket->Priority >= $ticket->FinalPriority && $priority_range > 0 ) {
+ if ( $ticket->priority >= $ticket->final_priority && $priority_range > 0 ) {
Jifty->log->debug(
'Current priority is greater than final. Not escalating.');
return 1;
}
- elsif ( $ticket->Priority <= $ticket->FinalPriority && $priority_range < 0 )
+ elsif ( $ticket->priority <= $ticket->final_priority && $priority_range < 0 )
{
Jifty->log->debug(
'Current priority is lower than final. Not escalating.');
@@ -202,9 +202,9 @@
my $percent_complete = ( $now - $starts ) / ( $due - $starts );
my $new_priority =
- int( $percent_complete * $priority_range ) + $ticket->InitialPriority;
- $new_priority = $ticket->FinalPriority
- if $new_priority > $ticket->FinalPriority;
+ int( $percent_complete * $priority_range ) + $ticket->initial_priority;
+ $new_priority = $ticket->final_priority
+ if $new_priority > $ticket->final_priority;
$self->{'new_priority'} = $new_priority;
return 1;
@@ -219,12 +219,12 @@
my $ticket = $self->ticket_obj;
# if the priority hasn't changed do nothing
- return 1 if $ticket->Priority == $new_value;
+ return 1 if $ticket->priority == $new_value;
# override defaults from argument
my ( $record, $update ) = ( 0, 1 );
{
- my $arg = $self->Argument || '';
+ my $arg = $self->argument || '';
if ( $arg =~ /RecordTransaction:\s*(\d+)/i ) {
$record = $1;
Jifty->log->debug("Overrode RecordTransaction: $record");
@@ -237,9 +237,9 @@
}
Jifty->log->debug( 'Linearly escalating priority of ticket #'
- . $ticket->Id
+ . $ticket->id
. ' from '
- . $ticket->Priority . ' to '
+ . $ticket->priority . ' to '
. $new_value . ' and'
. ( $record ? '' : ' do not' )
. ' record a transaction' . ' and'
@@ -249,13 +249,13 @@
my ( $val, $msg );
unless ($record) {
unless ($update) {
- ( $val, $msg ) = $ticket->__Set(
+ ( $val, $msg ) = $ticket->__set(
Field => 'Priority',
Value => $new_value,
);
}
else {
- ( $val, $msg ) = $ticket->_Set(
+ ( $val, $msg ) = $ticket->_set(
Field => 'Priority',
Value => $new_value,
RecordTransaction => 0,
@@ -263,7 +263,7 @@
}
}
else {
- ( $val, $msg ) = $ticket->SetPriority($new_value);
+ ( $val, $msg ) = $ticket->set_priority($new_value);
}
unless ($val) {
Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm Wed Jul 16 04:21:29 2008
@@ -79,15 +79,15 @@
sub SetRecipients {
my $self = shift;
- my $arg = $self->Argument;
+ my $arg = $self->argument;
my $old_arg = eval { Storable::thaw($arg) };
unless ($@) {
- $arg = $self->__ConvertOldArg($old_arg);
+ $arg = $self->__convert_old_arg($old_arg);
}
- foreach ( $self->__SplitArg($arg) ) {
- $self->_HandleArgument($_);
+ foreach ( $self->__split_arg($arg) ) {
+ $self->_handle_argument($_);
}
my $creator = $self->transaction_obj->creator_obj->email();
@@ -105,23 +105,23 @@
my $instance = shift;
my $obj = RT::Principal->new(RT->system_user);
- $obj->Load($instance);
+ $obj->load($instance);
unless ( $obj->id ) {
Jifty->log->error("Couldn't load principal #$instance");
return;
}
- if ( $obj->Disabled ) {
+ if ( $obj->disabled ) {
Jifty->log->info("Principal #$instance is disabled => skip");
return;
}
- if ( !$obj->PrincipalType ) {
+ if ( !$obj->principal_type ) {
Jifty->log->crit("Principal #$instance has empty type");
}
- elsif ( lc $obj->PrincipalType eq 'user' ) {
- $self->__HandleUserArgument( $obj->Object );
+ elsif ( lc $obj->principal_type eq 'user' ) {
+ $self->__handle_user_argument( $obj->object );
}
- elsif ( lc $obj->PrincipalType eq 'group' ) {
- $self->__HandleGroupArgument( $obj->Object );
+ elsif ( lc $obj->principal_type eq 'group' ) {
+ $self->__handle_group_argument( $obj->object );
}
else {
Jifty->log->info("Principal #$instance has unsupported type");
@@ -138,16 +138,16 @@
Jifty->log->warn( "User #" . $obj->id . " has no email address" );
return;
}
- $self->__PushUserAddress($uea);
+ $self->__push_user_address($uea);
}
sub __HandleGroupArgument {
my $self = shift;
my $obj = shift;
- my $members = $obj->UserMembersObj;
+ my $members = $obj->user_members_obj;
while ( my $m = $members->next ) {
- $self->__HandleUserArgument($m);
+ $self->__handle_user_argument($m);
}
}
@@ -171,7 +171,7 @@
else {
next;
}
- $obj->Load( $r->{'instance'} );
+ $obj->load( $r->{'instance'} );
my $id = $obj->id;
next unless ($id);
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder.pm Wed Jul 16 04:21:29 2008
@@ -103,7 +103,7 @@
=head2 web based interface (WebUI)
Shredder's WebUI integrates into RT's WebUI. You can find it in the
-Configuration->Tools->Shredder tab. The interface is similar to the
+Configuration->tools->shredder tab. The interface is similar to the
CLI and gives you the same functionality. You can find 'Shredder' link
at the bottom of tickets search results, so you could wipeout tickets
in the way similar to the bulk update.
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Exceptions.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Exceptions.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Exceptions.pm Wed Jul 16 04:21:29 2008
@@ -54,7 +54,7 @@
use base qw(Exception::Class::Base);
BEGIN {
- __PACKAGE__->NoRefs(0);
+ __PACKAGE__->no_refs(0);
}
#sub no_refs { return 0 }
Modified: rt/branches/3.999-DANGEROUS/lib/RT/System.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/System.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/System.pm Wed Jul 16 04:21:29 2008
@@ -145,7 +145,7 @@
my $queue = shift;
my $map = $self->first_attribute('BrandedSubjectTag');
- $map = $map->Content if $map;
+ $map = $map->content if $map;
return $queue ? undef : () unless $map;
return $map->{ $queue->id } if $queue;
Modified: rt/branches/3.999-DANGEROUS/sbin/rt-dump-database.in
==============================================================================
--- rt/branches/3.999-DANGEROUS/sbin/rt-dump-database.in (original)
+++ rt/branches/3.999-DANGEROUS/sbin/rt-dump-database.in Wed Jul 16 04:21:29 2008
@@ -128,7 +128,7 @@
next if $obj->can('last_updated_by') and $obj->last_updated_by == $system_userId;
if (!%fields) {
- %fields = map { $_ => 1 } keys %{$obj->_ClassAccessible};
+ %fields = map { $_ => 1 } keys %{$obj->_class_accessible};
delete @fields{
@{$Ignore{$class}||=[]},
@{$Ignore{All}||=[]},
Modified: rt/branches/3.999-DANGEROUS/sbin/rt-email-dashboards.in
==============================================================================
--- rt/branches/3.999-DANGEROUS/sbin/rt-email-dashboards.in (original)
+++ rt/branches/3.999-DANGEROUS/sbin/rt-email-dashboards.in Wed Jul 16 04:21:29 2008
@@ -127,10 +127,10 @@
# look through each user for her subscriptions
my $Users = RT::Model::UserCollection->new(RT->system_user);
-$Users->LimitToPrivileged;
+$Users->limit_to_privileged;
while (defined(my $user = $Users->next)) {
- if ($user->principal_object->Disabled) {
+ if ($user->principal_object->disabled) {
debug "Skipping over "
. $user->name
. " due to having a disabled account.";
@@ -144,34 +144,34 @@
next;
}
- my ($hour, $dow, $dom) = hour_dow_dom_in($user->Timezone || RT->config->get('Timezone'));
+ my ($hour, $dow, $dom) = hour_dow_dom_in($user->timezone || RT->config->get('Timezone'));
$hour .= ':00';
debug "Checking %1's subscriptions: hour %2, dow %3, dom %4",
$user->name, $hour, $dow, $dom;
my $currentuser = RT::CurrentUser->new;
- $currentuser->LoadByName($user->name);
+ $currentuser->load_by_name($user->name);
# look through this user's subscriptions, are any supposed to be generated
# right now?
- for my $subscription ($user->attributes->Named('Subscription')) {
+ for my $subscription ($user->attributes->named('Subscription')) {
if (!$opts{all}) {
- debug "Checking against subscription with frequency %1, hour %2, dow %3, dom %4", $subscription->SubValue('Frequency'), $subscription->SubValue('Hour'), $subscription->SubValue('Dow'), $subscription->SubValue('Dom');
+ debug "Checking against subscription with frequency %1, hour %2, dow %3, dom %4", $subscription->sub_value('Frequency'), $subscription->sub_value('Hour'), $subscription->sub_value('Dow'), $subscription->sub_value('Dom');
- next if $subscription->SubValue('Frequency') eq 'never';
+ next if $subscription->sub_value('Frequency') eq 'never';
# correct hour?
- next if $subscription->SubValue('Hour') ne $hour;
+ next if $subscription->sub_value('Hour') ne $hour;
# if weekly, correct day of week?
- if ($subscription->SubValue('Frequency') eq 'weekly') {
- next if $subscription->SubValue('Dow') ne $dow;
+ if ($subscription->sub_value('Frequency') eq 'weekly') {
+ next if $subscription->sub_value('Dow') ne $dow;
}
# if monthly, correct day of month?
- elsif ($subscription->SubValue('Frequency') eq 'monthly') {
- next if $subscription->SubValue('Dom') != $dom;
+ elsif ($subscription->sub_value('Frequency') eq 'monthly') {
+ next if $subscription->sub_value('Dom') != $dom;
}
}
@@ -183,17 +183,17 @@
sub send_dashboard {
my ($currentuser, $subscription) = @_;
- my $rows = $subscription->SubValue('Rows');
+ my $rows = $subscription->sub_value('Rows');
my $dashboard = RT::Dashboard->new($currentuser);
- my ($ok, $msg) = $dashboard->LoadById($subscription->SubValue('DashboardId'));
+ my ($ok, $msg) = $dashboard->load_by_id($subscription->sub_value('DashboardId'));
# failed to load dashboard. perhaps it was deleted or it changed privacy
if (!$ok) {
warning "Unable to load dashboard %1 of subscription %2 for user %3: %4",
- $subscription->SubValue('DashboardId'),
- $subscription->Id,
+ $subscription->sub_value('DashboardId'),
+ $subscription->id,
$currentuser->name,
$msg;
@@ -208,7 +208,7 @@
# only delete the subscription if the email looks like it went through
if ($ok) {
- my ($deleted, $msg) = $subscription->Delete();
+ my ($deleted, $msg) = $subscription->delete();
if ($deleted) {
verbose("Deleted an obsolete subscription: %1", $msg);
}
@@ -238,7 +238,7 @@
$HTML::Mason::Commands::session{CurrentUser} = $currentuser;
my $contents = run_component(
'/Dashboards/Render.html',
- id => $dashboard->Id,
+ id => $dashboard->id,
Preview => 0,
);
@@ -266,7 +266,7 @@
my $subject = sprintf '[%s] ' . RT->config->get('DashboardSubject'),
RT->config->get('rtname'),
- ucfirst($subscription->SubValue('Frequency')),
+ ucfirst($subscription->sub_value('Frequency')),
$dashboard->name;
my $entity = build_email(
@@ -358,7 +358,7 @@
unless ($mason) {
debug "Creating Mason object.";
$mason = HTML::Mason::Interp->new(
- RT::Interface::Web::Handler->DefaultHandlerArgs,
+ RT::Interface::Web::Handler->default_handler_args,
out_method => \$outbuf,
autohandler_name => '', # disable forced login and more
);
Modified: rt/branches/3.999-DANGEROUS/sbin/rt-email-digest.in
==============================================================================
--- rt/branches/3.999-DANGEROUS/sbin/rt-email-digest.in (original)
+++ rt/branches/3.999-DANGEROUS/sbin/rt-email-digest.in Wed Jul 16 04:21:29 2008
@@ -160,8 +160,8 @@
# Load our template. If we cannot load the template, abort
# immediately rather than failing through many loops.
- my $digest_template = RT::Model::Template->new( RT->SystemUser );
- my ( $ret, $msg ) = $digest_template->Load('Email Digest');
+ my $digest_template = RT::Model::Template->new( RT->system_user );
+ my ( $ret, $msg ) = $digest_template->load('Email Digest');
unless ($ret) {
print loc("Failed to load template")
. " 'Email Digest': "
@@ -169,7 +169,7 @@
. ". Cannot continue.\n";
exit 1;
}
- ( $ret, $msg ) = $digest_template->Parse( Argument => $body );
+ ( $ret, $msg ) = $digest_template->parse( Argument => $body );
unless ($ret) {
print loc("Failed to parse template")
. " 'Email Digest'. Cannot continue.\n";
@@ -177,7 +177,7 @@
}
# Set our sender and recipient.
- $digest_template->MIMEObj->head->replace( 'From', RT::Config->Get('CorrespondAddress') );
+ $digest_template->MIMEObj->head->replace( 'From', RT::Config->get('CorrespondAddress') );
$digest_template->MIMEObj->head->replace( 'To', $to );
if ($print) {
@@ -204,10 +204,10 @@
# Grab the attribute, mark the "sent" as true, and store the new
# value.
- if ( my $attr = $txn->FirstAttribute('DeferredRecipients') ) {
- my $deferred = $attr->Content;
+ if ( my $attr = $txn->first_attribute('DeferredRecipients') ) {
+ my $deferred = $attr->content;
$deferred->{$freq}->{$user}->{'_sent'} = 1;
- $txn->SetAttribute(
+ $txn->set_attribute(
Name => 'DeferredRecipients',
description => 'Deferred recipients for this message',
Content => $deferred,
@@ -223,15 +223,15 @@
# this process exactly on time.
my $OVERLAP_HEDGE = -30;
- my $since_date = RT::Date->new( RT->SystemUser );
- $since_date->Set( Format => 'unix', Value => time() );
+ my $since_date = RT::Date->new( RT->system_user );
+ $since_date->set( Format => 'unix', Value => time() );
if ( $frequency eq 'daily' ) {
- $since_date->AddDays(-1);
+ $since_date->add_days(-1);
} else {
- $since_date->AddDays(-7);
+ $since_date->add_days(-7);
}
- $since_date->AddSeconds($OVERLAP_HEDGE);
+ $since_date->add_seconds($OVERLAP_HEDGE);
return $since_date;
}
@@ -240,18 +240,18 @@
my $frequency = shift;
my $since_date = since_date($frequency);
- my $txns = RT::Model::TransactionCollection->new( RT->SystemUser );
+ my $txns = RT::Model::TransactionCollection->new( RT->system_user );
# First limit to recent transactions.
- $txns->Limit(
- FIELD => 'Created',
+ $txns->limit(
+ field => 'Created',
OPERATOR => '>',
VALUE => $since_date->iso
);
# Next limit to ticket transactions.
- $txns->Limit(
- FIELD => 'ObjectType',
+ $txns->limit(
+ field => 'ObjectType',
OPERATOR => '=',
VALUE => 'RT::Model::Ticket',
ENTRYAGGREGATOR => 'AND'
@@ -260,10 +260,10 @@
my $sent_transactions = {};
while ( my $txn = $txns->next ) {
- my $ticket = $txn->Ticket;
+ my $ticket = $txn->ticket;
my $queue = $txn->ticket_obj->queue_obj->name;
# Xxx todo - may clobber if two queues have the same name
- foreach my $user ( $txn->DeferredRecipients($frequency) ) {
+ foreach my $user ( $txn->deferred_recipients($frequency) ) {
$all_digest->{$user}->{$queue}->{$ticket}->{ $txn->id } = $txn->content_obj;
$sent_transactions->{$user}->{ $txn->id } = $txn;
}
@@ -281,9 +281,9 @@
# Has the user been disabled since a message was deferred on his/her
# behalf?
- my $user_obj = RT::Model::User->new( RT->SystemUser );
- $user_obj->LoadByEmail($user);
- if ( $user_obj->principal_object->Disabled ) {
+ my $user_obj = RT::Model::User->new( RT->system_user );
+ $user_obj->load_by_email($user);
+ if ( $user_obj->principal_object->disabled ) {
print STDERR loc("Skipping disabled user") . " $user\n";
next;
}
@@ -294,14 +294,14 @@
$contents_body .= "Queue $queue:\n";
foreach my $ticket ( sort keys %{ $user_digest->{$queue} } ) {
my $tkt_txns = $user_digest->{$queue}->{$ticket};
- my $ticket_obj = RT::Model::Ticket->new( RT->SystemUser );
- $ticket_obj->Load($ticket);
+ my $ticket_obj = RT::Model::Ticket->new( RT->system_user );
+ $ticket_obj->load($ticket);
# Spit out the index entry for this ticket.
my $ticket_title = sprintf(
"#%d %s [%s]\t%s\n",
- $ticket, $ticket_obj->Status, $ticket_obj->owner_obj->name,
- $ticket_obj->Subject
+ $ticket, $ticket_obj->status, $ticket_obj->owner_obj->name,
+ $ticket_obj->subject
);
$contents_list .= $ticket_title;
@@ -312,21 +312,21 @@
# $msg contains an RT::Model::Attachment with our outgoing
# message. Print a few headers for clarity's sake.
- $contents_body .= "From: " . $msg->GetHeader('From') . "\n";
- my $date = $msg->GetHeader('Date ');
+ $contents_body .= "From: " . $msg->get_header('From') . "\n";
+ my $date = $msg->get_header('Date ');
unless ($date) {
- my $txn_obj = RT::Model::Transaction->new( RT->SystemUser );
- $txn_obj->Load($txn);
- my $date_obj = RT::Date->new( RT->SystemUser );
- $date_obj->Set(
+ my $txn_obj = RT::Model::Transaction->new( RT->system_user );
+ $txn_obj->load($txn);
+ my $date_obj = RT::Date->new( RT->system_user );
+ $date_obj->set(
Format => 'sql',
- Value => $txn_obj->Created
+ Value => $txn_obj->created
);
$date = strftime( '%a, %d %b %Y %H:%M:%S %z',
@{ [ localtime( $date_obj->unix ) ] } );
}
$contents_body .= "Date: $date\n\n";
- $contents_body .= $msg->Content . "\n";
+ $contents_body .= $msg->content . "\n";
$contents_body .= "-------\n";
} # foreach transaction
} # foreach ticket
Modified: rt/branches/3.999-DANGEROUS/sbin/rt-email-group-admin.in
==============================================================================
--- rt/branches/3.999-DANGEROUS/sbin/rt-email-group-admin.in (original)
+++ rt/branches/3.999-DANGEROUS/sbin/rt-email-group-admin.in Wed Jul 16 04:21:29 2008
@@ -225,19 +225,19 @@
my $action = shift;
print "Name: ". $action->name() ."\n";
- print "Module: ". $action->ExecModule() ."\n";
+ print "Module: ". $action->exec_module() ."\n";
my @princ = argument_to_list( $action );
print "Members: \n";
foreach( @princ ) {
my $obj = RT::Principal->new( RT->system_user );
- $obj->Load( $_ );
+ $obj->load( $_ );
next unless $obj->id;
- print "\t". $obj->PrincipalType;
- print "\t=> ". $obj->Object->name;
- print "(Disabled!!!)" if $obj->Disabled;
+ print "\t". $obj->principal_type;
+ print "\t=> ". $obj->object->name;
+ print "(Disabled!!!)" if $obj->disabled;
print "\n";
}
print "\n";
@@ -253,11 +253,11 @@
sub create {
my $actions = RT::ScripActions->new( RT->system_user );
- $actions->Limit(
- FIELD => 'Name',
+ $actions->limit(
+ field => 'Name',
VALUE => $opts->{'name'},
);
- if ( $actions->Count ) {
+ if ( $actions->count ) {
print STDERR "ScripAction '". $opts->{'name'} ."' allready exists\n";
exit(-1);
}
@@ -282,7 +282,7 @@
my $as_comment = shift || 0;
require RT::ScripAction;
my $action = RT::ScripAction->new( RT->system_user );
- $action->Create(
+ $action->create(
Name => $name,
description => "Created with rt-email-group-admin script",
ExecModule => $as_comment? 'NotifyGroupAsComment': 'NotifyGroup',
@@ -303,7 +303,7 @@
my $instance = shift;
require RT::Model::Group;
my $obj = RT::Model::Group->new( RT->system_user );
- $obj->LoadUserDefinedGroup( $instance );
+ $obj->load_user_defined_group( $instance );
return $obj->id ? $obj : undef;
}
@@ -318,7 +318,7 @@
my $instance = shift;
require RT::Model::User;
my $obj = RT::Model::User->new( RT->system_user );
- $obj->Load( $instance );
+ $obj->load( $instance );
return $obj->id ? $obj : undef;
}
@@ -361,7 +361,7 @@
push @cur, $id;
- return $action->__Set( Field => 'Argument', Value => join(';', @cur) );
+ return $action->__set( Field => 'Argument', Value => join(';', @cur) );
}
=head2 delete NAME
@@ -379,8 +379,8 @@
require RT::Model::ScripCollection;
my $scrips = RT::Model::ScripCollection->new( RT->system_user );
- $scrips->Limit( FIELD => 'ScripAction', VALUE => $action->id );
- if ( $scrips->Count ) {
+ $scrips->limit( field => 'ScripAction', VALUE => $action->id );
+ if ( $scrips->count ) {
my @sid;
while( my $s = $scrips->next ) {
push @sid, $s->id;
@@ -402,16 +402,16 @@
sub _get_action_by_name {
my $name = shift;
my $actions = _get_our_actions();
- $actions->Limit(
- FIELD => 'Name',
+ $actions->limit(
+ field => 'Name',
VALUE => $name
);
- if ( $actions->Count > 1 ) {
+ if ( $actions->count > 1 ) {
print STDERR "More then one ScripAction with name '$name'\n";
}
- return $actions->First;
+ return $actions->first;
}
=head2 switch NAME
@@ -432,9 +432,9 @@
NotifyGroupAsComment => 'NotifyGroup'
);
- return $action->__Set(
+ return $action->__set(
Field => 'ExecModule',
- Value => $h{ $action->ExecModule }
+ Value => $h{ $action->exec_module }
);
}
@@ -452,13 +452,13 @@
}
my $actions = RT::ScripActions->new( RT->system_user );
- $actions->Limit( FIELD => 'Name', VALUE => $opts->{'newname'} );
- if ( $actions->Count ) {
+ $actions->limit( field => 'Name', VALUE => $opts->{'newname'} );
+ if ( $actions->count ) {
print STDERR "ScripAction '". $opts->{'newname'} ."' allready exists\n";
exit(-1);
}
- return $action->__Set(
+ return $action->__set(
Field => 'Name',
Value => $opts->{'newname'},
);
@@ -477,7 +477,7 @@
sub argument_to_list {
my $action = shift;
- my $arg = $action->Argument;
+ my $arg = $action->argument;
# old variant via Storable
{
@@ -507,7 +507,7 @@
} else {
next;
}
- $obj->Load( $r->{'Instance'} );
+ $obj->load( $r->{'Instance'} );
my $id = $obj->id;
next unless $id;
@@ -519,13 +519,13 @@
sub _get_our_actions {
my $actions = RT::ScripActions->new( RT->system_user );
- $actions->Limit(
- FIELD => 'ExecModule',
+ $actions->limit(
+ field => 'ExecModule',
VALUE => 'NotifyGroup',
ENTRYAGGREGATOR => 'OR',
);
- $actions->Limit(
- FIELD => 'ExecModule',
+ $actions->limit(
+ field => 'ExecModule',
VALUE => 'NotifyGroupAsComment',
ENTRYAGGREGATOR => 'OR',
);
Modified: rt/branches/3.999-DANGEROUS/sbin/rt-server.in
==============================================================================
--- rt/branches/3.999-DANGEROUS/sbin/rt-server.in (original)
+++ rt/branches/3.999-DANGEROUS/sbin/rt-server.in Wed Jul 16 04:21:29 2008
@@ -76,7 +76,7 @@
use RT;
RT::LoadConfig();
-RT->InitLogging();
+RT->init_logging();
if (RT->config->get('DevelMode')) { require Module::Refresh; }
RT::CheckPerlRequirements();
@@ -85,7 +85,7 @@
require RT::Handle;
-my ($integrity, $state, $msg) = RT::Handle->CheckIntegrity;
+my ($integrity, $state, $msg) = RT::Handle->check_integrity;
unless ( $integrity ) {
print STDERR <<EOF;
@@ -105,16 +105,16 @@
require RT::Installer;
# don't enter install mode if the file exists but is unwritable
- if (-e RT::Installer->ConfigFile && !-w _) {
+ if (-e RT::Installer->config_file && !-w _) {
die "Since your configuration exists but is not writable, I'm refusing to do anything.\n";
}
RT->install_mode(1);
} else {
- RT->ConnectToDatabase();
- RT->InitSystemObjects();
- RT->InitClasses();
- RT->InitPlugins();
+ RT->connect_to_database();
+ RT->init_system_objects();
+ RT->init_classes();
+ RT->init_plugins();
}
require RT::Interface::Web::Standalone;
Modified: rt/branches/3.999-DANGEROUS/share/html/Admin/Tools/Shredder/index.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Admin/Tools/Shredder/index.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Admin/Tools/Shredder/index.html Wed Jul 16 04:21:29 2008
@@ -109,14 +109,14 @@
next unless $k =~ /^\Q$Plugin\E:(.*)$/;
$args{ $1 } = $ARGS{$k};
}
- ( $status, $msg ) = $plugin_obj->HasSupportForArgs( keys %args );
+ ( $status, $msg ) = $plugin_obj->has_support_for_args( keys %args );
unless( $status ) {
push @{ $messages{Errors} }, $msg;
$Search = '';
last;
}
- ($status, $msg) = eval { $plugin_obj->TestArgs( %args ) };
+ ($status, $msg) = eval { $plugin_obj->test_args( %args ) };
$catch_non_fatals->() && last if $@;
unless( $status ) {
push @{ $messages{Errors} }, $msg;
@@ -144,7 +144,7 @@
last;
}
- ($dump_file) = $backup_plugin->FileName;
+ ($dump_file) = $backup_plugin->file_name;
push @{ $messages{'Success'} }, "SQL dump file is '$dump_file'";
$shredder->add_dump_plugin( object => $backup_plugin );
@@ -156,7 +156,7 @@
$Search = ''; @objs = ();
last;
}
- eval { $shredder->WipeoutAll };
+ eval { $shredder->wipeout_all };
$catch_non_fatals->() && last if $@;
@@ -166,7 +166,7 @@
if( $Plugin && ( $Search || $Wipeout ) ) { { # use additional block({}) to effectively exit block on errors
my $status;
- ($status, @objs) = eval { $plugin_obj->Run };
+ ($status, @objs) = eval { $plugin_obj->run };
$catch_non_fatals->() && last if $@;
unless( $status ) {
push @{ $messages{Errors} }, $objs[0];
Modified: rt/branches/3.999-DANGEROUS/share/html/Admin/Users/Modify.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Admin/Users/Modify.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Admin/Users/Modify.html Wed Jul 16 04:21:29 2008
@@ -148,12 +148,12 @@
<tr><td align="right">
<&|/l&>Address1</&>:
</td><td>
-<input name="Address1" value="<%$user_object->Address1%>" />
+<input name="Address1" value="<%$user_object->address1%>" />
</td></tr>
<tr><td align="right">
<&|/l&>Address2</&>:
</td><td>
-<input name="Address2" value="<%$user_object->Address2%>" />
+<input name="Address2" value="<%$user_object->address2%>" />
</td></tr>
<tr><td align="right">
<&|/l&>City</&>:
Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/DashboardsForObject
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/DashboardsForObject (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/DashboardsForObject Wed Jul 16 04:21:29 2008
@@ -58,7 +58,7 @@
while (my $attr = $Object->attributes->next) {
if ($attr->name =~ /^Dashboard\b/) {
my $dashboard = RT::Dashboard->new( current_user => Jifty->web->current_user );
- my ($ok, $msg) = $dashboard->Load($privacy, $attr->id);
+ my ($ok, $msg) = $dashboard->load($privacy, $attr->id);
if (!$ok) {
Jifty->log->debug("Unable to load dashboard $ok (privacy $privacy): $msg");
Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/SelectPrivacy
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/SelectPrivacy (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/SelectPrivacy Wed Jul 16 04:21:29 2008
@@ -55,7 +55,7 @@
% my $privacy = ref($object) . '-' . $object->id;
% my $selected = $privacy eq ($Default || '') ? 'selected="selected"' : '';
-% if (ref($object) eq 'RT::Model::User' && $object->id == Jifty->web->current_user->Id) {
+% if (ref($object) eq 'RT::Model::User' && $object->id == Jifty->web->current_user->id) {
<option <%$selected|n%> value="<%$privacy%>"><&|/l&>My dashboards</&></option>
% } else {
<option <%$selected|n%> value="<%$privacy%>"><&|/l, $object->name&>%1's dashboards</&></option>
Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/ShowDashboards
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/ShowDashboards (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/ShowDashboards Wed Jul 16 04:21:29 2008
@@ -62,7 +62,7 @@
my %subscription_for;
for my $attr (Jifty->web->current_user->user_object->attributes->named('Subscription')) {
- $subscription_for{$attr->SubValue('DashboardId')} = $attr;
+ $subscription_for{$attr->sub_value('DashboardId')} = $attr;
}
</%INIT>
@@ -84,14 +84,14 @@
% for my $dashboard (@$Dashboards) {
% my $url = sprintf '%s/Dashboards/%d/%s',
% RT->config->get('WebPath'),
-% $dashboard->Id,
+% $dashboard->id,
% $dashboard->name;
<tr class="collection-as-table <% ++$i % 2 ? 'oddline' : 'evenline' %>">
% if ($Verbose) {
<td class="collection-as-table">
<a href="<% $url %>">
- <% $dashboard->Id %>
+ <% $dashboard->id %>
</a>
</td>
% }
@@ -101,7 +101,7 @@
</a>
</td>
<td class="collection-as-table">
- <& /Dashboards/Elements/ShowSubscription, Dashboard => $dashboard, Subscription => $subscription_for{$dashboard->Id} &>
+ <& /Dashboards/Elements/ShowSubscription, Dashboard => $dashboard, Subscription => $subscription_for{$dashboard->id} &>
</td>
</tr>
% }
Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/ShowSubscription
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/ShowSubscription (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/ShowSubscription Wed Jul 16 04:21:29 2008
@@ -53,20 +53,20 @@
<%INIT>
my $url = sprintf '%s/Dashboards/Subscription.html?DashboardId=%d',
RT->config->get('WebPath'),
- $Dashboard->Id,;
+ $Dashboard->id,;
my $frequency = loc("None");
if (defined $Subscription) {
- my $freq = $Subscription->SubValue('Frequency');
- my $hour = $Subscription->SubValue('Hour');
+ my $freq = $Subscription->sub_value('Frequency');
+ my $hour = $Subscription->sub_value('Hour');
if ($freq eq 'weekly') {
- my $day = (qw/Monday Tuesday Wednesday Thursday Friday Saturday Sunday/)[$Subscription->SubValue('Dow')];
+ my $day = (qw/Monday Tuesday Wednesday Thursday Friday Saturday Sunday/)[$Subscription->sub_value('Dow')];
$frequency = loc("%1 (on %2) at %3", $freq, $day, $hour);
}
elsif ($freq eq 'monthly') {
- $frequency = loc("%1 (day %2) at %3", $freq, $Subscription->SubValue('Dom'), $hour);
+ $frequency = loc("%1 (day %2) at %3", $freq, $Subscription->sub_value('Dom'), $hour);
}
elsif ($freq eq 'daily') {
$frequency = loc("%1 at %2", $freq, $hour);
Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/Tabs
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/Tabs (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Elements/Tabs Wed Jul 16 04:21:29 2008
@@ -54,13 +54,13 @@
<%INIT>
my $tabs;
my $real_subtab = $current_subtab;
-if ( $DashboardObj and $DashboardObj->Id ) {
+if ( $DashboardObj and $DashboardObj->id ) {
my $name = $DashboardObj->name;
- my $modify = "Dashboards/Modify.html?id=" . $DashboardObj->Id;
- my $queries = "Dashboards/Queries.html?id=" . $DashboardObj->Id;
- my $render = "Dashboards/" . $DashboardObj->Id . "/$name";
+ my $modify = "Dashboards/Modify.html?id=" . $DashboardObj->id;
+ my $queries = "Dashboards/Queries.html?id=" . $DashboardObj->id;
+ my $render = "Dashboards/" . $DashboardObj->id . "/$name";
$tabs->{"this"} = {
title => $DashboardObj->name,
@@ -76,7 +76,7 @@
},
c_Subscription => { title => loc('Subscription'),
- path => "Dashboards/Subscription.html?DashboardId=" . $DashboardObj->Id
+ path => "Dashboards/Subscription.html?DashboardId=" . $DashboardObj->id
},
@@ -87,7 +87,7 @@
};
delete $tabs->{"this"}{"subtabs"}{"c_Subscription"}
- unless $DashboardObj->CurrentUserCanSubscribe;
+ unless $DashboardObj->current_user_can_subscribe;
$tabs->{"this"}{"subtabs"}{"z_Preview"}{path} = $real_subtab
if $real_subtab =~ /Render/
Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Modify.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Modify.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Modify.html Wed Jul 16 04:21:29 2008
@@ -55,10 +55,10 @@
<form action="<%RT->config->get('WebPath')%>/Dashboards/Modify.html" method="post" enctype="multipart/form-data" name="ModifyDashboard">
-%unless ($Dashboard->Id) {
+%unless ($Dashboard->id) {
<input type="hidden" class="hidden" name="id" value="new" />
% } else {
-<input type="hidden" class="hidden" name="id" value="<%$Dashboard->Id%>" />
+<input type="hidden" class="hidden" name="id" value="<%$Dashboard->id%>" />
% }
<table>
<tr><td align="right">
@@ -69,11 +69,11 @@
<tr><td align="right">
<&|/l&>Privacy</&>:
</td><td>
-<& /Dashboards/Elements/SelectPrivacy, Name => "Privacy", Objects => \@privacies, Default => $Dashboard->Privacy &>
+<& /Dashboards/Elements/SelectPrivacy, Name => "Privacy", Objects => \@privacies, Default => $Dashboard->privacy &>
</td></tr>
</table>
<& /Elements/Submit, Name => 'Save', Label => loc('Save Changes') &>
-% if ($Dashboard->Id && $can_delete) {
+% if ($Dashboard->id && $can_delete) {
<& /Elements/Submit, Name => 'Delete', Label => loc('Delete') &>
% }
</form>
@@ -101,7 +101,7 @@
if ($id eq 'new') {
$tried_create = 1;
- my ($val, $msg) = $Dashboard->Save(
+ my ($val, $msg) = $Dashboard->save(
Name => $ARGS{'Name'},
Privacy => $ARGS{'Privacy'},
);
@@ -111,10 +111,10 @@
}
push @results, $msg;
- $id = $Dashboard->Id;
+ $id = $Dashboard->id;
}
else {
- my ($ok, $msg) = $Dashboard->LoadById($id);
+ my ($ok, $msg) = $Dashboard->load_by_id($id);
$ok || abort($msg);
}
@@ -131,7 +131,7 @@
}
if (!$Create && !$tried_create && $id && $ARGS{'Save'}) {
- my ($ok, $msg) = $Dashboard->Update(Privacy => $ARGS{'Privacy'},
+ my ($ok, $msg) = $Dashboard->update(Privacy => $ARGS{'Privacy'},
Name => $ARGS{'Name'});
if ($ok) {
@@ -143,10 +143,10 @@
}
-my $can_delete = $Dashboard->CurrentUserCanDelete;
+my $can_delete = $Dashboard->current_user_can_delete;
if (!$Create && !$tried_create && $id && $ARGS{'Delete'}) {
- my ($ok, $msg) = $Dashboard->Delete();
+ my ($ok, $msg) = $Dashboard->delete();
$ok || abort(loc("Couldn't delete dashboard %1: %2", $id, $msg));
# put the user back into a useful place with a message
Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Queries.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Queries.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Queries.html Wed Jul 16 04:21:29 2008
@@ -56,8 +56,8 @@
<& /Elements/ListActions, actions => \@results &>
<form action="<%RT->config->get('WebPath')%>/Dashboards/Queries.html" method="post" enctype="multipart/form-data" name="DashboardQueries">
-<input type="hidden" class="hidden" name="id" value="<%$Dashboard->Id%>" />
-<input type="hidden" class="hidden" name="Privacy" value="<%$Dashboard->Privacy%>" />
+<input type="hidden" class="hidden" name="id" value="<%$Dashboard->id%>" />
+<input type="hidden" class="hidden" name="Privacy" value="<%$Dashboard->privacy%>" />
<table width="100%" border="0">
<tr>
@@ -83,7 +83,7 @@
use RT::Dashboard;
my $Dashboard = new RT::Dashboard( current_user => Jifty->web->current_user );
-my ($ok, $msg) = $Dashboard->LoadById($id);
+my ($ok, $msg) = $Dashboard->load_by_id($id);
$ok || abort(loc("Couldn't load dashboard %1: %2", $id, $msg));
my $title = loc("Modify the queries of dashboard %1", $Dashboard->name);
@@ -92,7 +92,7 @@
my @selected;
# Get the list of queries already in use
-for ($Dashboard->SearchIds) {
+for ($Dashboard->search_ids) {
my ($privacy, $id, $desc) = @$_;
my $name = "$id-$privacy";
push @selected, $name;
@@ -103,15 +103,15 @@
my @objs = ($sys);
push @objs, RT::SavedSearches->new( current_user => Jifty->web->current_user )->_privacy_objects
- if Jifty->web->current_user->HasRight( Right => 'LoadSavedSearch',
+ if Jifty->web->current_user->has_right( Right => 'LoadSavedSearch',
Object => $RT::System );
for my $object (@objs) {
for ($m->comp("/Search/Elements/SearchesForObject", Object => $object)) {
my ($desc, $search) = @$_;
- my $SearchType = $search->Content->{'SearchType'} || 'Ticket';
+ my $SearchType = $search->content->{'SearchType'} || 'Ticket';
my $privacy = $Dashboard->_build_privacy($object);
- my $name = $search->Id . '-' . $privacy;
+ my $name = $search->id . '-' . $privacy;
push @items, [$name, $desc];
$desc_of{$name} = $desc;
}
@@ -134,7 +134,7 @@
[ reverse(split /-/, $_, 2), $desc_of{$_} ]
} @{ $self->{Current} } ];
- my ($ok, $msg) = $Dashboard->Update(Searches => $searches);
+ my ($ok, $msg) = $Dashboard->update(Searches => $searches);
if ($ok) {
push @results, loc("Dashboard updated");
Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Render.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Render.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Render.html Wed Jul 16 04:21:29 2008
@@ -58,9 +58,9 @@
<tr valign="top">
<td class="boxcontainer" width="70%">
-% foreach ($DashboardObj->SearchIds) {
+% foreach ($DashboardObj->search_ids) {
% my ($type, $id, $desc) = @$_;
-% my @for_showsearch = $DashboardObj->SearchPrivacy(@$_);
+% my @for_showsearch = $DashboardObj->search_privacy(@$_);
<& /Elements/ShowSearch,
@for_showsearch,
Override => { Rows => $rows },
@@ -79,7 +79,7 @@
use RT::Dashboard;
my $DashboardObj = RT::Dashboard->new( current_user => Jifty->web->current_user );
-my ($ok, $msg) = $DashboardObj->LoadById($id);
+my ($ok, $msg) = $DashboardObj->load_by_id($id);
abort(loc("Couldn't load dashboard %1: %2", $id, $msg)) if !$ok;
my $SubscriptionObj = RT::Model::Attribute->new( current_user => Jifty->web->current_user );
@@ -87,13 +87,13 @@
# try to load the subscription to this id
for my $sub (Jifty->web->current_user->user_object->attributes->named('Subscription')) {
- next unless $sub->SubValue('DashboardId') == $id;
+ next unless $sub->sub_value('DashboardId') == $id;
$SubscriptionObj = $sub;
$Loaded = 1;
last;
}
-my $rows = $Loaded ? $SubscriptionObj->SubValue('Rows') : 20;
+my $rows = $Loaded ? $SubscriptionObj->sub_value('Rows') : 20;
my $title = $DashboardObj->name;
</%INIT>
Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/Subscription.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/Subscription.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/Subscription.html Wed Jul 16 04:21:29 2008
@@ -71,7 +71,7 @@
<tr><td class="label">
<&|/l&>Queries</&>:
</td><td class="value">
-% my @searches = grep { defined } $DashboardObj->Searches;
+% my @searches = grep { defined } $DashboardObj->searches;
% if (!@searches) {
(none)
% } else {
@@ -157,7 +157,7 @@
</tr>
</table>
-% if ($SubscriptionObj->Id) {
+% if ($SubscriptionObj->id) {
<& /Elements/Submit, Name => "Save", Label => loc('Save Changes') &>
% } else {
<& /Elements/Submit, Name => "Save", Label => loc('Subscribe') &>
@@ -180,16 +180,16 @@
# first let's see if we already have a subscription to this DashboardId
for my $sub (Jifty->web->current_user->user_object->attributes->named('Subscription')) {
- next unless $sub->SubValue('DashboardId') == $DashboardId;
+ next unless $sub->sub_value('DashboardId') == $DashboardId;
$SubscriptionObj = $sub;
last;
}
-$DashboardId = $SubscriptionObj->Id
- ? $SubscriptionObj->SubValue('DashboardId')
+$DashboardId = $SubscriptionObj->id
+ ? $SubscriptionObj->sub_value('DashboardId')
: $ARGS{'DashboardId'};
-($val, $msg) = $DashboardObj->LoadById($DashboardId);
+($val, $msg) = $DashboardObj->load_by_id($DashboardId);
$val || abort(loc("Couldn't load dashboard %1: %2.", $DashboardId, $msg));
my %fields = (
@@ -202,9 +202,9 @@
);
# update any fields with the values from the subscription object
-if ($SubscriptionObj->Id) {
+if ($SubscriptionObj->id) {
for my $field (keys %fields) {
- $fields{$field} = $SubscriptionObj->SubValue($field);
+ $fields{$field} = $SubscriptionObj->sub_value($field);
}
}
@@ -219,9 +219,9 @@
# this'll be defined on submit
if (defined $ARGS{Save}) {
# update
- if ($SubscriptionObj->Id) {
+ if ($SubscriptionObj->id) {
$DashboardId = delete $fields{'DashboardId'}; # immutable
- ($val, $msg) = $SubscriptionObj->SetSubValues(%fields);
+ ($val, $msg) = $SubscriptionObj->set_sub_values(%fields);
$fields{'DashboardId'} = $DashboardId;
# not so good to spew base64-encoded data at the user :)
@@ -234,9 +234,9 @@
# create
else {
abort(loc("Unable to subscribe to dashboard %1: Permission denied", $DashboardId))
- unless $DashboardObj->CurrentUserCanSubscribe;
+ unless $DashboardObj->current_user_can_subscribe;
- my ($val, $msg) = $SubscriptionObj->Create(
+ my ($val, $msg) = $SubscriptionObj->create(
Name => 'Subscription',
description => 'Subscription to dashboard ' . $DashboardId,
ContentType => 'storable',
@@ -254,7 +254,7 @@
}
}
-if ($SubscriptionObj->Id) {
+if ($SubscriptionObj->id) {
$title = loc("Modify the subscription to dashboard %1", $DashboardObj->name);
}
else {
Modified: rt/branches/3.999-DANGEROUS/share/html/Dashboards/index.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Dashboards/index.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Dashboards/index.html Wed Jul 16 04:21:29 2008
@@ -54,18 +54,18 @@
<& /Dashboards/Elements/ShowDashboards,
Type => "Personal",
- Dashboards => [sort { $a->Id <=> $b->Id } @{ $dashboards->{personal} || [] }],
+ Dashboards => [sort { $a->id <=> $b->id } @{ $dashboards->{personal} || [] }],
&>
<& /Dashboards/Elements/ShowDashboards,
Type => "System",
- Dashboards => [sort { $a->Id <=> $b->Id } @{ $dashboards->{system} || [] }],
+ Dashboards => [sort { $a->id <=> $b->id } @{ $dashboards->{system} || [] }],
&>
% for my $group (sort keys %{ $dashboards->{group} || {} }) {
<& /Dashboards/Elements/ShowDashboards,
Type => $group,
- Dashboards => [sort { $a->Id <=> $b->Id } @{ $dashboards->{group}{$group} || [] }],
+ Dashboards => [sort { $a->id <=> $b->id } @{ $dashboards->{group}{$group} || [] }],
&>
% }
Modified: rt/branches/3.999-DANGEROUS/share/html/Elements/Dashboards
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Elements/Dashboards (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Elements/Dashboards Wed Jul 16 04:21:29 2008
@@ -62,10 +62,10 @@
my $dashboard_map = $m->comp("/Dashboards/Elements/DashboardsForObjects", Objects => \@objs);
my @dashboards = (
- (sort { $a->Id <=> $b->Id } @{ $dashboard_map->{personal} || [] }),
- (sort { $a->Id <=> $b->Id } @{ $dashboard_map->{system} || [] }),
+ (sort { $a->id <=> $b->id } @{ $dashboard_map->{personal} || [] }),
+ (sort { $a->id <=> $b->id } @{ $dashboard_map->{system} || [] }),
- map { sort { $a->Id <=> $b->Id } @{ $dashboard_map->{group}{$_} } }
+ map { sort { $a->id <=> $b->id } @{ $dashboard_map->{group}{$_} } }
keys %{ $dashboard_map->{group} || {} },
);
Modified: rt/branches/3.999-DANGEROUS/share/html/Elements/EditCustomFieldSelect
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Elements/EditCustomFieldSelect (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Elements/EditCustomFieldSelect Wed Jul 16 04:21:29 2008
@@ -83,9 +83,9 @@
<%METHOD options>
% @default = grep defined && length, @Default;
-% # $Values->HasEntry is too slow here
+% # $Values->has_entry is too slow here
% if ( !@default && $Values ) {
-% @default = map $_->Content, @{$Values->items_array_ref};
+% @default = map $_->content, @{$Values->items_array_ref};
% }
% $_ = lc $_ foreach @Default;
% my $selected;
Modified: rt/branches/3.999-DANGEROUS/share/html/Elements/GnuPG/KeyIssues
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Elements/GnuPG/KeyIssues (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Elements/GnuPG/KeyIssues Wed Jul 16 04:21:29 2008
@@ -77,7 +77,7 @@
<& /Elements/GnuPG/SelectKeyForEncryption,
Name => 'UseKey-'. $issue->{'EmailAddress'},
EmailAddress => $issue->{'EmailAddress'},
- Default => ( $issue->{'User'}? $issue->{'User'}->PreferredKey : undef ),
+ Default => ( $issue->{'User'}? $issue->{'User'}->preferred_key : undef ),
&>
</li>
% }
Modified: rt/branches/3.999-DANGEROUS/share/html/Elements/RT__Scrip/ColumnMap
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Elements/RT__Scrip/ColumnMap (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Elements/RT__Scrip/ColumnMap Wed Jul 16 04:21:29 2008
@@ -66,11 +66,11 @@
},
Condition => {
title => 'Condition',
- value => sub { return $_[0]->loc( $_[0]->ScripConditionObj->name ) },
+ value => sub { return $_[0]->loc( $_[0]->scrip_condition_obj->name ) },
},
Action => {
title => 'Action',
- value => sub { return $_[0]->loc( $_[0]->ScripActionObj->name ) },
+ value => sub { return $_[0]->loc( $_[0]->scrip_action_obj->name ) },
},
Template => {
title => 'Template',
Modified: rt/branches/3.999-DANGEROUS/share/html/Elements/ShowCustomFieldText
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Elements/ShowCustomFieldText (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Elements/ShowCustomFieldText Wed Jul 16 04:21:29 2008
@@ -46,7 +46,7 @@
%#
%# END BPS TAGGED BLOCK }}}
<%init>
- my $content = $Object->LargeContent || $Object->Content;
+ my $content = $Object->large_content || $Object->content;
$content = $m->comp('/Elements/ScrubHTML', Content => $content);
$content =~ s|\n|<br />|g;
</%init>
Modified: rt/branches/3.999-DANGEROUS/share/html/Elements/ShowLink
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Elements/ShowLink (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Elements/ShowLink Wed Jul 16 04:21:29 2008
@@ -49,7 +49,7 @@
% if ($URI->is_local) {
% my $member = $URI->object;
% if (UNIVERSAL::isa($member, "RT::Model::Ticket")) {
-% my $inactive = $member->queue_obj->IsInactiveStatus($member->status);
+% my $inactive = $member->queue_obj->is_inactive_status($member->status);
<span class="<% $inactive ? 'ticket-inactive' : '' %>">
<%$member->id%>: (<%$member->owner_obj->name%>) <%$member->subject%> [<% _($member->status) %>]
Modified: rt/branches/3.999-DANGEROUS/share/html/Elements/ShowSearch
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Elements/ShowSearch (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Elements/ShowSearch Wed Jul 16 04:21:29 2008
@@ -124,7 +124,7 @@
$_->{'rows'} = 999;
my $bookmarks = Jifty->web->current_user->user_object->firstAttribute('Bookmarks');
- $bookmarks = $bookmarks->Content if $bookmarks;
+ $bookmarks = $bookmarks->content if $bookmarks;
$bookmarks ||= {};
my $query = join(" OR ", map " id = '$_' ", grep $bookmarks->{ $_ }, keys %$bookmarks ) || 'id=0';
$_->{'query'} =~ s/__Bookmarks__/( $query )/g;
Modified: rt/branches/3.999-DANGEROUS/share/html/Elements/ShowUserConcise
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Elements/ShowUserConcise (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Elements/ShowUserConcise Wed Jul 16 04:21:29 2008
@@ -49,7 +49,7 @@
<%INIT>
if ($User) {
my $printable;
- if ( $User->Privileged ) {
+ if ( $User->privileged ) {
$printable = $User->real_name
|| $User->nickname
|| $User->name
Modified: rt/branches/3.999-DANGEROUS/share/html/Install/Basics.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Install/Basics.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Install/Basics.html Wed Jul 16 04:21:29 2008
@@ -55,7 +55,7 @@
<form method="post">
<& /Widgets/BulkEdit, Types => \@Types,Meta => $RT::Installer->{Meta},
- CurrentValue => RT::Installer->CurrentValues(@Types) &>
+ CurrentValue => RT::Installer->current_values(@Types) &>
<input type="hidden" name="Run" value="1">
<& /Elements/Submit, Label => loc('Next: ') . loc('Customize Email Configuration'),Back => 1, BackLabel => loc('Back: ' ) . loc( 'Customize Database Details') &>
Modified: rt/branches/3.999-DANGEROUS/share/html/Install/DatabaseDetails.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Install/DatabaseDetails.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Install/DatabaseDetails.html Wed Jul 16 04:21:29 2008
@@ -67,9 +67,9 @@
<form method="post">
<& /Widgets/BulkEdit, Types => \@Types, Meta => $RT::Installer->{Meta},
- CurrentValue => { %{RT::Installer->CurrentValues(@Types)},
+ CurrentValue => { %{RT::Installer->current_values(@Types)},
DatabaseAdmin =>
- RT::Installer->CurrentValue( 'DatabaseAdmin' ) ||
+ RT::Installer->current_value( 'DatabaseAdmin' ) ||
$RT::Installer->{InstallConfig}{DatabaseAdmin} ||
( $db_type eq 'mysql' ? 'root'
: $db_type eq 'Pg' ? 'postgres'
@@ -122,14 +122,14 @@
RT::Interface::Web::redirect(RT->config->get('WebURL') .
'Install/Basics.html');
}
- my ( $status, $msg ) = RT::Installer->SaveConfig;
+ my ( $status, $msg ) = RT::Installer->save_config;
if ( $status ) {
delete $INC{'RT_SiteConfig.pm'};
- RT->LoadConfig;
- RT::Handle->FinalizeDatabaseType();
+ RT->load_config;
+ RT::Handle->finalize_database_type();
# dba connect systemdsn
my $dbh = DBI->connect(
- RT::Handle->SystemDSN, $ARGS{DatabaseAdmin}, $ARGS{DatabaseAdminPassword}, { RaiseError => 0, PrintError => 0 },
+ RT::Handle->system_dsn, $ARGS{DatabaseAdmin}, $ARGS{DatabaseAdminPassword}, { RaiseError => 0, PrintError => 0 },
);
if ( $dbh ) {
Modified: rt/branches/3.999-DANGEROUS/share/html/Install/DatabaseType.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Install/DatabaseType.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Install/DatabaseType.html Wed Jul 16 04:21:29 2008
@@ -64,7 +64,7 @@
<form method="post">
<& /Widgets/BulkEdit, Types => \@Types, Meta => $RT::Installer->{Meta},
- CurrentValue => RT::Installer->CurrentValues(@Types) &>
+ CurrentValue => RT::Installer->current_values(@Types) &>
<input type="hidden" name="Run" value="1">
<& /Elements/Submit, Label => loc('Next: ') . loc( 'Check your database credentials') &>
Modified: rt/branches/3.999-DANGEROUS/share/html/Install/Finish.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Install/Finish.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Install/Finish.html Wed Jul 16 04:21:29 2008
@@ -61,7 +61,7 @@
</p>
<p>
-<&|/l, RT::Installer->ConfigFile &>The settings you've chosen are stored in %1. You can edit this file to refine your configuration further. You can prevent this installation wizard from being shown again by running `<tt>chmod -w '%1'</tt>`.</&>
+<&|/l, RT::Installer->config_file &>The settings you've chosen are stored in %1. You can edit this file to refine your configuration further. You can prevent this installation wizard from being shown again by running `<tt>chmod -w '%1'</tt>`.</&>
</p>
</div>
@@ -74,14 +74,14 @@
<%init>
if ( $Run ) {
RT->install_mode(0);
- RT->ConnectToDatabase();
- RT->InitSystemObjects();
- RT->InitClasses();
- RT->InitPlugins();
+ RT->connect_to_database();
+ RT->init_system_objects();
+ RT->init_classes();
+ RT->init_plugins();
my $root = RT::Model::User->new( RT->system_user );
- $root->Load('root');
- $root->SetPassword( $RT::Installer->{InstallConfig}{Password} );
+ $root->load('root');
+ $root->set_password( $RT::Installer->{InstallConfig}{Password} );
RT::Interface::Web::redirect(RT->config->get('WebURL'));
}
Modified: rt/branches/3.999-DANGEROUS/share/html/Install/Global.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Install/Global.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Install/Global.html Wed Jul 16 04:21:29 2008
@@ -56,7 +56,7 @@
<p><&|/l&>By default, RT will use the timezone of your system. This lets you set a global default for the display of dates and times in RT. Your users can choose a different Timezone in their preferences.</&></p>
<form method="post">
<& /Widgets/BulkEdit, Types => \@Types,Meta => $RT::Installer->{Meta},
- CurrentValue => RT::Installer->CurrentValues(@Types)
+ CurrentValue => RT::Installer->current_values(@Types)
&>
<input type="hidden" name="Run" value="1">
@@ -90,11 +90,11 @@
}
unless ( @errors ) {
- my ( $status, $msg ) = RT::Installer->SaveConfig;
+ my ( $status, $msg ) = RT::Installer->save_config;
if ( $status ) {
delete $INC{'RT_SiteConfig.pm'};
- RT->LoadConfig;
+ RT->load_config;
if ( $RT::Installer->{DatabaseAction} ne 'none' ) {
RT::Interface::Web::redirect(RT->config->get('WebURL') .
Modified: rt/branches/3.999-DANGEROUS/share/html/Install/Initialize.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Install/Initialize.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Install/Initialize.html Wed Jul 16 04:21:29 2008
@@ -72,7 +72,7 @@
my @actions = split /,/, $RT::Installer->{DatabaseAction};
my $sysdbh = DBI->connect(
- RT::Handle->SystemDSN,
+ RT::Handle->system_dsn,
$RT::Installer->{InstallConfig}{DatabaseAdmin},
$RT::Installer->{InstallConfig}{DatabaseAdminPassword},
{ RaiseError => 0, PrintError => 0 },
@@ -82,7 +82,7 @@
my ( $status, $msg ) = ( 1, '' );
if ( $actions[0] eq 'create' ) {
- ($status, $msg) = RT::Handle->CreateDatabase( $sysdbh );
+ ($status, $msg) = RT::Handle->create_database( $sysdbh );
unless ( $status ) {
push @errors, loc('ERROR: %1', $msg );
}
@@ -102,23 +102,23 @@
foreach my $action ( @actions ) {
($status, $msg) = (1, '');
if ( $action eq 'schema' ) {
- ($status, $msg) = RT::Handle->InsertSchema( $dbh );
+ ($status, $msg) = RT::Handle->insert_schema( $dbh );
}
elsif ( $action eq 'acl' ) {
- ($status, $msg) = RT::Handle->InsertACL( $dbh );
+ ($status, $msg) = RT::Handle->insert_acl( $dbh );
}
elsif ( $action eq 'coredata' ) {
$RT::Handle = new RT::Handle;
$RT::Handle->dbh( undef );
RT::ConnectToDatabase();
RT::InitLogging();
- ($status, $msg) = $RT::Handle->InsertInitialData;
+ ($status, $msg) = $RT::Handle->insert_initial_data;
}
elsif ( $action eq 'insert' ) {
$RT::Handle = new RT::Handle;
RT::Init();
my $file = $RT::EtcPath . "/initialdata";
- ($status, $msg) = $RT::Handle->InsertData( $file );
+ ($status, $msg) = $RT::Handle->insert_data( $file );
}
unless ( $status ) {
push @errors, loc('ERROR: %1', $msg);
Modified: rt/branches/3.999-DANGEROUS/share/html/Install/Sendmail.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Install/Sendmail.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Install/Sendmail.html Wed Jul 16 04:21:29 2008
@@ -55,7 +55,7 @@
<form method="post">
<& /Widgets/BulkEdit, Types => \@Types,Meta => $RT::Installer->{Meta},
- CurrentValue => RT::Installer->CurrentValues(@Types)
+ CurrentValue => RT::Installer->current_values(@Types)
&>
<input type="hidden" name="Run" value="1">
Modified: rt/branches/3.999-DANGEROUS/share/html/Install/autohandler
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Install/autohandler (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Install/autohandler Wed Jul 16 04:21:29 2008
@@ -56,7 +56,7 @@
require RT::Installer;
$RT::Installer->{'CurrentUser'} = RT::CurrentUser->new();
- $RT::Installer->{Meta} = RT::Installer->Meta;
+ $RT::Installer->{Meta} = RT::Installer->meta;
$m->call_next;
}
else {
Modified: rt/branches/3.999-DANGEROUS/share/html/NoAuth/iCal/dhandler
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/NoAuth/iCal/dhandler (original)
+++ rt/branches/3.999-DANGEROUS/share/html/NoAuth/iCal/dhandler Wed Jul 16 04:21:29 2008
@@ -66,15 +66,15 @@
$_ = Encode::decode_utf8( $_ ) for $name, $search;
my $user = RT::Model::User->new( RT->system_user );
-$user->Load( $name );
+$user->load( $name );
$notfound->() unless $user->id;
-$notfound->() unless $user->ValidateAuthString( $auth, $search );
+$notfound->() unless $user->validate_auth_string( $auth, $search );
my $cu = RT::CurrentUser->new;
-$cu->Load($user);
+$cu->load($user);
my $tickets = RT::Model::TicketCollection->new( $cu );
-$tickets->FromSQL($search);
+$tickets->from_sql($search);
$r->header_out("Content-Type" => "text/calendar; charset=utf-8");
@@ -98,16 +98,16 @@
organizer => $t->owner_obj->name,
dtstamp => $now->iCal,
created => $t->created_obj->iCal,
- 'last-modified' => $t->LastUpdatedObj->iCal,
+ 'last-modified' => $t->last_updated_obj->iCal,
) for $start, $end;
$start->add_properties(
- summary => "Start: ".$t->Subject,
+ summary => "Start: ".$t->subject,
dtstart => $starttime->iCalDate,
dtend => $starttime->iCalDate,
);
$end->add_properties(
- summary => "Due: ".$t->Subject,
+ summary => "Due: ".$t->subject,
dtstart => $t->due_obj->iCalDate,
dtend => $t->due_obj->iCalDate,
);
Modified: rt/branches/3.999-DANGEROUS/share/html/Search/Elements/EditSearches
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Search/Elements/EditSearches (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Search/Elements/EditSearches Wed Jul 16 04:21:29 2008
@@ -161,7 +161,7 @@
$SavedSearch->{'id'} = $ARGS{'SavedSearchLoad'};
$SavedSearch->{'object'} = $search;
$SavedSearch->{'description'} = $search->description;
- $query->{$_} = $search->SubValue($_) foreach @SearchFields;
+ $query->{$_} = $search->sub_value($_) foreach @SearchFields;
if ( $ARGS{'SavedSearchRevert'} ) {
push @results, _('Loaded original "%1" saved search', $SavedSearch->{'description'} );
@@ -183,7 +183,7 @@
}
elsif ( $ARGS{'SavedSearchCopy'} ) {
my ($container, $id ) = _parse_saved_search( $ARGS{'SavedSearchid'} );
- $SavedSearch->{'object'} = $container->attributes->Withid( $id );
+ $SavedSearch->{'object'} = $container->attributes->withid( $id );
if ( $ARGS{'saved_search_description'} && $ARGS{'saved_search_description'} ne $SavedSearch->{'object'}->description ) {
$SavedSearch->{'description'} = $ARGS{'saved_search_description'};
} else {
Modified: rt/branches/3.999-DANGEROUS/share/html/Search/Elements/ResultViews
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Search/Elements/ResultViews (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Search/Elements/ResultViews Wed Jul 16 04:21:29 2008
@@ -73,6 +73,6 @@
<%init>
my $ical_path = join '/', map $m->interp->apply_escapes($_, 'u'),
Jifty->web->current_user->user_object->name,
- Jifty->web->current_user->user_object->GenerateAuthString( $Query ),
+ Jifty->web->current_user->user_object->generate_auth_string( $Query ),
$Query;
</%init>
Modified: rt/branches/3.999-DANGEROUS/share/html/Ticket/Create.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Ticket/Create.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Ticket/Create.html Wed Jul 16 04:21:29 2008
@@ -281,24 +281,24 @@
if (0) { # Temporarily disabled
my $depends = $cloneticket_obj->depends_on;
while ( my $depend = $depends->next ) {
- push @depends, $depend->Localtarget;
+ push @depends, $depend->localtarget;
}
$clone->{'new-DependsOn'} = join ' ', @depends;
my $depends_by = $cloneticket_obj->depended_on_by;
while ( my $depend_by = $depends_by->next ) {
- push @depends_by, $depend_by->LocalBase;
+ push @depends_by, $depend_by->local_base;
}
$clone->{'DependsOn-new'} = join ' ', @depends_by;
while ( my $member = $members->next ) {
- push @members, $member->LocalBase;
+ push @members, $member->local_base;
}
$clone->{'MemberOf-new'} = join ' ', @members;
- my $members_of = $cloneticket_obj->MemberOf;
+ my $members_of = $cloneticket_obj->member_of;
while ( my $member_of = $members_of->next ) {
- push @members_of, $member_of->Localtarget;
+ push @members_of, $member_of->localtarget;
}
$clone->{'new-MemberOf'} = join ' ', @members_of;
Modified: rt/branches/3.999-DANGEROUS/share/html/Ticket/Display.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Ticket/Display.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Ticket/Display.html Wed Jul 16 04:21:29 2008
@@ -196,7 +196,7 @@
my %link_rel;
if (defined $session{'tickets'} and ($ARGS{'Query'} or $session{'CurrentSearchHash'}->{'Query'})) {
- my $item_map = $session{'tickets'}->ItemMap;
+ my $item_map = $session{'tickets'}->item_map;
$link_rel{first} = "Ticket/Display.html?id=" . $item_map->{first} if $item_map->{$ticket_obj->id}{prev};
$link_rel{prev} = "Ticket/Display.html?id=" . $item_map->{$ticket_obj->id}{prev} if $item_map->{$ticket_obj->id}{prev};
$link_rel{next} = "Ticket/Display.html?id=" . $item_map->{$ticket_obj->id}{next} if $item_map->{$ticket_obj->id}{next};
Modified: rt/branches/3.999-DANGEROUS/share/html/Ticket/Elements/PreviewScrips
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Ticket/Elements/PreviewScrips (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Ticket/Elements/PreviewScrips Wed Jul 16 04:21:29 2008
@@ -57,7 +57,7 @@
</%init>
<h2><&|/l&>This message will be sent to...</&></h2>
-% if ( $object and $object->Scrips ) {
+% if ( $object and $object->scrips ) {
<i><&|/l&>(Check boxes to disable notifications to the listed recipients)</&></i><br />
% foreach my $scrip (@{$object->scrips->prepared}) {
Modified: rt/branches/3.999-DANGEROUS/share/html/Ticket/Elements/Tabs
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Ticket/Elements/Tabs (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Ticket/Elements/Tabs Wed Jul 16 04:21:29 2008
@@ -71,7 +71,7 @@
if ($updatesession) {
$session{'i'}++;
- $session{'tickets'}->PrepForSerialization();
+ $session{'tickets'}->prep_for_serialization();
}
# Don't display prev links if we're on the first ticket
Modified: rt/branches/3.999-DANGEROUS/share/html/Ticket/Elements/UpdateCc
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Ticket/Elements/UpdateCc (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Ticket/Elements/UpdateCc Wed Jul 16 04:21:29 2008
@@ -77,5 +77,5 @@
</%args>
<%init>
my %txn_addresses = %{$ticket_obj->transaction_addresses};
-my @req_addresses = split /,/, $ticket_obj->RequestorAddresses;
+my @req_addresses = split /,/, $ticket_obj->requestor_addresses;
</%init>
Modified: rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/Elements/EditGraphProperties
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/Elements/EditGraphProperties (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/Elements/EditGraphProperties Wed Jul 16 04:21:29 2008
@@ -76,7 +76,7 @@
% }
<br />
-% my @properties = RT::Graph::Tickets->TicketProperties( current_user => Jifty->web->current_user );
+% my @properties = RT::Graph::Tickets->ticket_properties( current_user => Jifty->web->current_user );
Fill boxes with color using:
<select name="FillUsing">
Modified: rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/Elements/ShowGraph
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/Elements/ShowGraph (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/Elements/ShowGraph Wed Jul 16 04:21:29 2008
@@ -56,7 +56,7 @@
use RT::Util 'safe_run_child';
my $ticket = RT::Model::Ticket->new( current_user => Jifty->web->current_user );
-$ticket->Load( $id );
+$ticket->load( $id );
unless ( $ticket->id ) {
Jifty->log->error("Couldn't load ticket $id");
return;
@@ -64,7 +64,7 @@
$ARGS{'id'} = $id = $ticket->id;
require RT::Graph::Tickets;
-my $graph = RT::Graph::Tickets->TicketLinks(
+my $graph = RT::Graph::Tickets->ticket_links(
%ARGS,
Ticket => $ticket,
);
Modified: rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/dhandler
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/dhandler (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Ticket/Graphs/dhandler Wed Jul 16 04:21:29 2008
@@ -56,14 +56,14 @@
}
my $ticket = RT::Model::Ticket->new( current_user => Jifty->web->current_user );
-$ticket->Load( $id );
+$ticket->load( $id );
unless ( $ticket->id ) {
Jifty->log->error("Couldn't load ticket #$id");
return $m->abort( 404 );
}
require RT::Graph::Tickets;
-my $graph = RT::Graph::Tickets->TicketLinks(
+my $graph = RT::Graph::Tickets->ticket_links(
%ARGS,
Ticket => $ticket,
);
Modified: rt/branches/3.999-DANGEROUS/share/html/Ticket/Update.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/Ticket/Update.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/Ticket/Update.html Wed Jul 16 04:21:29 2008
@@ -93,7 +93,7 @@
% }
</select>
</td></tr>
-<tr><td class="label"><&|/l&>Subject</&>:</td><td> <input name="UpdateSubject" size="60" value="<% $ARGS{UpdateSubject} || $ticket_obj->Subject()%>" /></td></tr>
+<tr><td class="label"><&|/l&>Subject</&>:</td><td> <input name="UpdateSubject" size="60" value="<% $ARGS{UpdateSubject} || $ticket_obj->subject()%>" /></td></tr>
<& /Ticket/Elements/UpdateCc, %ARGS, ticket_obj => $ticket_obj &>
Modified: rt/branches/3.999-DANGEROUS/share/html/User/Prefs.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/html/User/Prefs.html (original)
+++ rt/branches/3.999-DANGEROUS/share/html/User/Prefs.html Wed Jul 16 04:21:29 2008
@@ -137,11 +137,11 @@
</tr>
<tr>
<td class="label"><&|/l&>Address1</&>:</td>
- <td class="value"><input name="Address1" value="<%$user_object->Address1 || ''%>" /></td>
+ <td class="value"><input name="Address1" value="<%$user_object->address1 || ''%>" /></td>
</tr>
<tr>
<td class="label"><&|/l&>Address2</&>:</td>
- <td class="value"><input name="Address2" value="<%$user_object->Address2 || ''%>" /></td>
+ <td class="value"><input name="Address2" value="<%$user_object->address2 || ''%>" /></td>
</tr>
<tr>
<td class="label"><&|/l&>City</&>:</td>
@@ -249,7 +249,7 @@
}
if ( $ARGS{'ResetAuthToken'} ) {
- my ($status, $msg) = $user_object->GenerateAuthToken;
+ my ($status, $msg) = $user_object->generate_auth_token;
push @results, $msg;
}
}
Modified: rt/branches/3.999-DANGEROUS/t/api/date.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/api/date.t (original)
+++ rt/branches/3.999-DANGEROUS/t/api/date.t Wed Jul 16 04:21:29 2008
@@ -392,7 +392,7 @@
# TODO: {
# local $TODO = "BUG or subject to change Date handling to support unix time <= 0";
# $date->unix(0);
-# $date->AddSeconds(-2);
+# $date->add_seconds(-2);
# ok($date->unix > 0);
# }
Modified: rt/branches/3.999-DANGEROUS/t/ticket/search.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/ticket/search.t (original)
+++ rt/branches/3.999-DANGEROUS/t/ticket/search.t Wed Jul 16 04:21:29 2008
@@ -141,7 +141,7 @@
my $tix = RT::Model::TicketCollection->new(current_user => RT->system_user);
$tix->from_sql("Queue = '$queue'");
is($tix->count, 7, "found all the tickets")
- or diag "wrong results from SQL:\n". $tix->BuildSelectcountQuery;
+ or diag "wrong results from SQL:\n". $tix->build_selectcount_query;
# very simple searches. both CF and normal
@@ -149,73 +149,73 @@
$tix = RT::Model::TicketCollection->new(current_user => RT->system_user);
$tix->from_sql("Queue = '$queue' AND CF.SearchTest = 'foo1'");
is($tix->count, 1, "matched identical subject")
- or diag "wrong results from SQL:\n". $tix->BuildSelectcountQuery;
+ or diag "wrong results from SQL:\n". $tix->build_selectcount_query;
$tix = RT::Model::TicketCollection->new(current_user => RT->system_user);
$tix->from_sql("Queue = '$queue' AND CF.SearchTest LIKE 'foo1'");
is($tix->count, 1, "matched LIKE subject")
- or diag "wrong results from SQL:\n". $tix->BuildSelectcountQuery;
+ or diag "wrong results from SQL:\n". $tix->build_selectcount_query;
$tix = RT::Model::TicketCollection->new(current_user => RT->system_user);
$tix->from_sql("Queue = '$queue' AND CF.SearchTest = 'foo'");
is($tix->count, 0, "IS a regexp match")
- or diag "wrong results from SQL:\n". $tix->BuildSelectcountQuery;
+ or diag "wrong results from SQL:\n". $tix->build_selectcount_query;
$tix = RT::Model::TicketCollection->new(current_user => RT->system_user);
$tix->from_sql("Queue = '$queue' AND CF.SearchTest LIKE 'foo'");
is($tix->count, 5, "matched LIKE subject")
- or diag "wrong results from SQL:\n". $tix->BuildSelectcountQuery;
+ or diag "wrong results from SQL:\n". $tix->build_selectcount_query;
$tix = RT::Model::TicketCollection->new(current_user => RT->system_user);
$tix->from_sql("Queue = '$queue' AND CF.SearchTest IS NULL");
is($tix->count, 2, "IS null CF")
- or diag "wrong results from SQL:\n". $tix->BuildSelectcountQuery;
+ or diag "wrong results from SQL:\n". $tix->build_selectcount_query;
$tix = RT::Model::TicketCollection->new(current_user => RT->system_user);
$tix->from_sql("Queue = '$queue' AND Requestors LIKE 'search1'");
is($tix->count, 1, "LIKE requestor")
- or diag "wrong results from SQL:\n". $tix->BuildSelectcountQuery;
+ or diag "wrong results from SQL:\n". $tix->build_selectcount_query;
$tix = RT::Model::TicketCollection->new(current_user => RT->system_user);
$tix->from_sql("Queue = '$queue' AND Requestors = 'search1\@example.com'");
is($tix->count, 1, "IS requestor")
- or diag "wrong results from SQL:\n". $tix->BuildSelectcountQuery;
+ or diag "wrong results from SQL:\n". $tix->build_selectcount_query;
$tix = RT::Model::TicketCollection->new(current_user => RT->system_user);
$tix->from_sql("Queue = '$queue' AND Requestors LIKE 'search'");
is($tix->count, 6, "LIKE requestor")
- or diag "wrong results from SQL:\n". $tix->BuildSelectcountQuery;
+ or diag "wrong results from SQL:\n". $tix->build_selectcount_query;
$tix = RT::Model::TicketCollection->new(current_user => RT->system_user);
$tix->from_sql("Queue = '$queue' AND Requestors IS NULL");
is($tix->count, 1, "Search for no requestor")
- or diag "wrong results from SQL:\n". $tix->BuildSelectcountQuery;
+ or diag "wrong results from SQL:\n". $tix->build_selectcount_query;
$tix = RT::Model::TicketCollection->new(current_user => RT->system_user);
$tix->from_sql("Queue = '$queue' AND subject = 'SearchTest1'");
is($tix->count, 1, "IS subject")
- or diag "wrong results from SQL:\n". $tix->BuildSelectcountQuery;
+ or diag "wrong results from SQL:\n". $tix->build_selectcount_query;
$tix = RT::Model::TicketCollection->new(current_user => RT->system_user);
$tix->from_sql("Queue = '$queue' AND subject LIKE 'SearchTest1'");
is($tix->count, 1, "LIKE subject")
- or diag "wrong results from SQL:\n". $tix->BuildSelectcountQuery;
+ or diag "wrong results from SQL:\n". $tix->build_selectcount_query;
$tix = RT::Model::TicketCollection->new(current_user => RT->system_user);
$tix->from_sql("Queue = '$queue' AND subject = ''");
is($tix->count, 1, "found one ticket")
- or diag "wrong results from SQL:\n". $tix->BuildSelectcountQuery;
+ or diag "wrong results from SQL:\n". $tix->build_selectcount_query;
$tix = RT::Model::TicketCollection->new(current_user => RT->system_user);
$tix->from_sql("Queue = '$queue' AND subject LIKE 'SearchTest'");
is($tix->count, 6, "found two ticket")
- or diag "wrong results from SQL:\n". $tix->BuildSelectcountQuery;
+ or diag "wrong results from SQL:\n". $tix->build_selectcount_query;
$tix = RT::Model::TicketCollection->new(current_user => RT->system_user);
$tix->from_sql("Queue = '$queue' AND subject LIKE 'qwerty'");
is($tix->count, 0, "found zero ticket")
- or diag "wrong results from SQL:\n". $tix->BuildSelectcountQuery;
+ or diag "wrong results from SQL:\n". $tix->build_selectcount_query;
Modified: rt/branches/3.999-DANGEROUS/temp_refactoring_tools/lower_method_calls.pl
==============================================================================
--- rt/branches/3.999-DANGEROUS/temp_refactoring_tools/lower_method_calls.pl (original)
+++ rt/branches/3.999-DANGEROUS/temp_refactoring_tools/lower_method_calls.pl Wed Jul 16 04:21:29 2008
@@ -3,7 +3,7 @@
use strict;
use warnings;
-# lowers ->CamelCase
+# lowers ->camel_case
# find lib/ -type f | xargs perl -i -n temp_refactoring_tools/lower_method_calls.pl
my %bad = map { $_ => 1 } qw(
More information about the Rt-commit
mailing list