[Rt-commit] r14271 - in rt/branches/3.999-DANGEROUS: . bin lib/RT lib/RT/Model t/web

[sunnavy at bestpractical.com]

Author: sunnavy
Date: Fri Jul 18 12:25:09 2008
New Revision: 14271

Modified:
   rt/branches/3.999-DANGEROUS/   (props changed)
   rt/branches/3.999-DANGEROUS/bin/rt-crontool
   rt/branches/3.999-DANGEROUS/lib/RT/Bootstrap.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Model/User.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Test.pm
   rt/branches/3.999-DANGEROUS/t/ticket/link_search.t
   rt/branches/3.999-DANGEROUS/t/web/gnupg-select-keys-on-update.t

Log:
 r14694 at sunnavys-mb:  sunnavy | 2008-07-18 21:24:16 +0800
 no $RT::system_user


Modified: rt/branches/3.999-DANGEROUS/bin/rt-crontool
==============================================================================
--- rt/branches/3.999-DANGEROUS/bin/rt-crontool	(original)
+++ rt/branches/3.999-DANGEROUS/bin/rt-crontool	Fri Jul 18 12:25:09 2008
@@ -65,7 +65,7 @@
 # Load the config file
 RT::load_config();
 
-#Connect to the database and get RT::system_user and RT::nobody loaded
+#Connect to the database and get RT->system_user and RT::nobody loaded
 RT::Init();
 
 #Get the current user all loaded

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Bootstrap.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Bootstrap.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Bootstrap.pm	Fri Jul 18 12:25:09 2008
@@ -227,7 +227,6 @@
 
         #print "Creating groups...";
         #print "My systemuser is ".RT->system_user ."\n";
-        $RT::system_user = RT::CurrentUser->new( name => 'RT_System' );
         foreach my $item (@Groups) {
             my $new_entry = RT::Model::Group->new( current_user => RT->system_user );
             my $member_of = delete $item->{'member_of'};

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm	Fri Jul 18 12:25:09 2008
@@ -355,6 +355,7 @@
     }
 
     #Now that we have a queue, Check the ACLS
+            die caller unless $self->current_user->id;
     unless (
         $self->current_user->has_right(
             right  => 'CreateTicket',

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/User.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/User.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/User.pm	Fri Jul 18 12:25:09 2008
@@ -205,7 +205,7 @@
     }
 
     #SANITY CHECK THE name AND ABORT IF IT'S TAKEN
-    if ( RT->system_user ) {    #This only works if RT::system_user has been defined
+    if ( RT->system_user ) {    #This only works if RT->system_user has been defined
         my $TempUser = RT::Model::User->new( current_user => RT->system_user );
         $TempUser->load( $args{'name'} );
         return ( 0, _('name in use') ) if ( $TempUser->id );

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Test.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Test.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Test.pm	Fri Jul 18 12:25:09 2008
@@ -212,7 +212,7 @@
 
     # add new user to groups
     foreach (@$MemberOf) {
-        my $group = RT::Model::Group->new( current_user => RT::system_user() );
+        my $group = RT::Model::Group->new( current_user => RT->system_user() );
         $group->load_user_defined_group($_);
         die "couldn't load group '$_'" unless $group->id;
         $group->add_member( $obj->id );

Modified: rt/branches/3.999-DANGEROUS/t/ticket/link_search.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/ticket/link_search.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/ticket/link_search.t	Fri Jul 18 12:25:09 2008
@@ -6,7 +6,7 @@
 # Load the config file
 
 
-#Connect to the database and get RT::system_user and RT::nobody loaded
+#Connect to the database and get RT->system_user and RT::nobody loaded
 
 
 #Get the current user all loaded

Modified: rt/branches/3.999-DANGEROUS/t/web/gnupg-select-keys-on-update.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/web/gnupg-select-keys-on-update.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/web/gnupg-select-keys-on-update.t	Fri Jul 18 12:25:09 2008
@@ -54,7 +54,7 @@
 
 my $tid;
 {
-    my $ticket = RT::Model::Ticket->new(current_user => $RT::system_user );
+    my $ticket = RT::Model::Ticket->new(current_user => RT->system_user );
     ($tid) = $ticket->create(
         subject   => 'test',
         queue     => $queue->id,