[Rt-commit] r14677 - rt/3.8/trunk/lib/RT/Interface/Web

ruz at bestpractical.com ruz at bestpractical.com
Wed Jul 30 17:54:12 EDT 2008


Author: ruz
Date: Wed Jul 30 17:54:12 2008
New Revision: 14677

Modified:
   rt/3.8/trunk/lib/RT/Interface/Web/Request.pm

Log:
* somehow undefs end up in callbacks cache, let's filter them out
  as we can not reproduce it and users see it often, but not 100%
  reproducible

Modified: rt/3.8/trunk/lib/RT/Interface/Web/Request.pm
==============================================================================
--- rt/3.8/trunk/lib/RT/Interface/Web/Request.pm	(original)
+++ rt/3.8/trunk/lib/RT/Interface/Web/Request.pm	Wed Jul 30 17:54:12 2008
@@ -172,7 +172,9 @@
     }
 
     my @rv;
-    push @rv, scalar $self->comp( $_, %args ) foreach @$callbacks;
+    # we don't know why but we have to filter undefs as they end up in the list
+    push @rv, scalar $self->comp( $_, %args )
+        foreach grep defined && length, @$callbacks;
     return @rv;
 }
 }


More information about the Rt-commit mailing list