[Rt-commit] r13038 - rt/branches/3.6-RELEASE/lib/RT

ruz at bestpractical.com ruz at bestpractical.com
Mon Jun 9 06:44:26 EDT 2008


Author: ruz
Date: Mon Jun  9 06:44:10 2008
New Revision: 13038

Modified:
   rt/branches/3.6-RELEASE/lib/RT/Tickets_Overlay.pm

Log:
* delete duplicated code, I don't know how that end up here,
  but we were double checking rights and deleted status

Modified: rt/branches/3.6-RELEASE/lib/RT/Tickets_Overlay.pm
==============================================================================
--- rt/branches/3.6-RELEASE/lib/RT/Tickets_Overlay.pm	(original)
+++ rt/branches/3.6-RELEASE/lib/RT/Tickets_Overlay.pm	Mon Jun  9 06:44:10 2008
@@ -2764,20 +2764,6 @@
             return ($Ticket);
         }
 
-        if ( $Ticket->__Value('Status') eq 'deleted' ) {
-            return ( $self->Next() );
-        }
-
-        # Since Ticket could be granted with more rights instead
-        # of being revoked, it's ok if queue rights allow
-        # ShowTicket.  It seems need another query, but we have
-        # rights cache in Principal::HasRight.
-        elsif ($Ticket->QueueObj->CurrentUserHasRight('ShowTicket')
-            || $Ticket->CurrentUserHasRight('ShowTicket') )
-        {
-            return ($Ticket);
-        }
-
         #If the user doesn't have the right to show this ticket
         else {
             return ( $self->Next() );


More information about the Rt-commit mailing list