[Rt-commit] r13246 - in rt/branches/3.8-TESTING: . lib/RT lib/RT/Action lib/RT/I18N lib/RT/Interface lib/RT/URI
sartak at bestpractical.com
sartak at bestpractical.com
Thu Jun 12 19:31:21 EDT 2008
Author: sartak
Date: Thu Jun 12 19:31:21 2008
New Revision: 13246
Modified:
rt/branches/3.8-TESTING/ (props changed)
rt/branches/3.8-TESTING/lib/RT/ACE.pm
rt/branches/3.8-TESTING/lib/RT/ACL.pm
rt/branches/3.8-TESTING/lib/RT/Action/CreateTickets.pm
rt/branches/3.8-TESTING/lib/RT/Action/EscalatePriority.pm
rt/branches/3.8-TESTING/lib/RT/Action/ExtractSubjectTag.pm
rt/branches/3.8-TESTING/lib/RT/Action/RecordComment.pm
rt/branches/3.8-TESTING/lib/RT/Action/RecordCorrespondence.pm
rt/branches/3.8-TESTING/lib/RT/Action/ResolveMembers.pm
rt/branches/3.8-TESTING/lib/RT/Action/SendEmail.pm
rt/branches/3.8-TESTING/lib/RT/Action/SetPriority.pm
rt/branches/3.8-TESTING/lib/RT/Action/UserDefined.pm
rt/branches/3.8-TESTING/lib/RT/Condition/AnyTransaction.pm
rt/branches/3.8-TESTING/lib/RT/Condition/BeforeDue.pm
rt/branches/3.8-TESTING/lib/RT/Condition/Overdue.pm
rt/branches/3.8-TESTING/lib/RT/Condition/OwnerChange.pm
rt/branches/3.8-TESTING/lib/RT/Condition/PriorityChange.pm
rt/branches/3.8-TESTING/lib/RT/Condition/PriorityExceeds.pm
rt/branches/3.8-TESTING/lib/RT/Condition/QueueChange.pm
rt/branches/3.8-TESTING/lib/RT/Condition/StatusChange.pm
rt/branches/3.8-TESTING/lib/RT/Condition/UserDefined.pm
rt/branches/3.8-TESTING/lib/RT/I18N/i_default.pm
rt/branches/3.8-TESTING/lib/RT/Interface/CLI.pm
rt/branches/3.8-TESTING/lib/RT/Interface/Email.pm
rt/branches/3.8-TESTING/lib/RT/Interface/REST.pm
rt/branches/3.8-TESTING/lib/RT/Record.pm
rt/branches/3.8-TESTING/lib/RT/URI.pm
rt/branches/3.8-TESTING/lib/RT/URI/fsck_com_rt.pm
rt/branches/3.8-TESTING/lib/RT/URI/t.pm
Log:
r62315 at onn: sartak | 2008-06-12 19:30:25 -0400
use base 'foo' instead of: use foo; use vars @ISA; @ISA = 'foo'
Modified: rt/branches/3.8-TESTING/lib/RT/ACE.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/ACE.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/ACE.pm Thu Jun 12 19:31:21 2008
@@ -69,11 +69,7 @@
=cut
package RT::ACE;
-use RT::Record;
-
-
-use vars qw( @ISA );
- at ISA= qw( RT::Record );
+use base 'RT::Record';
sub _Init {
my $self = shift;
Modified: rt/branches/3.8-TESTING/lib/RT/ACL.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/ACL.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/ACL.pm Thu Jun 12 19:31:21 2008
@@ -72,12 +72,9 @@
package RT::ACL;
-use RT::SearchBuilder;
+use base 'RT::SearchBuilder';
use RT::ACE;
-use vars qw( @ISA );
- at ISA= qw(RT::SearchBuilder);
-
sub _Init {
my $self = shift;
Modified: rt/branches/3.8-TESTING/lib/RT/Action/CreateTickets.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Action/CreateTickets.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Action/CreateTickets.pm Thu Jun 12 19:31:21 2008
@@ -47,12 +47,10 @@
# END BPS TAGGED BLOCK }}}
package RT::Action::CreateTickets;
-require RT::Action;
+use base 'RT::Action';
use strict;
use warnings;
-use vars qw/@ISA/;
- at ISA = qw(RT::Action);
use MIME::Entity;
Modified: rt/branches/3.8-TESTING/lib/RT/Action/EscalatePriority.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Action/EscalatePriority.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Action/EscalatePriority.pm Thu Jun 12 19:31:21 2008
@@ -72,11 +72,9 @@
package RT::Action::EscalatePriority;
-require RT::Action;
+use base 'RT::Action';
use strict;
-use vars qw/@ISA/;
- at ISA=qw(RT::Action);
#Do what we need to do and send it out.
Modified: rt/branches/3.8-TESTING/lib/RT/Action/ExtractSubjectTag.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Action/ExtractSubjectTag.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Action/ExtractSubjectTag.pm Thu Jun 12 19:31:21 2008
@@ -47,11 +47,8 @@
# END BPS TAGGED BLOCK }}}
package RT::Action::ExtractSubjectTag;
-require RT::Action;
-
+use base 'RT::Action';
use strict;
-use vars qw/@ISA/;
- at ISA = qw(RT::Action);
sub Describe {
my $self = shift;
Modified: rt/branches/3.8-TESTING/lib/RT/Action/RecordComment.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Action/RecordComment.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Action/RecordComment.pm Thu Jun 12 19:31:21 2008
@@ -47,10 +47,8 @@
# END BPS TAGGED BLOCK }}}
package RT::Action::RecordComment;
-require RT::Action;
+use base 'RT::Action';
use strict;
-use vars qw/@ISA/;
- at ISA = qw(RT::Action);
=head1 NAME
Modified: rt/branches/3.8-TESTING/lib/RT/Action/RecordCorrespondence.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Action/RecordCorrespondence.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Action/RecordCorrespondence.pm Thu Jun 12 19:31:21 2008
@@ -47,10 +47,8 @@
# END BPS TAGGED BLOCK }}}
package RT::Action::RecordCorrespondence;
-require RT::Action;
+use base 'RT::Action';
use strict;
-use vars qw/@ISA/;
- at ISA = qw(RT::Action);
=head1 NAME
Modified: rt/branches/3.8-TESTING/lib/RT/Action/ResolveMembers.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Action/ResolveMembers.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Action/ResolveMembers.pm Thu Jun 12 19:31:21 2008
@@ -49,12 +49,10 @@
# This Action will resolve all members of a resolved group ticket
package RT::Action::ResolveMembers;
-require RT::Action;
+use base 'RT::Action';
require RT::Links;
use strict;
-use vars qw/@ISA/;
- at ISA=qw(RT::Action);
#Do what we need to do and send it out.
Modified: rt/branches/3.8-TESTING/lib/RT/Action/SendEmail.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Action/SendEmail.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Action/SendEmail.pm Thu Jun 12 19:31:21 2008
@@ -71,9 +71,7 @@
=head1 SYNOPSIS
- require RT::Action::SendEmail;
- @ISA = qw(RT::Action::SendEmail);
-
+ use base 'RT::Action::SendEmail';
=head1 DESCRIPTION
Modified: rt/branches/3.8-TESTING/lib/RT/Action/SetPriority.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Action/SetPriority.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Action/SetPriority.pm Thu Jun 12 19:31:21 2008
@@ -47,11 +47,9 @@
# END BPS TAGGED BLOCK }}}
package RT::Action::SetPriority;
-require RT::Action;
+use base 'RT::Action';
use strict;
-use vars qw/@ISA/;
- at ISA=qw(RT::Action);
#Do what we need to do and send it out.
Modified: rt/branches/3.8-TESTING/lib/RT/Action/UserDefined.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Action/UserDefined.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Action/UserDefined.pm Thu Jun 12 19:31:21 2008
@@ -47,11 +47,9 @@
# END BPS TAGGED BLOCK }}}
package RT::Action::UserDefined;
-use RT::Action;
+use base 'RT::Action';
use strict;
-use vars qw/@ISA/;
- at ISA = qw(RT::Action);
=head2 Prepare
Modified: rt/branches/3.8-TESTING/lib/RT/Condition/AnyTransaction.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Condition/AnyTransaction.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Condition/AnyTransaction.pm Thu Jun 12 19:31:21 2008
@@ -47,11 +47,9 @@
# END BPS TAGGED BLOCK }}}
package RT::Condition::AnyTransaction;
-require RT::Condition;
+use base 'RT::Condition';
use strict;
-use vars qw/@ISA/;
- at ISA = qw(RT::Condition);
=head2 IsApplicable
Modified: rt/branches/3.8-TESTING/lib/RT/Condition/BeforeDue.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Condition/BeforeDue.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Condition/BeforeDue.pm Thu Jun 12 19:31:21 2008
@@ -47,14 +47,11 @@
# END BPS TAGGED BLOCK }}}
package RT::Condition::BeforeDue;
-require RT::Condition;
+use base 'RT::Condition';
use RT::Date;
use strict;
-use vars qw/@ISA/;
- at ISA = qw(RT::Condition);
-
sub IsApplicable {
my $self = shift;
Modified: rt/branches/3.8-TESTING/lib/RT/Condition/Overdue.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Condition/Overdue.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Condition/Overdue.pm Thu Jun 12 19:31:21 2008
@@ -57,11 +57,8 @@
=cut
package RT::Condition::Overdue;
-require RT::Condition;
-
+use base 'RT::Condition';
use strict;
-use vars qw/@ISA/;
- at ISA = qw(RT::Condition);
=head2 IsApplicable
Modified: rt/branches/3.8-TESTING/lib/RT/Condition/OwnerChange.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Condition/OwnerChange.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Condition/OwnerChange.pm Thu Jun 12 19:31:21 2008
@@ -47,11 +47,8 @@
# END BPS TAGGED BLOCK }}}
package RT::Condition::OwnerChange;
-require RT::Condition;
-
+use base 'RT::Condition';
use strict;
-use vars qw/@ISA/;
- at ISA = qw(RT::Condition);
=head2 IsApplicable
Modified: rt/branches/3.8-TESTING/lib/RT/Condition/PriorityChange.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Condition/PriorityChange.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Condition/PriorityChange.pm Thu Jun 12 19:31:21 2008
@@ -47,11 +47,8 @@
# END BPS TAGGED BLOCK }}}
package RT::Condition::PriorityChange;
-require RT::Condition;
-
+use base 'RT::Condition';
use strict;
-use vars qw/@ISA/;
- at ISA = qw(RT::Condition);
=head2 IsApplicable
Modified: rt/branches/3.8-TESTING/lib/RT/Condition/PriorityExceeds.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Condition/PriorityExceeds.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Condition/PriorityExceeds.pm Thu Jun 12 19:31:21 2008
@@ -47,12 +47,8 @@
# END BPS TAGGED BLOCK }}}
package RT::Condition::PriorityExceeds;
-require RT::Condition;
-
+use base 'RT::Condition';
use strict;
-use vars qw/@ISA/;
- at ISA = qw(RT::Condition);
-
=head2 IsApplicable
Modified: rt/branches/3.8-TESTING/lib/RT/Condition/QueueChange.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Condition/QueueChange.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Condition/QueueChange.pm Thu Jun 12 19:31:21 2008
@@ -47,12 +47,8 @@
# END BPS TAGGED BLOCK }}}
package RT::Condition::QueueChange;
-require RT::Condition;
-
+use base 'RT::Condition';
use strict;
-use vars qw/@ISA/;
- at ISA = qw(RT::Condition);
-
=head2 IsApplicable
Modified: rt/branches/3.8-TESTING/lib/RT/Condition/StatusChange.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Condition/StatusChange.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Condition/StatusChange.pm Thu Jun 12 19:31:21 2008
@@ -47,11 +47,8 @@
# END BPS TAGGED BLOCK }}}
package RT::Condition::StatusChange;
-require RT::Condition;
-
+use base 'RT::Condition';
use strict;
-use vars qw/@ISA/;
- at ISA = qw(RT::Condition);
=head2 IsApplicable
Modified: rt/branches/3.8-TESTING/lib/RT/Condition/UserDefined.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Condition/UserDefined.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Condition/UserDefined.pm Thu Jun 12 19:31:21 2008
@@ -47,12 +47,8 @@
# END BPS TAGGED BLOCK }}}
package RT::Condition::UserDefined;
-
-use RT::Condition;
-
+use base 'RT::Condition';
use strict;
-use vars qw/@ISA/;
- at ISA = qw(RT::Condition);
=head2 IsApplicable
Modified: rt/branches/3.8-TESTING/lib/RT/I18N/i_default.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/I18N/i_default.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/I18N/i_default.pm Thu Jun 12 19:31:21 2008
@@ -47,10 +47,8 @@
# END BPS TAGGED BLOCK }}}
package RT::I18N::i_default;
-
+use base 'RT::I18N';
use strict;
-use vars qw/@ISA/;
- at ISA = qw(RT::I18N);
eval "require RT::I18N::i_default_Vendor";
die $@ if ($@ && $@ !~ qr{^Can't locate RT/I18N/i_default_Vendor.pm});
Modified: rt/branches/3.8-TESTING/lib/RT/Interface/CLI.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Interface/CLI.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Interface/CLI.pm Thu Jun 12 19:31:21 2008
@@ -54,14 +54,12 @@
BEGIN {
- use Exporter ();
- use vars qw ($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
+ use base 'Exporter';
+ use vars qw ($VERSION @EXPORT @EXPORT_OK %EXPORT_TAGS);
# set the version for version checking
$VERSION = do { my @r = (q$Revision: 1.2.2.1 $ =~ /\d+/g); sprintf "%d."."%02d" x $#r, @r }; # must be all one line, for MakeMaker
-
- @ISA = qw(Exporter);
-
+
# your exported package globals go here,
# as well as any optionally exported functions
@EXPORT_OK = qw(&CleanEnv
Modified: rt/branches/3.8-TESTING/lib/RT/Interface/Email.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Interface/Email.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Interface/Email.pm Thu Jun 12 19:31:21 2008
@@ -58,14 +58,12 @@
use UNIVERSAL::require;
BEGIN {
- use Exporter ();
- use vars qw ( @ISA @EXPORT_OK);
+ use base 'Exporter';
+ use vars qw ( @EXPORT_OK);
# set the version for version checking
our $VERSION = 2.0;
- @ISA = qw(Exporter);
-
# your exported package globals go here,
# as well as any optionally exported functions
@EXPORT_OK = qw(
Modified: rt/branches/3.8-TESTING/lib/RT/Interface/REST.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Interface/REST.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Interface/REST.pm Thu Jun 12 19:31:21 2008
@@ -54,12 +54,11 @@
use RT;
BEGIN {
- use Exporter ();
- use vars qw($VERSION @ISA @EXPORT);
+ use base 'Exporter';
+ use vars qw($VERSION @EXPORT);
$VERSION = do { my @r = (q$Revision: 1.00$ =~ /\d+/g); sprintf "%d."."%02d"x$#r, @r };
- @ISA = qw(Exporter);
@EXPORT = qw(expand_list form_parse form_compose vpush vsplit);
}
Modified: rt/branches/3.8-TESTING/lib/RT/Record.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Record.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/Record.pm Thu Jun 12 19:31:21 2008
@@ -73,8 +73,8 @@
our $_TABLE_ATTR = { };
-use RT::Base;
-our @ISA = qw(RT::Base);
+use base 'RT::Base';
+
my $base = 'DBIx::SearchBuilder::Record::Cachable';
if ( $RT::Config && $RT::Config->Get('DontCacheSearchBuilderRecords') ) {
$base = 'DBIx::SearchBuilder::Record';
Modified: rt/branches/3.8-TESTING/lib/RT/URI.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/URI.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/URI.pm Thu Jun 12 19:31:21 2008
@@ -46,11 +46,10 @@
#
# END BPS TAGGED BLOCK }}}
-package RT::URI;;
+package RT::URI;
use strict;
-use vars qw/@ISA/;
- at ISA = qw(RT::Base);
+use base 'RT::Base';
use RT::URI::base;
use Carp;
Modified: rt/branches/3.8-TESTING/lib/RT/URI/fsck_com_rt.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/URI/fsck_com_rt.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/URI/fsck_com_rt.pm Thu Jun 12 19:31:21 2008
@@ -50,11 +50,9 @@
use RT::Ticket;
-use RT::URI::base;
+use base 'RT::URI::base';
use strict;
-use vars qw(@ISA);
- at ISA = qw/RT::URI::base/;
Modified: rt/branches/3.8-TESTING/lib/RT/URI/t.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/URI/t.pm (original)
+++ rt/branches/3.8-TESTING/lib/RT/URI/t.pm Thu Jun 12 19:31:21 2008
@@ -75,8 +75,7 @@
use RT::URI::base;
use strict;
-use vars qw(@ISA);
- at ISA = qw/RT::URI::fsck_com_rt/;
+use base 'RT::URI::fsck_com_rt';
my $scheme = "t";
More information about the Rt-commit
mailing list