[Rt-commit] r13394 - in rt/3.8/trunk: . share/html/NoAuth/css/web2 share/html/Search/Elements

kyoki at bestpractical.com kyoki at bestpractical.com
Wed Jun 18 16:07:53 EDT 2008


Author: kyoki
Date: Wed Jun 18 16:07:52 2008
New Revision: 13394

Modified:
   rt/3.8/trunk/   (props changed)
   rt/3.8/trunk/share/html/Elements/SelectTimeUnits
   rt/3.8/trunk/share/html/NoAuth/css/web2/base.css
   rt/3.8/trunk/share/html/NoAuth/css/web2/forms.css
   rt/3.8/trunk/share/html/NoAuth/css/web2/ticket-search.css
   rt/3.8/trunk/share/html/Search/Elements/ConditionRow
   rt/3.8/trunk/share/html/Search/Elements/SelectChartType
   rt/3.8/trunk/share/html/Search/Elements/SelectGroup
   rt/3.8/trunk/share/html/Search/Elements/SelectGroupBy
   rt/3.8/trunk/share/html/Search/Elements/SelectPersonType
   rt/3.8/trunk/share/html/Search/Elements/SelectSearchObject
   rt/3.8/trunk/share/html/Search/Elements/SelectSearchesForObjects

Log:
 r23111 at nyx:  kyoki | 2008-06-18 16:07:03 -0400
 RT-Ticket: 9680
 RT-Status: Resolved
 RT-Update: Correspond
 Dropdown menus now have white backgrounds and are a consistent size. Fonts are more consistent as well, as are spaces between boxes.


Modified: rt/3.8/trunk/share/html/Elements/SelectTimeUnits
==============================================================================
--- rt/3.8/trunk/share/html/Elements/SelectTimeUnits	(original)
+++ rt/3.8/trunk/share/html/Elements/SelectTimeUnits	Wed Jun 18 16:07:52 2008
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %# 
 %# END BPS TAGGED BLOCK }}}
-<select name="<% $Name %>">
+<select class="TimeUnits" id="<% $Name %>" name="<% $Name %>">
 <option value="minutes" selected="selected"><% loc('Minutes') %></option>
 <option value="hours"><% loc('Hours') %></option>
 </select>

Modified: rt/3.8/trunk/share/html/NoAuth/css/web2/base.css
==============================================================================
--- rt/3.8/trunk/share/html/NoAuth/css/web2/base.css	(original)
+++ rt/3.8/trunk/share/html/NoAuth/css/web2/base.css	Wed Jun 18 16:07:52 2008
@@ -55,7 +55,6 @@
 a {
   color: #000;
   text-decoration: none;
-  font-weight: bold;
 }
 
 

Modified: rt/3.8/trunk/share/html/NoAuth/css/web2/forms.css
==============================================================================
--- rt/3.8/trunk/share/html/NoAuth/css/web2/forms.css	(original)
+++ rt/3.8/trunk/share/html/NoAuth/css/web2/forms.css	Wed Jun 18 16:07:52 2008
@@ -219,3 +219,8 @@
     z-index: 150;
 }
 
+.value .TimeUnits{
+    margin-left: .5em;
+    width: 7em;
+}
+

Modified: rt/3.8/trunk/share/html/NoAuth/css/web2/ticket-search.css
==============================================================================
--- rt/3.8/trunk/share/html/NoAuth/css/web2/ticket-search.css	(original)
+++ rt/3.8/trunk/share/html/NoAuth/css/web2/ticket-search.css	Wed Jun 18 16:07:52 2008
@@ -50,9 +50,7 @@
 }
 
 #comp-Search-Build #pick-criteria select {
-    background: #eee;
-    border: 1px solid #eee;
-
+ width: 8em;
 }
 
 #comp-Search-Build #pick-criteria tr {
@@ -60,11 +58,12 @@
 }
 
 #comp-Search-Build #pick-criteria td.label {
-    font-size: 0.9em;
-    padding-right: 0.2em;
+    font: message-box;    
+    padding-right: 0.5em;
 }
 
 #comp-Search-Build #pick-criteria td.label * {
+ width: 8.5em;
 }
 
 #comp-Search-Build #pick-criteria td.label select {
@@ -74,25 +73,34 @@
 #comp-Search-Build #pick-criteria td.operator {
  padding-right: 0.5em;
  text-align: right;
- font-size: 0.9em;
+
+ width: 1em;
 }
 #comp-Search-Build #pick-criteria td.operator select {
  text-align: right;
 }
 
+#comp-Search-Build #pick-criteria td.value #ValueOfDate,
+#comp-Search-Build #pick-criteria td.value select{
+ width: 7em;
+}
+
 #comp-Search-Build #pick-criteria td.value input,
 #comp-Search-Build #pick-criteria td.value select {
- font-size: 0.9em;
- max-width: 14em;
+ width: 14em;
+}
+
+#comp-Search-Build #pick-criteria td.value #ValueOfTime,
+#comp-Search-Build #pick-criteria td.value #ValueOfTime-TimeUnits{
+ width: 7em;
 }
 
 #comp-Search-Build #pick-criteria td.value {
-  padding-right: 0.5em;
+ padding-right: 0.5em;
  text-align: left;
- font-size: 0.9em;
+ font: message-box;
 }
 
-
 #comp-Search-Build #editquery, #comp-Search-Build #editsearches{
   position: absolute;
   margin-top: 0.2em;

Modified: rt/3.8/trunk/share/html/Search/Elements/ConditionRow
==============================================================================
--- rt/3.8/trunk/share/html/Search/Elements/ConditionRow	(original)
+++ rt/3.8/trunk/share/html/Search/Elements/ConditionRow	Wed Jun 18 16:07:52 2008
@@ -76,11 +76,11 @@
     if ( $box->{'Type'} eq 'text' ) {
         my $default = $box->{'Default'} || '';
         my $size = $box->{'Size'}? qq{size="$box->{'Size'}"} : '';
-        return qq{<input name="$name" value="$default" $size />};
+        return qq{<input id="$name" name="$name" value="$default" $size />};
     }
     if ( $box->{'Type'} eq 'select' ) {
         my $res = '';
-        $res .= qq{<select name="$name">};
+        $res .= qq{<select id="$name" name="$name">};
         my @options = @{ $box->{'Options'} };
         while( my $k = shift @options ) {
             my $v = shift @options;

Modified: rt/3.8/trunk/share/html/Search/Elements/SelectChartType
==============================================================================
--- rt/3.8/trunk/share/html/Search/Elements/SelectChartType	(original)
+++ rt/3.8/trunk/share/html/Search/Elements/SelectChartType	Wed Jun 18 16:07:52 2008
@@ -49,7 +49,7 @@
 $Name => 'ChartType'
 $Default => 'bar'
 </%args>
-<select name="<%$Name%>">
+<select id="<%$Name%>" name="<%$Name%>">
 % foreach my $option qw(bar pie) {
 <option value="<%$option%>"<% $option eq $Default ? qq[ selected="selected"] : '' |n %>><%loc($option)%></option>
 % }

Modified: rt/3.8/trunk/share/html/Search/Elements/SelectGroup
==============================================================================
--- rt/3.8/trunk/share/html/Search/Elements/SelectGroup	(original)
+++ rt/3.8/trunk/share/html/Search/Elements/SelectGroup	Wed Jun 18 16:07:52 2008
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %# 
 %# END BPS TAGGED BLOCK }}}
-<select name="<%$Name%>">
+<select id="<%$Name%>" name="<%$Name%>">
 % if ($AllowNull) {
 <option value="">-</option>
 % }

Modified: rt/3.8/trunk/share/html/Search/Elements/SelectGroupBy
==============================================================================
--- rt/3.8/trunk/share/html/Search/Elements/SelectGroupBy	(original)
+++ rt/3.8/trunk/share/html/Search/Elements/SelectGroupBy	Wed Jun 18 16:07:52 2008
@@ -50,7 +50,7 @@
 $Default => 'Status'
 $Query   => ''
 </%args>
-<select name="<% $Name %>">
+<select id="<% $Name %>" name="<% $Name %>">
 % while (@options) {
 % my ($text, $value) = (shift @options, shift @options);
 <option value="<% $value %>" <% $value eq $Default ? 'selected="selected"' : '' |n%>><% loc($text) %></option>

Modified: rt/3.8/trunk/share/html/Search/Elements/SelectPersonType
==============================================================================
--- rt/3.8/trunk/share/html/Search/Elements/SelectPersonType	(original)
+++ rt/3.8/trunk/share/html/Search/Elements/SelectPersonType	Wed Jun 18 16:07:52 2008
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %# 
 %# END BPS TAGGED BLOCK }}}
-<select name="<%$Name%>">
+<select id="<%$Name%>" name="<%$Name%>">
 % if ($AllowNull) {
 <option value="">-</option>
 % }

Modified: rt/3.8/trunk/share/html/Search/Elements/SelectSearchObject
==============================================================================
--- rt/3.8/trunk/share/html/Search/Elements/SelectSearchObject	(original)
+++ rt/3.8/trunk/share/html/Search/Elements/SelectSearchObject	Wed Jun 18 16:07:52 2008
@@ -56,7 +56,7 @@
     $default_privacy = ref($Object).'-'.$Object->Id;
 }
 </%init>
-<select name="<%$Name%>">
+<select id="<%$Name%>" name="<%$Name%>">
 % foreach my $object (@Objects) {
 % my $privacy = ref($object).'-'.$object->id;
 % if (ref($object) eq 'RT::User' && $object->id == $session{'CurrentUser'}->Id) {

Modified: rt/3.8/trunk/share/html/Search/Elements/SelectSearchesForObjects
==============================================================================
--- rt/3.8/trunk/share/html/Search/Elements/SelectSearchesForObjects	(original)
+++ rt/3.8/trunk/share/html/Search/Elements/SelectSearchesForObjects	Wed Jun 18 16:07:52 2008
@@ -50,7 +50,7 @@
 $Name => undef
 $SearchType => 'Ticket',
 </%args>
-<select name="<%$Name%>">
+<select id="<%$Name%>" name="<%$Name%>">
 % foreach my $object (@Objects) {
 % if (ref($object) eq 'RT::User' && $object->id == $session{'CurrentUser'}->Id) {
 <option value=""><&|/l&>My saved searches</&></option>


More information about the Rt-commit mailing list