[Rt-commit] r12104 - in rt/branches/3.6-RELEASE: . html/NoAuth/css/3.5-default html/Widgets

[elacour at bestpractical.com]

Author: elacour
Date: Tue May  6 09:30:30 2008
New Revision: 12104

Modified:
   rt/branches/3.6-RELEASE/   (props changed)
   rt/branches/3.6-RELEASE/html/NoAuth/css/3.5-default/forms.css
   rt/branches/3.6-RELEASE/html/NoAuth/js/combobox.js
   rt/branches/3.6-RELEASE/html/Widgets/ComboBox

Log:
 r8763 at datura:  manu | 2008-05-06 15:29:59 +0200
 RT-Ticket: 9027
 RT-Status: resolved
 RT-Update: Correspond
 
 * Fixes for combobox layout:
   - Fix handling of select size
     typo in Widget/ComboBox: rows instead of size in select options
     typo in combobox.js: listSize instead of size
   - Fix overlapping of the select by the footer
     in Widget/ComboBox: place for last </span> (before select instead of
     after), so .combo-list is not under .combobox and the attribute z-index
     is ignored
   - Fix Layout
     forms.css: some fixes to make it looks like other selects
 


Modified: rt/branches/3.6-RELEASE/html/NoAuth/css/3.5-default/forms.css
==============================================================================
--- rt/branches/3.6-RELEASE/html/NoAuth/css/3.5-default/forms.css	(original)
+++ rt/branches/3.6-RELEASE/html/NoAuth/css/3.5-default/forms.css	Tue May  6 09:30:30 2008
@@ -109,9 +109,8 @@
 %# ComboBox styles... some properties like height and width must be dynamically
 %# set in the JS (at least for now).
 .combobox {
-    border: 2px inset #069;
-    padding-left: 0.5em;
-    padding-bottom: 0.1em;
+    border: 1px solid #069;
+    padding: 4px;
 }
 
 .combobox .combo-button {
@@ -127,10 +126,11 @@
 .combobox .combo-text {
     border: none;
     margin: 0;
-    padding: 0;
+    padding: 1px;
 }
 
 .combobox .combo-list {
+    border: 1px outset;
     z-index: 200;
 }
 

Modified: rt/branches/3.6-RELEASE/html/NoAuth/js/combobox.js
==============================================================================
--- rt/branches/3.6-RELEASE/html/NoAuth/js/combobox.js	(original)
+++ rt/branches/3.6-RELEASE/html/NoAuth/js/combobox.js	Tue May  6 09:30:30 2008
@@ -132,8 +132,8 @@
 function ComboBox_EnsureListSize( theList ) {
     if ( typeof( theList.listSize ) == "undefined" ) {
         if( typeof( theList.getAttribute ) != "undefined" ) {
-            if( theList.getAttribute( "listSize" ) != null && theList.getAttribute( "listSize" ) != "" ) {
-                theList.listSize = theList.getAttribute( "listSize" );
+            if( theList.getAttribute( "size" ) != null && theList.getAttribute( "size" ) != "" ) {
+                theList.listSize = theList.getAttribute( "size" );
                 return;
             }
         }

Modified: rt/branches/3.6-RELEASE/html/Widgets/ComboBox
==============================================================================
--- rt/branches/3.6-RELEASE/html/Widgets/ComboBox	(original)
+++ rt/branches/3.6-RELEASE/html/Widgets/ComboBox	Tue May  6 09:30:30 2008
@@ -50,12 +50,13 @@
 
 <span id="<% $Name %>_Container" class="combobox">
 <input name="<% $Name %>" id="<% $Name %>" class="combo-text" value="<% $Default %>" type="text" <% $Size ? "size='$Size'" : '' |n %> autocomplete="off" />
-<br style="display: none" /><span id="<% $Name %>_Button" class="combo-button"></span></span><select name="List-<% $Name %>" id="<% $Name %>_List" class="combo-list" onchange="ComboBox_SimpleAttach(this, this.form['<% $Name %>']); " rows="<% $Rows %>">
+<br style="display: none" /><span id="<% $Name %>_Button" class="combo-button"></span><select name="List-<% $Name %>" id="<% $Name %>_List" class="combo-list" onchange="ComboBox_SimpleAttach(this, this.form['<% $Name %>']); " size="<% $Rows %>">
 <option style="display: none" value="">-</option>
 % foreach my $value (@Values) {
         <option value="<%$value%>"><% $value%></option>
 % }
 </select>
+</span>
 <script language="javascript"><!--
 ComboBox_InitWith('<% $Name %>');
 //--></script>