[Rt-commit] r12532 - in rt/branches/3.8-TESTING: . t/ticket

[sunnavy at bestpractical.com]

Author: sunnavy
Date: Mon May 19 10:38:44 2008
New Revision: 12532

Modified:
   rt/branches/3.8-TESTING/   (props changed)
   rt/branches/3.8-TESTING/t/ticket/requestor-order.t
   rt/branches/3.8-TESTING/t/ticket/sort_by_cf.t
   rt/branches/3.8-TESTING/t/web/command_line.t

Log:
 r12602 at sunnavys-mb:  sunnavy | 2008-05-19 22:37:18 +0800
 removed todo labels for tests that passed


Modified: rt/branches/3.8-TESTING/t/ticket/requestor-order.t
==============================================================================
--- rt/branches/3.8-TESTING/t/ticket/requestor-order.t	(original)
+++ rt/branches/3.8-TESTING/t/ticket/requestor-order.t	Mon May 19 10:38:44 2008
@@ -111,11 +111,10 @@
 
     my $tix = RT::Tickets->new($RT::SystemUser);    
     $tix->FromSQL("Queue = '$queue' AND Subject = 'first test'");
-TODO: {
-    local $TODO = "if group has non users members we get wrong order";
+
     $tix->OrderByCols({ FIELD => "Requestor.EmailAddress" });
     check_emails_order($tix, 7, 'ASC');
-}
+
     $tix->OrderByCols({ FIELD => "Requestor.EmailAddress", ORDER => 'DESC' });
     check_emails_order($tix, 7, 'DESC');
 

Modified: rt/branches/3.8-TESTING/t/ticket/sort_by_cf.t
==============================================================================
--- rt/branches/3.8-TESTING/t/ticket/sort_by_cf.t	(original)
+++ rt/branches/3.8-TESTING/t/ticket/sort_by_cf.t	Mon May 19 10:38:44 2008
@@ -114,19 +114,13 @@
 $tx->FromSQL(qq[queue="$queue"] );
 $tx->OrderBy( FIELD => "CF.{Charlie}", ORDER => 'DESC' );
 is($tx->Count,2);
-TODO: {
-    local $TODO = 'order by CF fail';
 check_order( $tx, 1, 2);
-}
 
 $tx = new RT::Tickets( $RT::SystemUser );
 $tx->FromSQL(qq[queue="$queue"] );
 $tx->OrderBy( FIELD => "CF.{Charlie}", ORDER => 'ASC' );
 is($tx->Count,2);
-TODO: {
-    local $TODO = 'order by CF fail';
 check_order( $tx, 2, 1);
-}
 
 # Add a new ticket, to test sorting on multiple columns.
 my $t3 = RT::Ticket->new($RT::SystemUser);
@@ -145,10 +139,7 @@
     { FIELD => "CF.${queue}.{Alpha}",   ORDER => 'DES' },
 );
 is($tx->Count,3);
-TODO: {
-    local $TODO = 'order by CF fail';
 check_order( $tx, 3, 2, 1);
-}
 
 $tx = new RT::Tickets( $RT::SystemUser );
 $tx->FromSQL(qq[queue="$queue"] );
@@ -157,10 +148,7 @@
     { FIELD => "CF.${queue}.{Alpha}",   ORDER => 'ASC' },
 );
 is($tx->Count,3);
-TODO: {
-    local $TODO = 'order by CF fail';
 check_order( $tx, 1, 2, 3);
-}
 
 # Reverse the order of the secondary column, which changes the order
 # of the first two tickets.
@@ -171,10 +159,7 @@
     { FIELD => "CF.${queue}.{Alpha}",   ORDER => 'ASC' },
 );
 is($tx->Count,3);
-TODO: {
-    local $TODO = 'order by CF fail';
 check_order( $tx, 2, 3, 1);
-}
 
 $tx = new RT::Tickets( $RT::SystemUser );
 $tx->FromSQL(qq[queue="$queue"] );
@@ -183,7 +168,4 @@
     { FIELD => "CF.${queue}.{Alpha}",   ORDER => 'DES' },
 );
 is($tx->Count,3);
-TODO: {
-    local $TODO = 'order by CF fail';
 check_order( $tx, 1, 3, 2);
-}

Modified: rt/branches/3.8-TESTING/t/web/command_line.t
==============================================================================
--- rt/branches/3.8-TESTING/t/web/command_line.t	(original)
+++ rt/branches/3.8-TESTING/t/web/command_line.t	Mon May 19 10:38:44 2008
@@ -198,10 +198,11 @@
 # show ticket history
 expect_send("show ticket/$ticket_id/history", 'Showing our ticket\'s history...');
 expect_like(qr/Ticket created by root/, 'Got our history');
+
+expect_send("show -v ticket/$ticket_id/history", 'Showing our ticket\'s history verbosely...');
 TODO: {
     local $TODO = "Cannot show verbose ticket history right now";
     # show ticket history verbosely
-    expect_send("show -v ticket/$ticket_id/history", 'Showing our ticket\'s history verbosely...');
     expect_like(qr/Ticket created by root/, 'Got our history');
 }
 # get attachments from a ticket