[Rt-commit] r12763 - in rt/branches/3.8-TESTING/share/html: Admin/CustomFields Approvals/Elements Search/Elements

sunnavy at bestpractical.com sunnavy at bestpractical.com
Fri May 30 11:48:43 EDT 2008 

Author: sunnavy
Date: Fri May 30 11:48:43 2008
New Revision: 12763

Modified:
   rt/branches/3.8-TESTING/share/html/Admin/CustomFields/Modify.html
   rt/branches/3.8-TESTING/share/html/Admin/Elements/SelectGroups
   rt/branches/3.8-TESTING/share/html/Admin/Elements/SelectNewGroupMembers
   rt/branches/3.8-TESTING/share/html/Admin/Elements/SelectRights
   rt/branches/3.8-TESTING/share/html/Admin/Elements/SelectUsers
   rt/branches/3.8-TESTING/share/html/Approvals/Elements/PendingMyApproval
   rt/branches/3.8-TESTING/share/html/Search/Elements/EditFormat
   rt/branches/3.8-TESTING/share/html/Search/Elements/EditQuery

Log:
fully specify attribute values

Modified: rt/branches/3.8-TESTING/share/html/Admin/CustomFields/Modify.html
==============================================================================
--- rt/branches/3.8-TESTING/share/html/Admin/CustomFields/Modify.html	(original)
+++ rt/branches/3.8-TESTING/share/html/Admin/CustomFields/Modify.html	Fri May 30 11:48:43 2008
@@ -109,7 +109,7 @@
 
 <tr><td class="label">&nbsp;</td><td>
 <input type="hidden" class="hidden" name="SetEnabled" value="1" />
-<input type="checkbox" class="checkbox" name="Enabled" value="1" <% $EnabledChecked %> />
+<input type="checkbox" class="checkbox" name="Enabled" value="1" <% $EnabledChecked |n%> />
 <&|/l&>Enabled (Unchecking this box disables this custom field)</&>
 </td></tr>
 
@@ -203,7 +203,7 @@
 
 $id = $CustomFieldObj->id if $CustomFieldObj->id;
 
-my $EnabledChecked = "checked";
+my $EnabledChecked = qq[checked="checked"];
 $EnabledChecked = '' if $CustomFieldObj->Disabled;
 
 my @CFvalidations = (

Modified: rt/branches/3.8-TESTING/share/html/Admin/Elements/SelectGroups
==============================================================================
--- rt/branches/3.8-TESTING/share/html/Admin/Elements/SelectGroups	(original)
+++ rt/branches/3.8-TESTING/share/html/Admin/Elements/SelectGroups	Fri May 30 11:48:43 2008
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %# 
 %# END BPS TAGGED BLOCK }}}
-<select multiple name="<%$Name%>"  size="10">
+<select multiple="multiple" name="<%$Name%>"  size="10">
 %while (my $group = $groups->Next) {
 <option value="<%$group->id%>"><%$group->Name%>
 %}

Modified: rt/branches/3.8-TESTING/share/html/Admin/Elements/SelectNewGroupMembers
==============================================================================
--- rt/branches/3.8-TESTING/share/html/Admin/Elements/SelectNewGroupMembers	(original)
+++ rt/branches/3.8-TESTING/share/html/Admin/Elements/SelectNewGroupMembers	Fri May 30 11:48:43 2008
@@ -47,7 +47,7 @@
 %# END BPS TAGGED BLOCK }}}
 % if ( $Show ne 'Groups' ) {
 <b><&|/l&>Users</&></b>
-<select multiple name="<% $Name %>Users" size="10">
+<select multiple="multiple" name="<% $Name %>Users" size="10">
 % while ( my $user = $users->Next ) {
 % next if $SkipUsers->{ $user->id };
 <option value="User-<% $user->id %>"><& /Elements/ShowUser, User => $user &></option>
@@ -58,7 +58,7 @@
 
 % if ( $Show ne 'Users' ) {
 <b><&|/l&>Groups</&></b>
-<select multiple name="<% $Name %>Groups" size="10">
+<select multiple="multiple" name="<% $Name %>Groups" size="10">
 % while ( my $group = $groups->Next ) {
 % next if $SkipGroups->{ $group->id };
 <option value="Group-<% $group->id %>"><% $group->Name %></option>

Modified: rt/branches/3.8-TESTING/share/html/Admin/Elements/SelectRights
==============================================================================
--- rt/branches/3.8-TESTING/share/html/Admin/Elements/SelectRights	(original)
+++ rt/branches/3.8-TESTING/share/html/Admin/Elements/SelectRights	Fri May 30 11:48:43 2008
@@ -65,7 +65,7 @@
 </td>
 <td valign="top">
 <h3><&|/l&>New rights</&></h3> 
-<select size="5"  multiple  name="GrantRight-<%$ACLDesc%>">
+<select size="5" multiple="multiple" name="GrantRight-<%$ACLDesc%>">
 % foreach $right (sort keys %Rights) {
 % next if $current_rights{$right};
       <option value="<%$right%>"  

Modified: rt/branches/3.8-TESTING/share/html/Admin/Elements/SelectUsers
==============================================================================
--- rt/branches/3.8-TESTING/share/html/Admin/Elements/SelectUsers	(original)
+++ rt/branches/3.8-TESTING/share/html/Admin/Elements/SelectUsers	Fri May 30 11:48:43 2008
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %# 
 %# END BPS TAGGED BLOCK }}}
-<select multiple name="<% $Name %>"  size="10">
+<select multiple="multiple" name="<% $Name %>"  size="10">
 % while ( my $user = $users->Next ) {
 <option value="<% $user->id %>">\
 <& /Elements/ShowUser, User => $user &>\

Modified: rt/branches/3.8-TESTING/share/html/Approvals/Elements/PendingMyApproval
==============================================================================
--- rt/branches/3.8-TESTING/share/html/Approvals/Elements/PendingMyApproval	(original)
+++ rt/branches/3.8-TESTING/share/html/Approvals/Elements/PendingMyApproval	Fri May 30 11:48:43 2008
@@ -62,10 +62,10 @@
 <input type="checkbox" class="checkbox" value="1" name="ShowPending"
         <%((!$ARGS{'ShowRejected'} && !$ARGS{'ShowResolved'}) ||
          $ARGS{'ShowPending'})
-        && "checked"%> /> <&|/l&>Show pending requests</&><br />
-<input type="checkbox" class="checkbox" value="1" name="ShowResolved" <% defined($ARGS{'ShowResolved'}) && $ARGS{'ShowResolved'} && "checked"%> /> <&|/l&>Show approved requests</&><br />
-<input type="checkbox" class="checkbox" value="1" name="ShowRejected" <% defined($ARGS{'ShowRejected'}) && $ARGS{'ShowRejected'} && "checked"%> /> <&|/l&>Show denied requests</&><br />
-<input type="checkbox" class="checkbox" value="1" name="ShowDependent" <% defined($ARGS{'ShowDependent'}) && $ARGS{'ShowDependent'} && "checked"%> /> <&|/l&>Show requests awaiting other approvals</&><br />
+        && qq[checked="checked"] |n%> /> <&|/l&>Show pending requests</&><br />
+<input type="checkbox" class="checkbox" value="1" name="ShowResolved" <% defined($ARGS{'ShowResolved'}) && $ARGS{'ShowResolved'} && qq[checked="checked"] |n%> /> <&|/l&>Show approved requests</&><br />
+<input type="checkbox" class="checkbox" value="1" name="ShowRejected" <% defined($ARGS{'ShowRejected'}) && $ARGS{'ShowRejected'} && qq[checked="checked"] |n%> /> <&|/l&>Show denied requests</&><br />
+<input type="checkbox" class="checkbox" value="1" name="ShowDependent" <% defined($ARGS{'ShowDependent'}) && $ARGS{'ShowDependent'} && qq[checked="checked"] |n%> /> <&|/l&>Show requests awaiting other approvals</&><br />
 
 <&|/l,"<input size='15' value='".($created_before->Unix > 0 &&$created_before->ISO)."' name='CreatedBefore' id='CreatedBefore' />"&>Only show approvals for requests created before [_1]</&><br />
 

Modified: rt/branches/3.8-TESTING/share/html/Search/Elements/EditFormat
==============================================================================
--- rt/branches/3.8-TESTING/share/html/Search/Elements/EditFormat	(original)
+++ rt/branches/3.8-TESTING/share/html/Search/Elements/EditFormat	Fri May 30 11:48:43 2008
@@ -56,7 +56,7 @@
 
 <tr>
 
-<td valign="top"><select size="6" name="SelectDisplayColumns" multiple>
+<td valign="top"><select size="6" name="SelectDisplayColumns" multiple="multiple">
 % foreach my $field ( @$AvailableColumns) {
 <option value="<% $field %>"><% loc($field) %></option>
 % }

Modified: rt/branches/3.8-TESTING/share/html/Search/Elements/EditQuery
==============================================================================
--- rt/branches/3.8-TESTING/share/html/Search/Elements/EditQuery	(original)
+++ rt/branches/3.8-TESTING/share/html/Search/Elements/EditQuery	Fri May 30 11:48:43 2008
@@ -48,7 +48,7 @@
 <& NewListActions, actions => $actions &>
 <&|/Widgets/TitleBox, title => join(': ', grep defined, loc("Current search"), $Description) &>
 
-<select size="10" name="clauses" style="width: 100%" multiple>
+<select size="10" name="clauses" style="width: 100%" multiple="multiple">
 % $m->out($optionlist);
 </select>

More information about the Rt-commit mailing list