[Rt-commit] r16406 - in rt/3.8/trunk: lib/RT/Interface/Web

[falcone at bestpractical.com]

Author: falcone
Date: Mon Oct 20 17:57:26 2008
New Revision: 16406

Modified:
   rt/3.8/trunk/   (props changed)
   rt/3.8/trunk/lib/RT/Interface/Web/Request.pm

Log:
 r40828 at ketch:  falcone | 2008-10-20 08:32:04 -0700
 * warn when someone has two plugins that both use html/Callbacks/Foo and share
   a callback (ie. both use Tabs/Default).  Only one of these will run and it can
   be frustrating trying to figure out why only part of a plugin is working.
 * fixing this would require $m->comp to be able to be told "run the component
   in this specific component root" which I can't find a way to do
 
 r40829 at ketch:  falcone | 2008-10-20 08:43:28 -0700
 * fix change to SiteConfig
 r40830 at ketch:  falcone | 2008-10-20 08:47:25 -0700
 cleanup RT_SiteConfig


Modified: rt/3.8/trunk/lib/RT/Interface/Web/Request.pm
==============================================================================
--- rt/3.8/trunk/lib/RT/Interface/Web/Request.pm	(original)
+++ rt/3.8/trunk/lib/RT/Interface/Web/Request.pm	Mon Oct 20 17:57:26 2008
@@ -167,6 +167,10 @@
             map $self->interp->resolver->glob_path($path, $_),
             @roots
         );
+        foreach my $comp (keys %seen) {
+            next unless $seen{$comp} > 1;
+            $RT::Logger->error("Found more than one occurrence of the $comp callback.  This may cause only one of the callbacks to run.  Look for the duplicate Callback in your @roots");
+        }
 
         $cache{ $CacheKey } = $callbacks unless RT->Config->Get('DevelMode');
     }