[Rt-commit] r19024 - rt/3.999/trunk/lib/RT/Shredder

[ruz at bestpractical.com]

Author: ruz
Date: Thu Apr  2 06:18:42 2009
New Revision: 19024

Modified:
   rt/3.999/trunk/lib/RT/Shredder/Constants.pm
   rt/3.999/trunk/lib/RT/Shredder/Dependency.pm
   rt/3.999/trunk/lib/RT/Shredder/Record.pm

Log:
* delete more code related to validations in shredder

Modified: rt/3.999/trunk/lib/RT/Shredder/Constants.pm
==============================================================================
--- rt/3.999/trunk/lib/RT/Shredder/Constants.pm	(original)
+++ rt/3.999/trunk/lib/RT/Shredder/Constants.pm	Thu Apr  2 06:18:42 2009
@@ -77,22 +77,15 @@
 =head2 VARIABLE
 
 This flag is used to mark dependencies that can be resolved with changing
-value in target object. For example ticket can be Created by user we can
-change this reference when we delete user.
-
-=head2 RELATES
-
-This flag is used to validate relationships integrity. base object
-is valid only when all target objects which are marked with this flags
-exist.
+value in target object. For example ticket is created by an user we can
+change this reference when we delete the user.
 
 =cut
 
 use constant {
     DEPENDS_ON => 0x000001,
     WIPE_AFTER => 0x000010,
-    RELATES    => 0x000100,
-    VARIABLE   => 0x001000,
+    VARIABLE   => 0x000100,
 };
 
 =head1 STATES
@@ -108,33 +101,21 @@
 object is still in memory. This state is used to be shure that
 delete query is called once.
 
-=head2 VALID
-
-object is marked with this state only when its relationships
-are valid.
-
-=head2 INVALID
-
 =cut
 
 use constant {
     ON_STACK  => 0x00000,
     IN_WIPING => 0x00001,
     WIPED     => 0x00010,
-    VALID     => 0x00100,
-    INVALID   => 0x01000,
 };
 
 our @EXPORT = qw(
     DEPENDS_ON
     WIPE_AFTER
-    RELATES
     VARIABLE
     ON_STACK
     IN_WIPING
     WIPED
-    VALID
-    INVALID
 );
 
 1;

Modified: rt/3.999/trunk/lib/RT/Shredder/Dependency.pm
==============================================================================
--- rt/3.999/trunk/lib/RT/Shredder/Dependency.pm	(original)
+++ rt/3.999/trunk/lib/RT/Shredder/Dependency.pm	Thu Apr  2 06:18:42 2009
@@ -51,7 +51,7 @@
 use RT::Shredder::Constants;
 use RT::Shredder::Exceptions;
 
-my %FlagDescs = ( DEPENDS_ON, 'depends on', VARIABLE, 'resolvable dependency', WIPE_AFTER, 'delete after', RELATES, 'relates with', );
+my %FlagDescs = ( DEPENDS_ON, 'depends on', VARIABLE, 'resolvable dependency', WIPE_AFTER, 'delete after' );
 
 sub new {
     my $proto = shift;

Modified: rt/3.999/trunk/lib/RT/Shredder/Record.pm
==============================================================================
--- rt/3.999/trunk/lib/RT/Shredder/Record.pm	(original)
+++ rt/3.999/trunk/lib/RT/Shredder/Record.pm	Thu Apr  2 06:18:42 2009
@@ -110,9 +110,6 @@
     if ( $args{'flags'} & DEPENDS_ON ) {
         $self->__depends_on( %args, dependencies => $deps );
     }
-    if ( $args{'flags'} & RELATES ) {
-        $self->__relates( %args, dependencies => $deps );
-    }
     return $deps;
 }
 
@@ -178,35 +175,4 @@
     return;
 }
 
-sub validate_relations {
-    my $self = shift;
-    my %args = (
-        shredder => undef,
-        @_
-    );
-    unless ( $args{'shredder'} ) {
-        $args{'shredder'} = RT::Shredder->new();
-    }
-
-    my $rec = $args{'shredder'}->put_object( object => $self );
-    return if ( $rec->{'state'} & VALID );
-    $self = $rec->{'object'};
-
-    $self->_validate_relations( %args, flags => RELATES );
-    $rec->{'state'} |= VALID unless ( $rec->{'state'} & INVALID );
-
-    return;
-}
-
-sub _validate_relations {
-    my $self = shift;
-    my %args = (@_);
-
-    my $deps = $self->dependencies(%args);
-
-    $deps->validate_relations(%args);
-
-    return;
-}
-
 1;