[Rt-commit] r19312 - rt/3.999/branches/config-in-db/lib/RT/Model

sunnavy at bestpractical.com sunnavy at bestpractical.com
Tue Apr 21 05:08:13 EDT 2009


Author: sunnavy
Date: Tue Apr 21 05:08:12 2009
New Revision: 19312

Modified:
   rt/3.999/branches/config-in-db/lib/RT/Model/Config.pm

Log:
also need the empty string hack when create an item

Modified: rt/3.999/branches/config-in-db/lib/RT/Model/Config.pm
==============================================================================
--- rt/3.999/branches/config-in-db/lib/RT/Model/Config.pm	(original)
+++ rt/3.999/branches/config-in-db/lib/RT/Model/Config.pm	Tue Apr 21 05:08:12 2009
@@ -114,10 +114,7 @@
     my $name  = shift;
     my $value = shift;
 
-    if ( defined $value && $value eq '' ) {
-        $value = '[empty string]'; # bloddy hack, or '' will be treated as undef
-    }
-
+    $value = $self->_empty_string if defined $value && $value eq '';
     my $config = RT::Model::Config->new( current_user => RT->system_user );
     my ( $ret, $msg ) = $config->load_by_cols( name => $name );
     if ($ret) {
@@ -129,5 +126,17 @@
     }
 }
 
+sub create {
+    my $self = shift;
+    my %args = @_;
+    $args{value} = $self->_empty_string
+      if defined $args{value} && $args{value} eq '';
+    return $self->SUPER::create(%args);
+}
+
+sub _empty_string {
+    return '[empty string]';
+}
+
 1;
 


More information about the Rt-commit mailing list