[Rt-commit] rt branch, hide_empty_in_title_box, created. rt-3.8.6-121-g9031c98
Ruslan Zakirov
ruz at bestpractical.com
Fri Dec 4 00:31:42 EST 2009
The branch, hide_empty_in_title_box has been created
at 9031c9822980b842125f3e989660bf037fc4395c (commit)
- Log -----------------------------------------------------------------
commit 59b5f56d348983efb5c6ec40fc1e2148d7fd004d
Author: Kevin Falcone <falcone at bestpractical.com>
Date: Thu Dec 3 08:47:03 2009 -0500
Make NotifyActor into a User Preference
diff --git a/lib/RT/Action/Notify.pm b/lib/RT/Action/Notify.pm
index 30238fd..3b782f3 100755
--- a/lib/RT/Action/Notify.pm
+++ b/lib/RT/Action/Notify.pm
@@ -139,12 +139,15 @@ sub SetRecipients {
}
}
- my $creator = $self->TransactionObj->CreatorObj->EmailAddress();
+ my $creatorObj = $self->TransactionObj->CreatorObj;
+ my $creator = $creatorObj->EmailAddress();
#Strip the sender out of the To, Cc and AdminCc and set the
# recipients fields used to build the message by the superclass.
# unless a flag is set
- if (RT->Config->Get('NotifyActor')) {
+ my $TransactionCurrentUser = RT::CurrentUser->new;
+ $TransactionCurrentUser->LoadByName($creatorObj->Name);
+ if (RT->Config->Get('NotifyActor',$TransactionCurrentUser)) {
@{ $self->{'To'} } = @To;
@{ $self->{'Cc'} } = @Cc;
@{ $self->{'Bcc'} } = @Bcc;
diff --git a/lib/RT/Action/NotifyGroup.pm b/lib/RT/Action/NotifyGroup.pm
index 6b830cb..131c583 100644
--- a/lib/RT/Action/NotifyGroup.pm
+++ b/lib/RT/Action/NotifyGroup.pm
@@ -84,8 +84,13 @@ sub SetRecipients {
$self->_HandleArgument( $_ );
}
- my $creator = $self->TransactionObj->CreatorObj->EmailAddress();
- unless( $RT::NotifyActor ) {
+ my $creatorObj = $self->TransactionObj->CreatorObj;
+ my $creator = $creatorObj->EmailAddress();
+
+ my $TransactionCurrentUser = RT::CurrentUser->new;
+ $TransactionCurrentUser->LoadByName($creatorObj->Name);
+
+ unless (RT->Config->Get('NotifyActor',$TransactionCurrentUser)) {
@{ $self->{'To'} } = grep ( !/^\Q$creator\E$/, @{ $self->{'To'} } );
}
diff --git a/lib/RT/Config.pm b/lib/RT/Config.pm
index 76c45dc..ed459a5 100644
--- a/lib/RT/Config.pm
+++ b/lib/RT/Config.pm
@@ -349,6 +349,16 @@ our %META = (
]
}
},
+ NotifyActor => {
+ Section => 'Mail', #loc
+ Overridable => 1,
+ SortOrder => 2,
+ Widget => '/Widgets/Form/Boolean',
+ WidgetArguments => {
+ Description => 'Notify Actor', #loc
+ Hints => 'Receive mail from RT for all your actions and correspondence', #loc
+ }
+ },
# this tends to break extensions that stash links in ticket update pages
Organization => {
commit ea16f6817ce74d1715855fb29970fcfebf331e60
Author: Kevin Falcone <falcone at bestpractical.com>
Date: Thu Dec 3 10:34:08 2009 -0500
wording fixes for new user config option
diff --git a/lib/RT/Config.pm b/lib/RT/Config.pm
index ed459a5..6fc1b89 100644
--- a/lib/RT/Config.pm
+++ b/lib/RT/Config.pm
@@ -355,8 +355,8 @@ our %META = (
SortOrder => 2,
Widget => '/Widgets/Form/Boolean',
WidgetArguments => {
- Description => 'Notify Actor', #loc
- Hints => 'Receive mail from RT for all your actions and correspondence', #loc
+ Description => 'Outgoing mail', #loc
+ Hints => 'Should RT send you mail for ticket updates you make?', #loc
}
},
commit 4f0d3e64378107be6bd40f377d3250f3031cfa9f
Author: Kevin Falcone <falcone at bestpractical.com>
Date: Thu Dec 3 14:30:55 2009 -0500
We only have this index in the schema and upgrade scripts for mysql and oracle
diff --git a/UPGRADING b/UPGRADING
index 5a4eb7e..1aaccdb 100644
--- a/UPGRADING
+++ b/UPGRADING
@@ -20,6 +20,7 @@ well.
*******
UPGRADING FROM 3.8.6 and earlier - Changes:
+For MySQL and Oracle users:
If you upgraded from a version of RT earlier than 3.7.81 you should
already have a CachedGroupMembers3 index on your CachedGroupMembers table.
If you did a clean install of RT somewhere in the 3.8 release series, you
commit 6241b7df1b3d755c097b497b696134b8d4c2b6e3
Author: Jesse Vincent <jesse at bestpractical.com>
Date: Wed Dec 2 17:18:32 2009 -0500
Make the plain-text-mono stuff not try to wrap html mail
diff --git a/share/html/Ticket/Elements/ShowMessageStanza b/share/html/Ticket/Elements/ShowMessageStanza
index 0d4fe61..9d2f211 100755
--- a/share/html/Ticket/Elements/ShowMessageStanza
+++ b/share/html/Ticket/Elements/ShowMessageStanza
@@ -48,7 +48,8 @@
<%perl>
if ( ref $Message ) {
$m->out('<pre>') if $plain_text_pre && !$Depth && !$plain_text_mono;
- $m->out( qq{<div class="message-stanza-depth-$Depth">} );
+ $m->out( qq{<div class="message-stanza-depth-$Depth } .($plain_text_mono ? "plain-text-white-space" : "") .qq{">} );
+
my @stack;
my $para = '';
diff --git a/share/html/Ticket/Elements/ShowTransactionAttachments b/share/html/Ticket/Elements/ShowTransactionAttachments
index 9c40b28..242725a 100644
--- a/share/html/Ticket/Elements/ShowTransactionAttachments
+++ b/share/html/Ticket/Elements/ShowTransactionAttachments
@@ -76,7 +76,7 @@ foreach my $message ( grep $_->__Value('Parent') == $Parent, @$Attachments ) {
% if ( scalar ( grep $_->__Value('Parent') == $message->id, @$Attachments ) ) {
<div class="messageattachments">
% } else {
-<div class="messagebody <% RT->Config->Get('PlainTextMono', $session{'CurrentUser'}) ? ' plain-text-white-space' : ''%>">
+<div class="messagebody">
% }
<%PERL>
commit 9af5e79efcad3e8bffc9c2fe97d3fabc53f42cac
Author: Jesse Vincent <jesse at bestpractical.com>
Date: Wed Dec 2 17:21:42 2009 -0500
make the plaintext mono feature work in IE
diff --git a/share/html/NoAuth/css/web2/msie.css b/share/html/NoAuth/css/web2/msie.css
index 184ac1d..2297c30 100644
--- a/share/html/NoAuth/css/web2/msie.css
+++ b/share/html/NoAuth/css/web2/msie.css
@@ -237,3 +237,10 @@ table.queue-summary td, td.collection-as-table {
#pick-criteria td.operator {
width: 7.5em;
}
+
+.plain-text-white-space {
+ word-wrap: break-word; /* Internet Explorer 5.5+ */
+ white-space: pre; /* IE only hack to re-specify in addition to
+ word-wrap */
+}
+
commit 9031c9822980b842125f3e989660bf037fc4395c
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date: Tue Dec 1 13:27:28 2009 +0300
Implement $SendTo in CreateTicket
diff --git a/share/html/Elements/CreateTicket b/share/html/Elements/CreateTicket
index 9c8f3aa..fd2ba9e 100755
--- a/share/html/Elements/CreateTicket
+++ b/share/html/Elements/CreateTicket
@@ -45,6 +45,9 @@
%# those contributions and any derivatives thereof.
%#
%# END BPS TAGGED BLOCK }}}
-<form action="<% RT->Config->Get('WebPath') %>/Ticket/Create.html" name="CreateTicketInQueue" id="CreateTicketInQueue">
-<&|/l, $m->scomp('/Elements/SelectNewTicketQueue', OnChange => 'document.CreateTicketInQueue.submit()')&><input type="submit" class="button" value="New ticket in" /> [_1]</&>
+<form action="<% RT->Config->Get('WebPath') %><% $SendTo %>" name="CreateTicketInQueue" id="CreateTicketInQueue">
+<&|/l, $m->scomp('/Elements/SelectNewTicketQueue', OnChange => 'document.CreateTicketInQueue.submit()', SendTo => $SendTo ) &><input type="submit" class="button" value="New ticket in" /> [_1]</&>
</form>
+<%ARGS>
+$SendTo => '/Ticket/Create.html',
+</%ARGS>
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list