[Rt-commit] rt branch, allow-loops, updated. rt-3.8.5-299-g139774c

[Alex M Vandiver]

The branch, allow-loops has been updated
       via  139774c80c77d943e543a145ecf6de342fb217d0 (commit)
       via  224ec042d67536242bd378848f74ff477901d558 (commit)
       via  3e135e31edb05697d0a675153199e78d87279bf6 (commit)
      from  5bc7d05bc5320274e9ac870dd59bec43f124a301 (commit)

Summary of changes:
 lib/RT/Interface/Email.pm     |    6 +++---
 share/html/Elements/ShowLinks |   16 ++++++++++++++++
 2 files changed, 19 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit 3e135e31edb05697d0a675153199e78d87279bf6
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Dec 17 14:47:30 2009 -0500

    qr// is not qw// -- actually pull headers from original message

diff --git a/lib/RT/Interface/Email.pm b/lib/RT/Interface/Email.pm
index 048321b..06410cb 100755
--- a/lib/RT/Interface/Email.pm
+++ b/lib/RT/Interface/Email.pm
@@ -1579,7 +1579,7 @@ sub LinkSelfLoops {
 
     my $orig = $txn->Attachments->First->ContentAsMIME;
     $args{Message}->head->set($_, $orig->head->get($_))
-        for qr/Subject Content-Type Content-Transfer-Encoding Content-Length MIME-Version/;
+        for qw/Subject Content-Type Content-Transfer-Encoding Content-Length MIME-Version/;
     $args{Message}->bodyhandle( $orig->bodyhandle );
     $args{Message}->parts( [$orig->parts] );
 

commit 224ec042d67536242bd378848f74ff477901d558
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Dec 17 14:48:00 2009 -0500

    Use ->__Value to walk around possible permissions problems when determining queue

diff --git a/lib/RT/Interface/Email.pm b/lib/RT/Interface/Email.pm
index 06410cb..17cc78a 100755
--- a/lib/RT/Interface/Email.pm
+++ b/lib/RT/Interface/Email.pm
@@ -1604,11 +1604,11 @@ sub LinkSelfLoops {
         }
         # Regardless, link them now.
         $args{Ticket}->AddAttribute(
-            Name    => "InternalLinks-" . $other->Queue,
+            Name    => "InternalLinks-" . $other->__Value('Queue'),
             Content => $other->Id,
         );
         $other->AddAttribute(
-            Name    => "InternalLinks-" . $args{Ticket}->Queue,
+            Name    => "InternalLinks-" . $args{Ticket}->__Value('Queue'),
             Content => $args{Ticket}->Id,
         );
         # ..and drop the message on the floor.

commit 139774c80c77d943e543a145ecf6de342fb217d0
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Dec 17 14:49:23 2009 -0500

    Add internal links display

diff --git a/share/html/Elements/ShowLinks b/share/html/Elements/ShowLinks
index 569bad3..7e8444a 100755
--- a/share/html/Elements/ShowLinks
+++ b/share/html/Elements/ShowLinks
@@ -116,6 +116,22 @@ for my $link ( @{ $Ticket->DependsOn->ItemsArrayRef } ) {
     </td>
   </tr>
 
+% my $attribs = $Ticket->Attributes;
+% my @internal = map {$_->Content} map {$attribs->Named($_)} grep {/^InternalLinks-/} $attribs->Names;
+% if (@internal) {
+  <tr>
+    <td class="labeltop"><&|/l&>Internal link</&>:</td>
+    <td class="value">
+    <ul>
+% for my $id (@internal) {
+% my $uri = RT::URI->new( $session{'CurrentUser'} );
+% $uri->FromURI($id);
+<li><& ShowLink, URI => $uri &></li>
+% }
+</ul>
+    </td>
+  </tr>
+% }
 
 % # Allow people to add more rows to the table
 % $m->callback( %ARGS );

-----------------------------------------------------------------------