[Rt-commit] rt branch, admin_ui, updated. d90d07a7473c44737fece8bbd03ed67d5b6f4d88
sunnavy at bestpractical.com
sunnavy at bestpractical.com
Thu Dec 24 20:18:21 EST 2009
The branch, admin_ui has been updated
via d90d07a7473c44737fece8bbd03ed67d5b6f4d88 (commit)
from df0c364ea99cc0f1447995261448ac8a204d67da (commit)
Summary of changes:
lib/RT/View/Admin/CustomFields.pm | 17 -----------------
lib/RT/View/Admin/Global/Templates.pm | 16 ----------------
lib/RT/View/Admin/Groups.pm | 18 ------------------
lib/RT/View/Admin/Queues.pm | 16 ----------------
lib/RT/View/Admin/Queues/Templates.pm | 16 ----------------
lib/RT/View/Admin/Users.pm | 17 -----------------
lib/RT/View/CRUD.pm | 4 +---
7 files changed, 1 insertions(+), 103 deletions(-)
- Log -----------------------------------------------------------------
commit d90d07a7473c44737fece8bbd03ed67d5b6f4d88
Author: sunnavy <sunnavy at bestpractical.com>
Date: Fri Dec 25 09:17:50 2009 +0800
let's use inline edit by default for now
diff --git a/lib/RT/View/Admin/CustomFields.pm b/lib/RT/View/Admin/CustomFields.pm
index ccf49e1..8f34a67 100644
--- a/lib/RT/View/Admin/CustomFields.pm
+++ b/lib/RT/View/Admin/CustomFields.pm
@@ -58,23 +58,6 @@ use constant display_columns =>
qw(id name description type lookup_type max_values pattern
sort_order repeated disabled );
-private template view_item_controls => sub {
-
- my $self = shift;
- my $record = shift;
-
- if ( $record->current_user_can('update') ) {
- hyperlink(
- label => _("Edit"),
- class => "editlink",
- onclick => {
- popout => $self->fragment_for('update'),
- args => { id => $record->id },
- },
- );
- }
-};
-
template 'objects' => page { title => _('Applied Objects for Custom Field') }
content {
my $self = shift;
diff --git a/lib/RT/View/Admin/Global/Templates.pm b/lib/RT/View/Admin/Global/Templates.pm
index 110baad..dbf650a 100644
--- a/lib/RT/View/Admin/Global/Templates.pm
+++ b/lib/RT/View/Admin/Global/Templates.pm
@@ -59,22 +59,6 @@ use constant display_columns => qw(id name description type);
use constant edit_columns => qw(name description type content queue);
use constant create_columns => qw(name description type content queue);
-private template view_item_controls => sub {
- my $self = shift;
- my $record = shift;
-
- if ( $record->current_user_can('update') ) {
- hyperlink(
- label => _("Edit"),
- class => "editlink",
- onclick => {
- popout => $self->fragment_for('update'),
- args => { id => $record->id },
- },
- );
- }
-};
-
sub _current_collection {
my $self = shift;
my $collection = $self->SUPER::_current_collection( @_ );
diff --git a/lib/RT/View/Admin/Groups.pm b/lib/RT/View/Admin/Groups.pm
index 44fe77b..66df1d1 100644
--- a/lib/RT/View/Admin/Groups.pm
+++ b/lib/RT/View/Admin/Groups.pm
@@ -64,24 +64,6 @@ sub _current_collection {
return $c;
}
-private template view_item_controls => sub {
-
- my $self = shift;
- my $record = shift;
-
- if ( $record->current_user_can('update') ) {
- hyperlink(
- label => _("Edit"),
- class => "editlink",
- onclick => {
- popout => $self->fragment_for('update'),
- args => { id => $record->id },
- },
- );
- }
-};
-
-
template 'select_custom_fields' =>
page { title => _('Select Custom Fields for Group') } content {
my $self = shift;
diff --git a/lib/RT/View/Admin/Queues.pm b/lib/RT/View/Admin/Queues.pm
index 1966547..4e95343 100644
--- a/lib/RT/View/Admin/Queues.pm
+++ b/lib/RT/View/Admin/Queues.pm
@@ -69,22 +69,6 @@ sub view_field_status_schema {
return $action->record->status_schema->name;
}
-private template view_item_controls => sub {
- my $self = shift;
- my $record = shift;
-
- if ( $record->current_user_can('update') ) {
- hyperlink(
- label => _("Edit"),
- class => "editlink",
- onclick => {
- popout => $self->fragment_for('update'),
- args => { id => $record->id },
- },
- );
- }
-};
-
template 'index.html' => page {
title => shift->page_title,
} content {
diff --git a/lib/RT/View/Admin/Queues/Templates.pm b/lib/RT/View/Admin/Queues/Templates.pm
index d7f5a9d..ffb243b 100644
--- a/lib/RT/View/Admin/Queues/Templates.pm
+++ b/lib/RT/View/Admin/Queues/Templates.pm
@@ -59,22 +59,6 @@ use constant display_columns => qw(id name description type);
use constant edit_columns => qw(name description type content queue);
use constant create_columns => qw(name description type content queue);
-private template view_item_controls => sub {
- my $self = shift;
- my $record = shift;
-
- if ( $record->current_user_can('update') ) {
- hyperlink(
- label => _("Edit"),
- class => "editlink",
- onclick => {
- popout => $self->fragment_for('update'),
- args => { id => $record->id },
- },
- );
- }
-};
-
sub _current_collection {
my $self = shift;
my $collection = $self->SUPER::_current_collection( @_ );
diff --git a/lib/RT/View/Admin/Users.pm b/lib/RT/View/Admin/Users.pm
index 68c0f73..a8ef1e4 100644
--- a/lib/RT/View/Admin/Users.pm
+++ b/lib/RT/View/Admin/Users.pm
@@ -67,23 +67,6 @@ use constant edit_columns => qw(name email real_name nickname gecos lang
# contact_info_system external_auth_id auth_system
# time_zone
-private template view_item_controls => sub {
-
- my $self = shift;
- my $record = shift;
-
- if ( $record->current_user_can('update') ) {
- hyperlink(
- label => _("Edit"),
- class => "editlink",
- onclick => {
- popout => $self->fragment_for('update'),
- args => { id => $record->id },
- },
- );
- }
-};
-
# limit to privileged users
sub _current_collection {
my $self = shift;
diff --git a/lib/RT/View/CRUD.pm b/lib/RT/View/CRUD.pm
index dd91b74..8ada4d8 100644
--- a/lib/RT/View/CRUD.pm
+++ b/lib/RT/View/CRUD.pm
@@ -70,9 +70,6 @@ template 'index.html' => page {
}
};
-# no inline edit
-private template view_item_controls => sub { };
-
sub view_via_callback {
my $self = shift;
my %args = @_;
@@ -97,4 +94,5 @@ sub view_via_callback {
return;
}
+
1;
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list