[Rt-commit] rt branch, admin_ui, updated. 6921c5e0266bfd7f4c471c4a5fbbd963f23048e0

[sunnavy at bestpractical.com]

The branch, admin_ui has been updated
       via  6921c5e0266bfd7f4c471c4a5fbbd963f23048e0 (commit)
      from  83800fced55b56437f1c645a60b560d3e998e3ac (commit)

Summary of changes:
 lib/RT/View/Admin/CustomFields.pm |   21 ---------------------
 lib/RT/View/Admin/Groups.pm       |   20 --------------------
 lib/RT/View/Admin/Queues.pm       |   21 ---------------------
 lib/RT/View/Admin/Users.pm        |   20 --------------------
 lib/RT/View/CRUD.pm               |   26 ++++++++++++++++++++++++++
 5 files changed, 26 insertions(+), 82 deletions(-)

- Log -----------------------------------------------------------------
commit 6921c5e0266bfd7f4c471c4a5fbbd963f23048e0
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Dec 25 12:46:38 2009 +0800

    reduce duplication

diff --git a/lib/RT/View/Admin/CustomFields.pm b/lib/RT/View/Admin/CustomFields.pm
index d705a83..8f34a67 100644
--- a/lib/RT/View/Admin/CustomFields.pm
+++ b/lib/RT/View/Admin/CustomFields.pm
@@ -123,26 +123,5 @@ private template 'rights' => sub {
     };
 };
 
-sub view_field {
-    my $self = shift;
-    my %args = @_;
-    if ( $args{field} =~ /^(id|name)$/ ) {
-        $self->view_via_callback(
-            %args,
-            callback => sub {
-                my %args = @_;
-                hyperlink(
-                    label => $args{current_value},
-                    url   => "?id=" . $args{id},
-                );
-            }
-        );
-
-    }
-    else {
-        $self->SUPER::view_field(@_);
-    }
-}
-
 1;
 
diff --git a/lib/RT/View/Admin/Groups.pm b/lib/RT/View/Admin/Groups.pm
index 43360a0..60952eb 100644
--- a/lib/RT/View/Admin/Groups.pm
+++ b/lib/RT/View/Admin/Groups.pm
@@ -189,26 +189,6 @@ private template 'rights' => sub {
     };
 };
 
-sub view_field {
-    my $self = shift;
-    my %args = @_;
-    if ( $args{field} =~ /^(id|name)$/ ) {
-        $self->view_via_callback(
-            %args,
-            callback => sub {
-                my %args = @_;
-                hyperlink(
-                    label => $args{current_value},
-                    url   => "?id=" . $args{id},
-                );
-            }
-        );
-
-    }
-    else {
-        $self->SUPER::view_field(@_);
-    }
-}
 
 1;
 
diff --git a/lib/RT/View/Admin/Queues.pm b/lib/RT/View/Admin/Queues.pm
index d29287d..732e0b6 100644
--- a/lib/RT/View/Admin/Queues.pm
+++ b/lib/RT/View/Admin/Queues.pm
@@ -193,27 +193,6 @@ sub queue {
     return $queue;
 }
 
-sub view_field {
-    my $self = shift;
-    my %args = @_;
-    if ( $args{field} =~ /^(id|name)$/ ) {
-        $self->view_via_callback(
-            %args,
-            callback => sub {
-                my %args = @_;
-                hyperlink(
-                    label => $args{current_value},
-                    url   => "?id=" . $args{id},
-                );
-            }
-        );
-
-    }
-    else {
-        $self->SUPER::view_field(@_);
-    }
-}
-
 
 1;
 
diff --git a/lib/RT/View/Admin/Users.pm b/lib/RT/View/Admin/Users.pm
index b152dfa..8bd9be1 100644
--- a/lib/RT/View/Admin/Users.pm
+++ b/lib/RT/View/Admin/Users.pm
@@ -275,26 +275,6 @@ template 'my_rt' => page { title => _('MyRT for User') } content {
 
 };
 
-sub view_field {
-    my $self = shift;
-    my %args = @_;
-    if ( $args{field} =~ /^(id|name)$/ ) {
-        $self->view_via_callback(
-            %args,
-            callback => sub {
-                my %args = @_;
-                hyperlink(
-                    label => $args{current_value},
-                    url   => "?id=" . $args{id},
-                );
-            }
-        );
-
-    }
-    else {
-        $self->SUPER::view_field(@_);
-    }
-}
 
 1;
 
diff --git a/lib/RT/View/CRUD.pm b/lib/RT/View/CRUD.pm
index 8ada4d8..7e4a362 100644
--- a/lib/RT/View/CRUD.pm
+++ b/lib/RT/View/CRUD.pm
@@ -94,5 +94,31 @@ sub view_via_callback {
     return;
 }
 
+sub view_field {
+    my $self = shift;
+    my %args = @_;
+
+# we just want to do this hyperlink thing for those specfic views
+    if (
+        $self =~ /(Users|Groups|Queues|CustomFields)$/
+        && $args{field} =~ /^(id|name)$/
+      )
+    {
+        $self->view_via_callback(
+            %args,
+            callback => sub {
+                my %args = @_;
+                hyperlink(
+                    label => $args{current_value},
+                    url   => "?id=" . $args{id},
+                );
+            }
+        );
+    }
+    else {
+        $self->SUPER::view_field(@_);
+    }
+}
+
 
 1;

-----------------------------------------------------------------------