[Rt-commit] r18145 - in rt/3.999/branches/merge_to_3.8.2: . lib/RT/Approval/Rule

[sunnavy at bestpractical.com]

Author: sunnavy
Date: Tue Feb  3 06:59:18 2009
New Revision: 18145

Modified:
   rt/3.999/branches/merge_to_3.8.2/   (props changed)
   rt/3.999/branches/merge_to_3.8.2/lib/RT/Approval/Rule/Created.pm
   rt/3.999/branches/merge_to_3.8.2/lib/RT/Approval/Rule/NewPending.pm
   rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Group.pm
   rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/ScripActionCollection.pm
   rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Ticket.pm
   rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Transaction.pm
   rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/User.pm

Log:
 r19471 at sunnavys-mb:  sunnavy | 2009-02-03 19:53:44 +0800
 txn->type is lower_case


Modified: rt/3.999/branches/merge_to_3.8.2/lib/RT/Approval/Rule/Created.pm
==============================================================================
--- rt/3.999/branches/merge_to_3.8.2/lib/RT/Approval/Rule/Created.pm	(original)
+++ rt/3.999/branches/merge_to_3.8.2/lib/RT/Approval/Rule/Created.pm	Tue Feb  3 06:59:18 2009
@@ -59,7 +59,7 @@
     my $self = shift;
     return unless $self->SUPER::prepare();
 
-    $self->transaction_obj->type eq 'Create' &&
+    $self->transaction_obj->type eq 'create' &&
     !$self->ticket_obj->has_unresolved_dependencies( type => 'approval' );
 }
 

Modified: rt/3.999/branches/merge_to_3.8.2/lib/RT/Approval/Rule/NewPending.pm
==============================================================================
--- rt/3.999/branches/merge_to_3.8.2/lib/RT/Approval/Rule/NewPending.pm	(original)
+++ rt/3.999/branches/merge_to_3.8.2/lib/RT/Approval/Rule/NewPending.pm	Tue Feb  3 06:59:18 2009
@@ -67,7 +67,7 @@
     my $t = $self->ticket_obj->transactions;
     my $to;
     while ( my $o = $t->next ) {
-        $to = $o, last if $o->type eq 'Create';
+        $to = $o, last if $o->type eq 'create';
     }
 
     # XXX: this makes the owner incorrect so notify owner won't work

Modified: rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Group.pm
==============================================================================
--- rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Group.pm	(original)
+++ rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Group.pm	Tue Feb  3 06:59:18 2009
@@ -441,7 +441,7 @@
     );
 
     if ( $args{'_record_transaction'} ) {
-        $self->_new_transaction( type => "Create" );
+        $self->_new_transaction( type => "create" );
     }
 
     Jifty->handle->commit() unless $inside_transaction;

Modified: rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/ScripActionCollection.pm
==============================================================================
--- rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/ScripActionCollection.pm	(original)
+++ rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/ScripActionCollection.pm	Tue Feb  3 06:59:18 2009
@@ -89,7 +89,7 @@
         entry_aggregator => 'OR',
         column           => 'type',
         value            => "correspond"
-    ) if $type eq "Create";
+    ) if $type eq "create";
     $self->limit(
         entry_aggregator => 'OR',
         column           => 'type',

Modified: rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Ticket.pm
==============================================================================
--- rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Ticket.pm	(original)
+++ rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Ticket.pm	Tue Feb  3 06:59:18 2009
@@ -636,9 +636,9 @@
     # {{{ Deal with setting up links
 
     # TODO: Adding link may fire scrips on other end and those scrips
-    # could create transactions on this ticket before 'Create' transaction.
+    # could create transactions on this ticket before 'create' transaction.
     #
-    # We should implement different schema: record 'Create' transaction,
+    # We should implement different schema: record 'create' transaction,
     # create links and only then fire create transaction's scrips.
     #
     # Ideal variant: add all links without firing scrips, record create
@@ -706,7 +706,7 @@
 
         # {{{ Add a transaction for the create
         my ( $Trans, $Msg, $TransObj ) = $self->_new_transaction(
-            type          => "Create",
+            type          => "create",
             time_taken    => $args{'time_worked'},
             mime_obj      => $args{'mime_obj'},
             commit_scrips => !$args{'dry_run'},

Modified: rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Transaction.pm
==============================================================================
--- rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Transaction.pm	(original)
+++ rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Transaction.pm	Tue Feb  3 06:59:18 2009
@@ -755,7 +755,7 @@
 
     my $obj_type = $self->friendly_object_type;
 
-    if ( $type eq 'Create' ) {
+    if ( $type eq 'create' ) {
         return ( _( "%1 Created", $obj_type ) );
     } elsif ( $type =~ /Status/i ) {
         if ( $self->field eq 'Status' ) {

Modified: rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/User.pm
==============================================================================
--- rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/User.pm	(original)
+++ rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/User.pm	Tue Feb  3 06:59:18 2009
@@ -296,7 +296,7 @@
     }
 
     if ($record_transaction) {
-        $self->_new_transaction( type => "Create" );
+        $self->_new_transaction( type => "create" );
     }
 
     Jifty->handle->commit;