[Rt-commit] r18159 - in rt/3.999/branches/merge_to_3.8.2: . lib/RT/Model

[sunnavy at bestpractical.com]

Author: sunnavy
Date: Wed Feb  4 02:50:53 2009
New Revision: 18159

Modified:
   rt/3.999/branches/merge_to_3.8.2/   (props changed)
   rt/3.999/branches/merge_to_3.8.2/lib/RT/Condition/CloseTicket.pm
   rt/3.999/branches/merge_to_3.8.2/lib/RT/Condition/ReopenTicket.pm
   rt/3.999/branches/merge_to_3.8.2/lib/RT/Condition/StatusChange.pm
   rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Group.pm
   rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Ticket.pm
   rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Transaction.pm
   rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/User.pm

Log:
 r19491 at sunnavys-mb:  sunnavy | 2009-02-04 13:28:10 +0800
 case fixes


Modified: rt/3.999/branches/merge_to_3.8.2/lib/RT/Condition/CloseTicket.pm
==============================================================================
--- rt/3.999/branches/merge_to_3.8.2/lib/RT/Condition/CloseTicket.pm	(original)
+++ rt/3.999/branches/merge_to_3.8.2/lib/RT/Condition/CloseTicket.pm	Wed Feb  4 02:50:53 2009
@@ -65,8 +65,8 @@
 
     my $txn = $self->transaction_obj;
     return 0
-        unless $txn->type eq "Status"
-            || ( $txn->type eq "Set" && $txn->field eq "Status" );
+        unless $txn->type eq "status"
+            || ( $txn->type eq "set" && $txn->field eq "status" );
 
     my $queue = $self->ticket_obj->queue;
     return 0 unless $queue->status_schema->is_active( $txn->old_value );

Modified: rt/3.999/branches/merge_to_3.8.2/lib/RT/Condition/ReopenTicket.pm
==============================================================================
--- rt/3.999/branches/merge_to_3.8.2/lib/RT/Condition/ReopenTicket.pm	(original)
+++ rt/3.999/branches/merge_to_3.8.2/lib/RT/Condition/ReopenTicket.pm	Wed Feb  4 02:50:53 2009
@@ -65,8 +65,8 @@
 
     my $txn = $self->transaction_obj;
     return 0
-        unless $txn->type eq "Status"
-            || ( $txn->type eq "Set" && $txn->field eq "Status" );
+        unless $txn->type eq "status"
+            || ( $txn->type eq "set" && $txn->field eq "status" );
 
     my $queue = $self->ticket_obj->queue;
     return 0 unless $queue->status_schema->is_inactive( $txn->old_value );

Modified: rt/3.999/branches/merge_to_3.8.2/lib/RT/Condition/StatusChange.pm
==============================================================================
--- rt/3.999/branches/merge_to_3.8.2/lib/RT/Condition/StatusChange.pm	(original)
+++ rt/3.999/branches/merge_to_3.8.2/lib/RT/Condition/StatusChange.pm	Wed Feb  4 02:50:53 2009
@@ -58,7 +58,7 @@
 
 sub is_applicable {
     my $self = shift;
-    if (    ( $self->transaction_obj->field eq 'Status' )
+    if (    ( $self->transaction_obj->field eq 'status' )
         and ( $self->argument eq $self->transaction_obj->new_value() ) )
     {
         return (1);

Modified: rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Group.pm
==============================================================================
--- rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Group.pm	(original)
+++ rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Group.pm	Wed Feb  4 02:50:53 2009
@@ -1141,7 +1141,7 @@
     my %args = (
         column             => undef,
         value              => undef,
-        transaction_type   => 'Set',
+        transaction_type   => 'set',
         record_transaction => 1,
         @_
     );

Modified: rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Ticket.pm
==============================================================================
--- rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Ticket.pm	(original)
+++ rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Ticket.pm	Wed Feb  4 02:50:53 2009
@@ -2253,7 +2253,7 @@
 Takes two arguments:
      the id or name of the owner 
 and  (optionally) the type of the SetOwner Transaction. It defaults
-to 'Give'.  'Steal' is also a valid option.
+to 'give'.  'steal' is also a valid option.
 
 
 =cut
@@ -2261,7 +2261,7 @@
 sub set_owner {
     my $self     = shift;
     my $NewOwner = shift;
-    my $Type     = shift || "Give";
+    my $Type     = shift || "give";
 
     Jifty->handle->begin_transaction();
 

Modified: rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Transaction.pm
==============================================================================
--- rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Transaction.pm	(original)
+++ rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/Transaction.pm	Wed Feb  4 02:50:53 2009
@@ -757,8 +757,8 @@
 
     if ( $type eq 'create' ) {
         return ( _( "%1 Created", $obj_type ) );
-    } elsif ( $type =~ /Status/i ) {
-        if ( $self->field eq 'Status' ) {
+    } elsif ( $type eq 'status' ) {
+        if ( $self->field eq 'status' ) {
             if ( $self->new_value eq 'deleted' ) {
                 return ( _( "%1 deleted", $obj_type ) );
             }

Modified: rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/User.pm
==============================================================================
--- rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/User.pm	(original)
+++ rt/3.999/branches/merge_to_3.8.2/lib/RT/Model/User.pm	Wed Feb  4 02:50:53 2009
@@ -1220,7 +1220,7 @@
     my %args = (
         column             => undef,
         value              => undef,
-        transaction_type   => 'Set',
+        transaction_type   => 'set',
         record_transaction => 1,
         @_
     );