[Rt-commit] r18565 - in rt/3.999/trunk: . lib/RT lib/RT/Model share/html/Ticket/Elements

[sartak at bestpractical.com]

Author: sartak
Date: Tue Feb 24 20:26:55 2009
New Revision: 18565

Modified:
   rt/3.999/trunk/   (props changed)
   rt/3.999/trunk/etc/initialdata
   rt/3.999/trunk/lib/RT/Model/Attachment.pm
   rt/3.999/trunk/lib/RT/Model/Transaction.pm
   rt/3.999/trunk/lib/RT/Record.pm
   rt/3.999/trunk/share/html/Ticket/Elements/ShowAttachments
   rt/3.999/trunk/share/html/Ticket/Elements/ShowDates
   rt/3.999/trunk/share/html/Ticket/Elements/ShowTransaction

Log:
 r80523 at onn:  sartak | 2009-02-24 20:26:45 -0500
 Remove last_updated_as_string and created_as_strings - RT::DateTime objects just have stringification overloading


Modified: rt/3.999/trunk/etc/initialdata
==============================================================================
--- rt/3.999/trunk/etc/initialdata	(original)
+++ rt/3.999/trunk/etc/initialdata	Tue Feb 24 20:26:55 2009
@@ -231,7 +231,7 @@
        content     => 'RT-Attach-Message: yes
 
 
-{$transaction->created_as_string}: Request {$ticket->id} was acted upon.
+{$transaction->created}: Request {$ticket->id} was acted upon.
 Transaction: {$transaction->description}
        Queue: {$ticket->queue->name}
      Subject: {$transaction->subject || $ticket->subject || "(No subject given)"}

Modified: rt/3.999/trunk/lib/RT/Model/Attachment.pm
==============================================================================
--- rt/3.999/trunk/lib/RT/Model/Attachment.pm	(original)
+++ rt/3.999/trunk/lib/RT/Model/Attachment.pm	Tue Feb 24 20:26:55 2009
@@ -410,7 +410,7 @@
 
         $body =~ s/^/> /gm;
 
-        $body = '[' . $self->transaction_obj->creator_obj->name() . ' - ' . $self->transaction_obj->created_as_string() . "]:\n\n" . $body . "\n\n";
+        $body = '[' . $self->transaction_obj->creator_obj->name() . ' - ' . $self->transaction_obj->created . "]:\n\n" . $body . "\n\n";
 
     } else {
         $body = "[Non-text message not quoted]\n\n";

Modified: rt/3.999/trunk/lib/RT/Model/Transaction.pm
==============================================================================
--- rt/3.999/trunk/lib/RT/Model/Transaction.pm	(original)
+++ rt/3.999/trunk/lib/RT/Model/Transaction.pm	Tue Feb 24 20:26:55 2009
@@ -560,7 +560,7 @@
         }
 
         $content =~ s/^/> /gm;
-        $content = _( "On %1, %2 wrote:", $self->created_as_string, $self->creator_obj->name ) . "\n$content\n\n";
+        $content = _( "On %1, %2 wrote:", $self->created, $self->creator_obj->name ) . "\n$content\n\n";
     }
 
     return ($content);

Modified: rt/3.999/trunk/lib/RT/Record.pm
==============================================================================
--- rt/3.999/trunk/lib/RT/Record.pm	(original)
+++ rt/3.999/trunk/lib/RT/Record.pm	Tue Feb 24 20:26:55 2009
@@ -378,29 +378,6 @@
 }
 
 
-
-# TODO this should be deprecated
-
-sub last_updated_as_string {
-    my $self = shift;
-    if ( $self->last_updated ) {
-        return ( $self->last_updated_obj->as_string() );
-
-    } else {
-        return "never";
-    }
-}
-
-
-#
-# TODO This should be deprecated
-#
-sub created_as_string {
-    my $self = shift;
-    return ( $self->created_obj->as_string() );
-}
-
-
 #
 # TODO This should be deprecated
 #

Modified: rt/3.999/trunk/share/html/Ticket/Elements/ShowAttachments
==============================================================================
--- rt/3.999/trunk/share/html/Ticket/Elements/ShowAttachments	(original)
+++ rt/3.999/trunk/share/html/Ticket/Elements/ShowAttachments	Tue Feb 24 20:26:55 2009
@@ -72,7 +72,7 @@
 
 <li><font size="-2">
 <a href="<%RT->config->get('WebPath')%>/Ticket/Attachment/<%$rev->transaction_id%>/<%$rev->id%>/<%$rev->filename | u%>">
-<&|/l, $rev->created_as_string, $size, $rev->creator_obj->name &>%1 (%2) by %3</&>
+<&|/l, $rev->created, $size, $rev->creator_obj->name &>%1 (%2) by %3</&>
 </a>
 </font></li>
 % }

Modified: rt/3.999/trunk/share/html/Ticket/Elements/ShowDates
==============================================================================
--- rt/3.999/trunk/share/html/Ticket/Elements/ShowDates	(original)
+++ rt/3.999/trunk/share/html/Ticket/Elements/ShowDates	Tue Feb 24 20:26:55 2009
@@ -77,7 +77,7 @@
   </tr>
   <tr>
     <td class="label date updated"><&|/l&>Updated</&>:</td>
-% my $UpdatedString = $ticket->last_updated ? _("%1 by %2", $ticket->last_updated_as_string, $ticket->last_updated_by_obj->name) : _("Never");
+% my $UpdatedString = $ticket->last_updated ? _("%1 by %2", $ticket->last_updated, $ticket->last_updated_by_obj->name) : _("Never");
 % if ($updated_link) {
     <td class="value date updated"><a href="#lasttrans"><% $UpdatedString | h %></a></td>
 % } else {

Modified: rt/3.999/trunk/share/html/Ticket/Elements/ShowTransaction
==============================================================================
--- rt/3.999/trunk/share/html/Ticket/Elements/ShowTransaction	(original)
+++ rt/3.999/trunk/share/html/Ticket/Elements/ShowTransaction	Tue Feb 24 20:26:55 2009
@@ -121,7 +121,7 @@
 </%ONCE>
 <%INIT>
 
-my $transdate = $transaction->created_as_string();
+my $transdate = $transaction->created;
 $transdate =~ s/\s/&nbsp;/g;
 
 my ($type, $field) = ($transaction->type, $transaction->field || '');