[Rt-commit] r18574 - in rt/3.999/trunk: . lib/RT/Model lib/RT/ScripAction share/html/Elements/RT__Model__Ticket share/html/Search share/html/Ticket/Elements

[sartak at bestpractical.com]

Author: sartak
Date: Tue Feb 24 21:19:37 2009
New Revision: 18574

Modified:
   rt/3.999/trunk/   (props changed)
   rt/3.999/trunk/lib/RT/Model/Ticket.pm
   rt/3.999/trunk/lib/RT/ScripAction/CreateTickets.pm
   rt/3.999/trunk/share/html/Elements/RT__Model__Ticket/ColumnMap
   rt/3.999/trunk/share/html/Search/Results.tsv
   rt/3.999/trunk/share/html/Ticket/Elements/ShowDates
   rt/3.999/trunk/t/api/ticket.t

Log:
 r80541 at onn:  sartak | 2009-02-24 21:19:33 -0500
 Remove resolved_obj


Modified: rt/3.999/trunk/lib/RT/Model/Ticket.pm
==============================================================================
--- rt/3.999/trunk/lib/RT/Model/Ticket.pm	(original)
+++ rt/3.999/trunk/lib/RT/Model/Ticket.pm	Tue Feb 24 21:19:37 2009
@@ -1388,22 +1388,6 @@
 
 
 
-=head2 resolved_obj
-
-  Returns an RT::Date object of this ticket's 'resolved' time.
-
-=cut
-
-sub resolved_obj {
-    my $self = shift;
-
-    my $time = RT::Date->new();
-    $time->set( format => 'sql', value => $self->resolved );
-    return $time;
-}
-
-
-
 =head2 set_started
 
 Takes a date in ISO format or undef

Modified: rt/3.999/trunk/lib/RT/ScripAction/CreateTickets.pm
==============================================================================
--- rt/3.999/trunk/lib/RT/ScripAction/CreateTickets.pm	(original)
+++ rt/3.999/trunk/lib/RT/ScripAction/CreateTickets.pm	Tue Feb 24 21:19:37 2009
@@ -938,7 +938,7 @@
     $string .= "Due: " . $t->due_obj->as_string . "\n";
     $string .= "Starts: " . $t->starts . "\n";
     $string .= "Started: " . $t->started_obj->as_string . "\n";
-    $string .= "Resolved: " . $t->resolved_obj->as_string . "\n";
+    $string .= "Resolved: " . $t->resolved . "\n";
     $string .= "Owner: " . $t->owner->name . "\n";
     $string .= "Requestor: " . $t->role_group("requestor")->member_emails_as_string . "\n";
     $string .= "Cc: " . $t->role_group("cc")->member_emails_as_string . "\n";
@@ -989,7 +989,7 @@
     $string .= "Due: " . $t->due_obj->epoch . "\n";
     $string .= "Starts: " . $t->starts->epoch . "\n";
     $string .= "Started: " . $t->started_obj->epoch . "\n";
-    $string .= "Resolved: " . $t->resolved_obj->epoch . "\n";
+    $string .= "Resolved: " . $t->resolved->epoch . "\n";
     $string .= "Owner: " . $t->owner . "\n";
     $string .= "Requestor: " . $t->role_group("requestor")->member_emails_as_string . "\n";
     $string .= "Cc: " . $t->role_group("cc")->member_emails_as_string . "\n";

Modified: rt/3.999/trunk/share/html/Elements/RT__Model__Ticket/ColumnMap
==============================================================================
--- rt/3.999/trunk/share/html/Elements/RT__Model__Ticket/ColumnMap	(original)
+++ rt/3.999/trunk/share/html/Elements/RT__Model__Ticket/ColumnMap	Tue Feb 24 21:19:37 2009
@@ -209,7 +209,7 @@
     resolved_relative => {
         title     => 'Resolved', # loc
         attribute => 'resolved',
-        value     => sub  { return $_[0]->resolved_obj->age }
+        value     => sub  { return $_[0]->resolved->age }
     },
     starts => {
         title     => 'Starts', # loc
@@ -234,7 +234,7 @@
     resolved => {
         title     => 'Resolved', # loc
         attribute => 'resolved',
-        value     => sub  { return $_[0]->resolved_obj->as_string }
+        value     => sub  { return $_[0]->resolved }
     },
     update_status => {
         title => 'New messages', # loc

Modified: rt/3.999/trunk/share/html/Search/Results.tsv
==============================================================================
--- rt/3.999/trunk/share/html/Search/Results.tsv	(original)
+++ rt/3.999/trunk/share/html/Search/Results.tsv	Tue Feb 24 21:19:37 2009
@@ -71,7 +71,7 @@
 
 my @attrs = qw( id queue_obj->name subject status time_estimated time_worked time_left priority final_priority owner_obj->name 
                 requestors->member_emails_as_string cc->member_emails_as_string admin_cc->member_emails_as_string
-                due_obj->iso told_obj->iso created->iso resolved_obj->iso last_updated->iso);
+                due_obj->iso told_obj->iso created->iso resolved->iso last_updated->iso);
 
 $r->content_type('application/vnd.ms-excel');
 while ( my $Ticket = $Tickets->next()) {

Modified: rt/3.999/trunk/share/html/Ticket/Elements/ShowDates
==============================================================================
--- rt/3.999/trunk/share/html/Ticket/Elements/ShowDates	(original)
+++ rt/3.999/trunk/share/html/Ticket/Elements/ShowDates	Tue Feb 24 21:19:37 2009
@@ -73,7 +73,7 @@
   </tr>
   <tr>
     <td class="label date resolved"><&|/l&>Closed</&>:</td>
-    <td class="value date resolved"><% $ticket->resolved_obj->as_string  %></td>
+    <td class="value date resolved"><% $ticket->resolved  %></td>
   </tr>
   <tr>
     <td class="label date updated"><&|/l&>Updated</&>:</td>

Modified: rt/3.999/trunk/t/api/ticket.t
==============================================================================
--- rt/3.999/trunk/t/api/ticket.t	(original)
+++ rt/3.999/trunk/t/api/ticket.t	Tue Feb 24 21:19:37 2009
@@ -96,7 +96,7 @@
 ok ( my $id = $t->id, "Got ticket id");
 like ($t->refers_to->first->target , qr/fsck.com/, "Got refers to");
 like ($t->referred_to_by->first->base , qr/cpan.org/, "Got referredtoby");
-is ($t->resolved_obj->epoch, 0, "It hasn't been resolved - ". $t->resolved_obj->epoch);
+is ($t->resolved->epoch, 0, "It hasn't been resolved - ". $t->resolved->epoch);
 
 
 my $ticket = RT::Model::Ticket->new(current_user => RT->system_user);