[Rt-commit] r17941 - in rt/3.8/trunk: .

falcone at bestpractical.com falcone at bestpractical.com
Tue Jan 27 15:56:38 EST 2009


Author: falcone
Date: Tue Jan 27 15:56:37 2009
New Revision: 17941

Modified:
   rt/3.8/trunk/   (props changed)
   rt/3.8/trunk/share/html/NoAuth/js/scriptaculous/controls.js

Log:
 r43961 at ketch:  falcone | 2009-01-27 15:56:22 -0500
 * local modification to avoid browser jumping when you try to use 
   the keyboard to move up and down in an autocompleted list


Modified: rt/3.8/trunk/share/html/NoAuth/js/scriptaculous/controls.js
==============================================================================
--- rt/3.8/trunk/share/html/NoAuth/js/scriptaculous/controls.js	(original)
+++ rt/3.8/trunk/share/html/NoAuth/js/scriptaculous/controls.js	Tue Jan 27 15:56:37 2009
@@ -1,3 +1,9 @@
+// LOCAL BEST PRACTICAL MODIFICATIONS
+// lines 218 and 224, removing scrollIntoView
+// Leaving these in causes autocomplete lists to flip out and jump
+// the screen around if the length of the returned list is anywhere 
+// near the size of the viewport
+//
 // script.aculo.us controls.js v1.8.2, Tue Nov 18 18:30:58 +0100 2008
 
 // Copyright (c) 2005-2008 Thomas Fuchs (http://script.aculo.us, http://mir.aculo.us)
@@ -213,13 +219,13 @@
   markPrevious: function() {
     if(this.index > 0) this.index--;
       else this.index = this.entryCount-1;
-    this.getEntry(this.index).scrollIntoView(true);
+    //this.getEntry(this.index).scrollIntoView(true);
   },
 
   markNext: function() {
     if(this.index < this.entryCount-1) this.index++;
       else this.index = 0;
-    this.getEntry(this.index).scrollIntoView(false);
+    //this.getEntry(this.index).scrollIntoView(false);
   },
 
   getEntry: function(index) {
@@ -962,4 +968,4 @@
     this.timer = null;
     this.callback(this.element, $F(this.element));
   }
-});
\ No newline at end of file
+});


More information about the Rt-commit mailing list