[Rt-commit] r18832 - in rt/3.999/branches/lorzy: lib/RT t/api

[clkao at bestpractical.com]

Author: clkao
Date: Wed Mar 18 10:36:47 2009
New Revision: 18832

Modified:
   rt/3.999/branches/lorzy/lib/RT/Lorzy.pm
   rt/3.999/branches/lorzy/lib/RT/Lorzy/Dispatcher.pm
   rt/3.999/branches/lorzy/lib/RT/ScripAction.pm
   rt/3.999/branches/lorzy/t/api/rules-preview.t

Log:
finish up hints infrastructure.


Modified: rt/3.999/branches/lorzy/lib/RT/Lorzy.pm
==============================================================================
--- rt/3.999/branches/lorzy/lib/RT/Lorzy.pm	(original)
+++ rt/3.999/branches/lorzy/lib/RT/Lorzy.pm	Wed Mar 18 10:36:47 2009
@@ -109,7 +109,7 @@
 sub hints {
     my ($self, $ticket_obj, $transaction_obj, $hints) = @_;
     return unless $self->collect_hints;
-    return RT::Lorzy->evaluate( $self->collect_hints, ticket => $ticket_obj, transaction => $transaction_obj, callback => 1);
+    return RT::Lorzy->evaluate( $self->collect_hints, ticket => $ticket_obj, transaction => $transaction_obj, callback => $hints);
 }
 
 sub commit {

Modified: rt/3.999/branches/lorzy/lib/RT/Lorzy/Dispatcher.pm
==============================================================================
--- rt/3.999/branches/lorzy/lib/RT/Lorzy/Dispatcher.pm	(original)
+++ rt/3.999/branches/lorzy/lib/RT/Lorzy/Dispatcher.pm	Wed Mar 18 10:36:47 2009
@@ -31,8 +31,6 @@
 
 sub hints {
     my ($self, $callback) = @_;
-    warn "... hi hints".$self->transaction->object;
-    warn "... hi hints".$self->transaction;
     return unless $self->transaction->object;
     for ( @{$self->{prepared}} ) {
         $_->hints( $self->transaction->object, $self->transaction, $callback );

Modified: rt/3.999/branches/lorzy/lib/RT/ScripAction.pm
==============================================================================
--- rt/3.999/branches/lorzy/lib/RT/ScripAction.pm	(original)
+++ rt/3.999/branches/lorzy/lib/RT/ScripAction.pm	Wed Mar 18 10:36:47 2009
@@ -179,6 +179,11 @@
     return ( 0, _("Prepare Stubbed") );
 }
 
+sub hints {
+    my ($self, $callback) = @_;
+    return;
+}
+
 
 #If this rule applies to this transaction, return true.
 

Modified: rt/3.999/branches/lorzy/t/api/rules-preview.t
==============================================================================
--- rt/3.999/branches/lorzy/t/api/rules-preview.t	(original)
+++ rt/3.999/branches/lorzy/t/api/rules-preview.t	Wed Mar 18 10:36:47 2009
@@ -39,11 +39,7 @@
 }
 
 for (@{$txn->rules}) {
-    warn $_;
-#    warn Dumper($_);
     $_->hints(\&hints_callback);
 }
 
-warn Dumper($preview);
-
-use Data::Dumper;
+warn Dumper($preview);use Data::Dumper;