[Rt-commit] r18841 - rt/3.8/trunk/lib/RT

[jesse at bestpractical.com]

Author: jesse
Date: Wed Mar 18 16:29:42 2009
New Revision: 18841

Modified:
   rt/3.8/trunk/lib/RT/Ticket_Overlay.pm

Log:
* better recovery for corrupt owner groups on ticket owner change

Modified: rt/3.8/trunk/lib/RT/Ticket_Overlay.pm
==============================================================================
--- rt/3.8/trunk/lib/RT/Ticket_Overlay.pm	(original)
+++ rt/3.8/trunk/lib/RT/Ticket_Overlay.pm	Wed Mar 18 16:29:42 2009
@@ -2782,7 +2782,12 @@
     # Delete the owner in the owner group, then add a new one
     # TODO: is this safe? it's not how we really want the API to work
     # for most things, but it's fast.
-    my ( $del_id, $del_msg ) = $self->OwnerGroup->MembersObj->First->Delete();
+    my ( $del_id, $del_msg );
+    for my $owner (@{$self->OwnerGroup->MembersObj->ItemsArrayRef}) {
+        ($del_id, $del_msg) = $owner->Delete();
+        last unless ($del_id);
+    }
+
     unless ($del_id) {
         $RT::Handle->Rollback();
         return ( 0, $self->loc("Could not change owner: [_1]", $del_msg) );