[Rt-commit] r19553 - in rt/3.999/trunk: .

sunnavy at bestpractical.com sunnavy at bestpractical.com
Thu May 7 03:33:49 EDT 2009


Author: sunnavy
Date: Thu May  7 03:33:48 2009
New Revision: 19553

Modified:
   rt/3.999/trunk/   (props changed)
   rt/3.999/trunk/sbin/rt-update-config

Log:
 r20895 at sunnavys-mb (orig r19342):  sunnavy | 2009-04-24 20:29:31 +0800
 Data::Dump can print only values, we do *not* need to fiddle Data::Dumper's outputs anymore :)


Modified: rt/3.999/trunk/sbin/rt-update-config
==============================================================================
--- rt/3.999/trunk/sbin/rt-update-config	(original)
+++ rt/3.999/trunk/sbin/rt-update-config	Thu May  7 03:33:48 2009
@@ -55,6 +55,7 @@
 }
 
 use Getopt::Long;
+use Data::Dump qw/dump/;
 
 my %args;
 die "unknown option"
@@ -74,7 +75,6 @@
     print 'updated with success' . "\n";
 }
 else {
-    use Data::Dumper;
     my %doc;
 
     if ( ! $args{'without-doc'} ) {
@@ -123,9 +123,7 @@
 
     if ( $args{show} ) {
         for my $name ( sort keys %map ) {
-            my $value = Data::Dumper->Dump( [ $map{$name} ], [''] );
-            $value =~ s/^\$ = //;
-            $value =~ s/;\s*$//;
+            my $value = dump( $map{$name} );
             print "$name: $value\n";
         }
     }
@@ -133,9 +131,7 @@
         my $to_be_edited = '';
         for my $name ( sort keys %map ) {
             $to_be_edited .= $doc{$name} || '';
-            my $value = Data::Dumper->Dump( [ $map{$name} ], [''] );
-            $value =~ s/^\$ = //;
-            $value =~ s/;\s*$//;
+            my $value = dump( $map{$name} );
             $to_be_edited .= "set( $name => $value );\n";
             $to_be_edited .= "\n"
               if $doc{$name};    # add an extra blank line to ease eyes


More information about the Rt-commit mailing list