[Rt-commit] r19763 - rt/3.999/trunk/lib/RT

[sartak at bestpractical.com]

Author: sartak
Date: Tue May 26 23:09:06 2009
New Revision: 19763

Modified:
   rt/3.999/trunk/lib/RT/Collection.pm

Log:
Clean up items_order_by

Modified: rt/3.999/trunk/lib/RT/Collection.pm
==============================================================================
--- rt/3.999/trunk/lib/RT/Collection.pm	(original)
+++ rt/3.999/trunk/lib/RT/Collection.pm	Tue May 26 23:09:06 2009
@@ -190,10 +190,12 @@
     my $self  = shift;
     my $items = shift;
 
-    if ( $self->new_item()->can('sort_order') ) {
-        $items = [ sort { $a->sort_order <=> $b->sort_order } @{$items} ];
-    } elsif ( $self->new_item()->can('name') ) {
-        $items = [ sort { lc( $a->name ) cmp lc( $b->name ) } @{$items} ];
+    my $dummy = $self->new_item;
+
+    if ( $dummy->can('sort_order') ) {
+        return [ sort { $a->sort_order <=> $b->sort_order } @{$items} ];
+    } elsif ( $dummy->can('name') ) {
+        return [ sort { lc( $a->name ) cmp lc( $b->name ) } @{$items} ];
     }
 
     return $items;