[Rt-commit] rt branch, 3.999-trunk, updated. da5d00db20d316af38d3d49a802be01c90886d34

[sunnavy at bestpractical.com]

The branch, 3.999-trunk has been updated
       via  da5d00db20d316af38d3d49a802be01c90886d34 (commit)
      from  1cc9e1144e13ae58881e7f01c2f459023c342e55 (commit)

Summary of changes:
 t/api/action-createtickets.t        |    2 +-
 t/approval/basic.t                  |    2 +-
 t/mail/gateway.t                    |    9 ++++++---
 t/web/crypt-gnupg.t                 |    2 +-
 t/web/gnupg-select-keys-on-create.t |    8 +++++---
 t/web/ticket_owner.t                |    2 +-
 6 files changed, 15 insertions(+), 10 deletions(-)

- Log -----------------------------------------------------------------
commit da5d00db20d316af38d3d49a802be01c90886d34
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Nov 5 12:51:27 2009 +0800

    diag info things only when $ENV{TEST_VERBOSE} is true

diff --git a/t/api/action-createtickets.t b/t/api/action-createtickets.t
index 07fee94..8e3f560 100644
--- a/t/api/action-createtickets.t
+++ b/t/api/action-createtickets.t
@@ -60,7 +60,7 @@ my $rule = RT::Lorzy->create_scripish(
     'Approvals',
     'Create approval tickets',
      $q->id);
-diag $rule->condition_code;
+diag $rule->condition_code if $ENV{TEST_VERBOSE};
 my $t = RT::Model::Ticket->new(current_user => RT->system_user);
 my($tid, $ttrans, $tmsg) = $t->create(subject => "Sample workflow test",
            Owner => "root",
diff --git a/t/approval/basic.t b/t/approval/basic.t
index 0867cae..c9fa68a 100644
--- a/t/approval/basic.t
+++ b/t/approval/basic.t
@@ -74,7 +74,7 @@ my $rule = RT::Lorzy->create_scripish(
     'Create approval tickets',
     $q->id,
 );
-diag $rule->condition_code;
+diag $rule->condition_code if $ENV{TEST_VERBOSE};
 my $t = RT::Model::Ticket->new(current_user => RT->system_user);
 my ($tid, $ttrans, $tmsg);
 
diff --git a/t/mail/gateway.t b/t/mail/gateway.t
index 6de1fce..229a248 100644
--- a/t/mail/gateway.t
+++ b/t/mail/gateway.t
@@ -787,9 +787,12 @@ $tick->load( $id );
 is( $tick->owner, $user->id, "we changed owner" );
 ok( $user->has_right( right => 'ReplyToTicket', object => $tick ), "owner can reply to ticket" );
 is( $tick->transactions->count, 5, "transactions added" );
-$txns = $tick->transactions;
-while (my $t = $txns->next) {
-    diag( $t->id, $t->description."\n");
+
+if ( $ENV{TEST_VERBOSE} ) {
+    $txns = $tick->transactions;
+    while ( my $t = $txns->next ) {
+        diag( $t->id, $t->description . "\n" );
+    }
 }
 
 # }}}
diff --git a/t/web/crypt-gnupg.t b/t/web/crypt-gnupg.t
index 754ea39..1083af8 100644
--- a/t/web/crypt-gnupg.t
+++ b/t/web/crypt-gnupg.t
@@ -77,7 +77,7 @@ RT::Test->set_rights(
 );
 
 my ($baseurl, $m) = RT::Test->started_ok;
-diag($baseurl);
+diag($baseurl) if $ENV{TEST_VERBOSE};
 ok $m->login, 'logged in';
 
 $m->get_ok("/Admin/Queues/Modify.html?id=$qid");
diff --git a/t/web/gnupg-select-keys-on-create.t b/t/web/gnupg-select-keys-on-create.t
index 4605e83..29076a8 100644
--- a/t/web/gnupg-select-keys-on-create.t
+++ b/t/web/gnupg-select-keys-on-create.t
@@ -205,7 +205,8 @@ diag "check that things still doesn't work if two keys are not trusted" if $ENV{
     is $res{'info'}[1]{'trust_level'}, 0, 'is not trusted key';
 }
 
-diag "check that we see key selector even if only one key is trusted but there are more keys";
+diag "check that we see key selector even if only one key is trusted but there are more keys" if $ENV{TEST_VERBOSE};
+
 {
     RT::Test->clean_caught_mails;
 
@@ -232,7 +233,8 @@ diag "check that we see key selector even if only one key is trusted but there a
     ok !@mail, 'there are no outgoing emails';
 }
 
-diag "check that key selector works and we can select trusted key";
+diag "check that key selector works and we can select trusted key"
+  if $ENV{TEST_VERBOSE};
 {
     RT::Test->clean_caught_mails;
 
@@ -264,7 +266,7 @@ diag "check that key selector works and we can select trusted key";
     check_text_emails( { encrypt => 1 }, @mail );
 }
 
-diag "check encrypting of attachments";
+diag "check encrypting of attachments" if $ENV{TEST_VERBOSE};
 {
     RT::Test->clean_caught_mails;
 
diff --git a/t/web/ticket_owner.t b/t/web/ticket_owner.t
index dbae4a3..47dcae5 100644
--- a/t/web/ticket_owner.t
+++ b/t/web/ticket_owner.t
@@ -96,7 +96,7 @@ diag "user A can not change owner after create" if $ENV{TEST_VERBOSE};
     my $test_cb = sub  {
         my $agent = shift;
         $agent->goto_ticket( $id );
-        diag("Going to ticket $id");
+        diag("Going to ticket $id") if $ENV{TEST_VERBOSE};
         $agent->follow_link_ok(text => 'Basics');
         my $form = $agent->form_number(3);
         is $agent->action_field_value(

-----------------------------------------------------------------------