[Rt-commit] rt branch, 3.999-trunk, updated. cb410753a342334c86135b2ce200d915d6d18b5a

sunnavy at bestpractical.com sunnavy at bestpractical.com
Tue Nov 17 01:49:55 EST 2009


The branch, 3.999-trunk has been updated
       via  cb410753a342334c86135b2ce200d915d6d18b5a (commit)
      from  1788e830939555b7752a9925401a83237fc048e8 (commit)

Summary of changes:
 TODO                         |    3 ---
 bin/rt-crontool              |    4 ++--
 lib/RT.pm                    |    6 +++---
 lib/RT/Interface/CLI.pm      |    4 ++--
 lib/RT/Shredder.pm           |    4 ++--
 lib/RT/Test.pm               |    2 +-
 lib/RT/Test/Shredder.pm      |    4 ++--
 sbin/rt-attributes-viewer    |    4 ++--
 sbin/rt-clean-sessions       |    2 +-
 sbin/rt-dump-database        |    4 ++--
 sbin/rt-email-dashboards     |    4 ++--
 sbin/rt-email-digest         |    4 ++--
 sbin/rt-email-group-admin    |    4 ++--
 sbin/rt-fulltext-indexer     |    4 ++--
 sbin/rt-setup-fulltext-index |    4 ++--
 sbin/rt-validator            |    4 ++--
 16 files changed, 29 insertions(+), 32 deletions(-)

- Log -----------------------------------------------------------------
commit cb410753a342334c86135b2ce200d915d6d18b5a
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Nov 17 13:22:02 2009 +0800

    use -> when calling RT.pm's sub

diff --git a/TODO b/TODO
index d6954cf..9f3b9ce 100644
--- a/TODO
+++ b/TODO
@@ -3,9 +3,6 @@ things we ripped out that need to be added back
     external auth
     autocreate of users
 
-RT::load_config and other in RT package should be replaced with RT->load_config
-
-
 * create graphviz for templates/elements, orphan ones needs to be documented.
 
 * fresh db, create ticket with body asdf shows "<p>&nbsp;asdf</p>" in the ticket history right after create.
diff --git a/bin/rt-crontool b/bin/rt-crontool
index b35df2e..92680c2 100755
--- a/bin/rt-crontool
+++ b/bin/rt-crontool
@@ -53,7 +53,7 @@ use RT;
 
 use Getopt::Long;
 
-BEGIN { RT::init_jifty(); }
+BEGIN { RT->init_jifty(); }
 
 use RT::Interface::CLI qw(clean_env get_current_user get_message_content );
 use RT::Model::TicketCollection;
@@ -66,7 +66,7 @@ clean_env();
 RT::load_config();
 
 #Connect to the database and get RT->system_user and RT->nobody loaded
-RT::init();
+RT->init();
 
 #Get the current user all loaded
 my $CurrentUser = get_current_user();
diff --git a/lib/RT.pm b/lib/RT.pm
index d3bd38e..f61f66b 100644
--- a/lib/RT.pm
+++ b/lib/RT.pm
@@ -196,7 +196,7 @@ sub system_user {
 
 }
 
-=head2 Nobody
+=head2 nobody
 
 Returns object of Nobody. It's object of L<RT::CurrentUser> class
 that represents a user who can own ticket and nothing else.
@@ -213,7 +213,7 @@ sub nobody {
     return $nobody
 }
 
-=head2 Plugins
+=head2 plugins
 
 Returns a listref of all Plugins currently configured for this RT instance.
 You can define plugins by adding them to the @Plugins list in your RT_SiteConfig
@@ -419,7 +419,7 @@ sub start {
     #XXX TODO RT pages don't play well with Halo right now
     no warnings 'redefine';
     *Jifty::Plugin::Halo::is_proscribed = sub { 1 };
-    RT::init();
+    RT->init();
 
     Jifty->web->add_javascript(
         qw( joose.js titlebox-state.js util.js ahah.js list.js class.js
diff --git a/lib/RT/Interface/CLI.pm b/lib/RT/Interface/CLI.pm
index 32f7807..26b9c1d 100755
--- a/lib/RT/Interface/CLI.pm
+++ b/lib/RT/Interface/CLI.pm
@@ -82,10 +82,10 @@ BEGIN {
   use RT;
 
   #Load RT's config file
-  RT::load_config();
+  RT->load_config();
 
   # Connect to the database. set up loggign
-  RT::Init();
+  RT->init();
 
   #Get the current user all loaded
   my $CurrentUser = get_current_user();
diff --git a/lib/RT/Shredder.pm b/lib/RT/Shredder.pm
index 59829a5..142fa89 100644
--- a/lib/RT/Shredder.pm
+++ b/lib/RT/Shredder.pm
@@ -264,8 +264,8 @@ our %opt = ();
 sub init {
     %opt = @_;
     # XXX: this shouldn't be necessary anymore, as RT.pm does init and config is lazily loaded.
-    RT::load_config();
-    RT::init();
+    RT->load_config();
+    RT->init();
 }
 
 =head4 new
diff --git a/lib/RT/Test.pm b/lib/RT/Test.pm
index 30a3234..762ba5a 100644
--- a/lib/RT/Test.pm
+++ b/lib/RT/Test.pm
@@ -110,7 +110,7 @@ sub setup {
     $self->SUPER::setup($args);
 
     $self->_setup_config(@$args);
-    RT::init();
+    RT->init();
 }
 
 sub _setup_config {
diff --git a/lib/RT/Test/Shredder.pm b/lib/RT/Test/Shredder.pm
index 7e7032a..8a52334 100644
--- a/lib/RT/Test/Shredder.pm
+++ b/lib/RT/Test/Shredder.pm
@@ -61,7 +61,7 @@ Savepoints are named and you can create two or more savepoints.
 
 =head3 rewrite_rtconfig
 
-Call this sub after C<RT::load_config>. Function changes
+Call this sub after C<RT->load_config>. Function changes
 RT config option to switch to local SQLite database.
 
 =cut
@@ -105,7 +105,7 @@ sub config_set {
 
 Creates new RT DB with initial data in the test tmp dir.
 Remove old files in the tmp dir if exist.
-Also runs RT::Init() and init logging.
+Also runs RT->init() and init logging.
 This is all you need to call to setup testing environment
 in common situation.
 
diff --git a/sbin/rt-attributes-viewer b/sbin/rt-attributes-viewer
index 8755d9d..06b15e5 100755
--- a/sbin/rt-attributes-viewer
+++ b/sbin/rt-attributes-viewer
@@ -68,8 +68,8 @@ END
 
 use RT;
 BEGIN { RT->init_jifty }
-RT::load_config();
-RT::init();
+RT->load_config();
+RT->init();
 
 require RT::Model::Attribute;
 my $attr = RT::Model::Attribute->new( current_user => RT->system_user );
diff --git a/sbin/rt-clean-sessions b/sbin/rt-clean-sessions
index 1ca9933..d400f0c 100644
--- a/sbin/rt-clean-sessions
+++ b/sbin/rt-clean-sessions
@@ -78,7 +78,7 @@ if( $opt{'older'} ) {
 use RT;
 BEGIN { RT->init_jifty }
 
-RT::load_config();
+RT->load_config();
 
 if( $opt{'debug'} ) {
     RT->config->set( log_to_screen => 'debug' );
diff --git a/sbin/rt-dump-database b/sbin/rt-dump-database
index da08f73..70c8328 100755
--- a/sbin/rt-dump-database
+++ b/sbin/rt-dump-database
@@ -76,8 +76,8 @@ BEGIN {
 use RT;
 use XML::Simple;
 
-RT::load_config();
-RT::Init();
+RT->load_config();
+RT->init();
 
 my $LocalOnly = @ARGV ? shift(@ARGV) : 1;
 
diff --git a/sbin/rt-email-dashboards b/sbin/rt-email-dashboards
index c944bef..f004e47 100644
--- a/sbin/rt-email-dashboards
+++ b/sbin/rt-email-dashboards
@@ -68,10 +68,10 @@ use POSIX 'tzset';
 clean_env();
 
 # Load the config file
-RT::load_config();
+RT->load_config();
 
 # Connect to the database and get RT->system_user and RT->nobody loaded
-RT::init();
+RT->init();
 
 $HTML::Mason::Commands::r = RT::Dashboard::FakeRequest->new;
 
diff --git a/sbin/rt-email-digest b/sbin/rt-email-digest
index e8a00d1..b008460 100644
--- a/sbin/rt-email-digest
+++ b/sbin/rt-email-digest
@@ -58,8 +58,8 @@ use RT::Interface::CLI qw( clean_env );
 use RT::Interface::Email;
 
 clean_env();
-RT::load_config();
-RT::init();
+RT->load_config();
+RT->init();
 
 sub usage {
     my ($error) = @_;
diff --git a/sbin/rt-email-group-admin b/sbin/rt-email-group-admin
index def948e..3faa41c 100755
--- a/sbin/rt-email-group-admin
+++ b/sbin/rt-email-group-admin
@@ -90,8 +90,8 @@ use strict;
 
 use RT;
 BEGIN { RT->init_jifty }
-RT::load_config;
-RT::init;
+RT->load_config;
+RT->init;
 
 require RT::Principal;
 require RT::Model::User;
diff --git a/sbin/rt-fulltext-indexer b/sbin/rt-fulltext-indexer
index e4840b9..e82dd1a 100644
--- a/sbin/rt-fulltext-indexer
+++ b/sbin/rt-fulltext-indexer
@@ -56,8 +56,8 @@ use RT::Interface::CLI qw{ clean_env };
 use Getopt::Long;
 
 clean_env();
-RT::load_config();
-RT::init();
+RT->load_config();
+RT->init();
 
 no warnings 'once';
 
diff --git a/sbin/rt-setup-fulltext-index b/sbin/rt-setup-fulltext-index
index 0d83d57..4dc70ed 100644
--- a/sbin/rt-setup-fulltext-index
+++ b/sbin/rt-setup-fulltext-index
@@ -56,8 +56,8 @@ use RT::Interface::CLI qw{ clean_env };
 use Getopt::Long;
 
 clean_env();
-RT::load_config();
-RT::init();
+RT->load_config();
+RT->init();
 
 no warnings 'once';
 
diff --git a/sbin/rt-validator b/sbin/rt-validator
index ab9670d..f13d51e 100755
--- a/sbin/rt-validator
+++ b/sbin/rt-validator
@@ -107,8 +107,8 @@ END
 }
 
 use RT;
-RT::load_config();
-RT::init();
+RT->load_config();
+RT->init();
 
 my $dbh = Jifty->handle->dbh;
 my $db_type = $RT::DatabaseType;

-----------------------------------------------------------------------


More information about the Rt-commit mailing list