[Rt-commit] rtir branch, 2.5-greenville, created. c675a4fb1e2fead47131201edd3a9b3a63bbbe53
Kevin Falcone
falcone at bestpractical.com
Tue Nov 17 12:44:20 EST 2009
The branch, 2.5-greenville has been created
at c675a4fb1e2fead47131201edd3a9b3a63bbbe53 (commit)
- Log -----------------------------------------------------------------
commit 6e823e6244c5f1133f875a85570566c1de7f31f1
Author: Kevin Falcone <falcone at bestpractical.com>
Date: Fri Aug 28 16:38:18 2009 -0400
Switch simplesearch over to the buttonless version from rt-3.8
On IE and smaller resolutions, this stops the menu bar from wrapping
really oddly by svaing us some space.
diff --git a/html/RTIR/Elements/SimpleSearch b/html/RTIR/Elements/SimpleSearch
index cfcb7d3..f28d310 100644
--- a/html/RTIR/Elements/SimpleSearch
+++ b/html/RTIR/Elements/SimpleSearch
@@ -24,6 +24,5 @@
<form action="<% RT->Config->Get('WebPath') %>/RTIR/index.html" id="simple-search">
<input type="hidden" name="NewSearch" value="1" />
<input type="hidden" name="Queue" value="Incidents" />
-<input size="12" name="q" accesskey="0" />
-<input type="submit" class="button" value="<&|/l&>Search Incidents</&>" />
+<input size="15" name="q" accesskey="0" value="<&|/l&>Search Incidents</&>..." onfocus="if (this.value=='<&|/l&>Search Incidents</&>...') this.value=''" />
</form>
commit 8c2f4b58481022c3b711e77a008f45ff9255136f
Author: Kevin Falcone <falcone at bestpractical.com>
Date: Fri Aug 28 16:42:09 2009 -0400
Be clear that we're editing RTIR at a Glance
This introduces another translatable string
diff --git a/html/RTIR/Prefs/Home.html b/html/RTIR/Prefs/Home.html
index b6f5217..61f1393 100644
--- a/html/RTIR/Prefs/Home.html
+++ b/html/RTIR/Prefs/Home.html
@@ -5,7 +5,7 @@
<& /Widgets/SelectionBox:header, nojs => 1 &>
% foreach my $box( @boxes ) {
<&|/Widgets/TitleBox,
- title => loc('RT at a glance') .': '. loc( $box->{Name} ),
+ title => loc('RTIR at a glance') .': '. loc( $box->{Name} ),
bodyclass => ""
&>
<& /Widgets/SelectionBox:show, self => $box, nojs => 1 &>
commit b1a6341bfdafa286a4e695238538fa686b3a949b
Author: Kevin Falcone <falcone at bestpractical.com>
Date: Tue Sep 1 16:20:30 2009 -0400
ignore vim swp files
diff --git a/.gitignore b/.gitignore
index 642007d..19902d6 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,3 +3,4 @@ Makefile.old
MANIFEST.bak
blib/
pm_to_blib
+*.swp
commit eae6c5a589e5f997f526b842ca4cb96b0dea15e0
Author: Kevin Falcone <falcone at bestpractical.com>
Date: Tue Sep 1 16:21:50 2009 -0400
silence an annoying warning
diff --git a/html/RTIR/Elements/AddWatchers b/html/RTIR/Elements/AddWatchers
index 956aece..b6389a5 100644
--- a/html/RTIR/Elements/AddWatchers
+++ b/html/RTIR/Elements/AddWatchers
@@ -39,7 +39,7 @@
<tr><td><&|/l&>Type</&></td><td><&|/l&>Group</&></td></tr>
% while ( my $g = $Groups->Next ) {
<tr><td><& /Elements/SelectWatcherType, Name => "Ticket-AddWatcher-Principal-". $g->PrincipalId, Scope => 'queue' &></td>
-<td><% $g->Name %> (<% $g->Description %>)</td></tr>
+<td><% $g->Name %> (<% $g->Description||'' %>)</td></tr>
% }
% }
commit 4a9437168fa983a8e28e5f2445795b33413eb2be
Author: Kevin Falcone <falcone at bestpractical.com>
Date: Sat Oct 17 18:24:31 2009 -0400
Don't display a disabled Constituency during Incident editing
diff --git a/html/RTIR/Incident/Edit.html b/html/RTIR/Incident/Edit.html
index 4ad10d9..5c9dab8 100644
--- a/html/RTIR/Incident/Edit.html
+++ b/html/RTIR/Incident/Edit.html
@@ -69,7 +69,7 @@
<td class="label"><&|/l&>Time Worked</&>:</td>
<td class="value"><input name="TimeWorked" value="<%$Ticket->TimeWorked|h%>" size="5" /></td>
</tr>
-% if ( $constituency_propagation ne 'reject' || !$has_children ) {
+% if ( $constituency_cf && ( $constituency_propagation ne 'reject' || !$has_children )) {
<tr>
<td class="label"><&|/l&>Constituency</&>:</td>
<td class="value">
@@ -126,9 +126,10 @@ $CanRespond = 1 if ( $Ticket->CurrentUserHasRight('ReplyToTicket') or
$CanComment = 1 if ( $Ticket->CurrentUserHasRight('CommentOnTicket') or
$Ticket->CurrentUserHasRight('ModifyTicket') );
+my $constituency_cf = RT::IR->CustomFields( Constituency => Ticket => $Ticket );
my $constituency_propagation = RT->Config->Get('_RTIR_Constituency_Propagation');
my $has_children = 0;
-if ( $constituency_propagation eq 'reject' ) {
+if ( $constituency_cf && $constituency_propagation eq 'reject' ) {
my $query = "( Queue = 'Incident Reports' OR Queue = 'Investigations' OR Queue = 'Blocks' )"
." AND MemberOf = ". $Ticket->id;
my $tickets = RT::Tickets->new( $RT::SystemUser );
commit 8dcb837caccfcb963b08422fe22dab23258da695
Author: Kevin Falcone <falcone at bestpractical.com>
Date: Fri Oct 23 21:11:36 2009 -0400
Don't die, this cached is called when RT::IR is loaded
and the database may not be initialized yet.
diff --git a/lib/RT/IR.pm b/lib/RT/IR.pm
index ffe820f..cca42b4 100644
--- a/lib/RT/IR.pm
+++ b/lib/RT/IR.pm
@@ -238,7 +238,11 @@ sub CustomFields {
my $queue = RT::Queue->new( $RT::SystemUser );
$queue->Load( $qname );
- die "Couldn't load queue '$qname'" unless $queue->id;
+ unless ($queue->id) {
+ $RT::Logger->error("Couldn't load queue '$qname'");
+ delete $cache{$type};
+ return;
+ }
my $cfs = RT::CustomFields->new( $RT::SystemUser );
$cfs->LimitToLookupType( 'RT::Queue-RT::Ticket' );
commit d7115ad0aa8ea082731b89381340b036a78d1fcc
Author: Kevin Falcone <falcone at bestpractical.com>
Date: Mon Oct 26 16:40:04 2009 -0400
use new style callback
diff --git a/html/RTIR/Tools/Elements/Tabs b/html/RTIR/Tools/Elements/Tabs
index 42c8b3f..ea6a491 100644
--- a/html/RTIR/Tools/Elements/Tabs
+++ b/html/RTIR/Tools/Elements/Tabs
@@ -22,7 +22,7 @@
%#
%#
%# END LICENSE BLOCK
-<& /Elements/Callback, tabs => $tabs, %ARGS &>
+% $m->callback( tabs => $tabs, %ARGS );
<& /RTIR/Elements/Tabs,
tabs => $tabs,
current_toptab => $current_toptab,
commit c675a4fb1e2fead47131201edd3a9b3a63bbbe53
Author: Kevin Falcone <falcone at bestpractical.com>
Date: Tue Oct 27 16:35:49 2009 -0400
Hide Launch link if the user can't actually Launch an investigation
(Yes, this is a weird use case, but RTIR works even with pared back
rights on Investigations, except this part is really confusing)
diff --git a/html/RTIR/Incident/Elements/ShowChildren b/html/RTIR/Incident/Elements/ShowChildren
index 809e00c..aec268e 100644
--- a/html/RTIR/Incident/Elements/ShowChildren
+++ b/html/RTIR/Incident/Elements/ShowChildren
@@ -11,7 +11,9 @@
% if ( $IncidentObj->CurrentUserHasRight('ModifyTicket') ) {
<table width="100%"><tr><td align="right"><font size="-1">
+% if ( $QueueObj->Id and $QueueObj->CurrentUserHasRight('CreateTicket') ) {
| <a href="<%RT->Config->Get('WebPath')%>/RTIR/Create.html?Incident=<% $id %>&Queue=<% $Queue |u %>"><% $new_caption %></a>
+% }
| <a href="<%RT->Config->Get('WebPath')%>/RTIR/Incident/LinkChildren.html?id=<% $id %>&Queue=<% $Queue |u %>"><%loc("Link")%></a> |
</font></td></tr></table>
% }
@@ -72,4 +74,7 @@ $inactive->FromSQL(
my $total_count = $active->CountAll + $inactive->CountAll;
+my $QueueObj = RT::Queue->new($session{CurrentUser});
+$QueueObj->Load($Queue);
+
</%INIT>
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list