[Rt-commit] rt branch, 3.8-trunk, updated. rt-3.8.6-52-g86bfda7

[sunnavy at bestpractical.com]

The branch, 3.8-trunk has been updated
       via  86bfda78d2d9442e94f73e67789a77cbef41d5af (commit)
      from  48f5c2a31f889e7baf2d4f38555a73dc620a9a3a (commit)

Summary of changes:
 t/web/dashboard_with_deleted_saved_search.t |    3 +--
 t/web/offline_utf8.t                        |    6 ++----
 t/web/saved_search_chart.t                  |    3 +--
 t/web/ticket_update_without_content.t       |    6 ++----
 4 files changed, 6 insertions(+), 12 deletions(-)

- Log -----------------------------------------------------------------
commit 86bfda78d2d9442e94f73e67789a77cbef41d5af
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Oct 29 09:30:12 2009 +0800

    use get_ok() so we do *not* need to test the status stuff for new added tests

diff --git a/t/web/dashboard_with_deleted_saved_search.t b/t/web/dashboard_with_deleted_saved_search.t
index 06eadb4..328095a 100644
--- a/t/web/dashboard_with_deleted_saved_search.t
+++ b/t/web/dashboard_with_deleted_saved_search.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 19;
+use RT::Test tests => 18;
 my ( $url, $m ) = RT::Test->started_ok;
 ok( $m->login, 'logged in' );
 
@@ -72,7 +72,6 @@ $m->content_lacks( $search_uri, 'deleted search foo' );
 # here is what we really want to test
 
 $m->get_ok( $url . "/Dashboards/Queries.html?id=$dashboard_id" );
-is( $m->{'status'}, 200, "Loaded /Dashboards/Queries.html" );
 $m->content_like( qr/Deleted queries/i, 'found deleted message' );
 
 # Update button shows so we can update the deleted search easily
diff --git a/t/web/offline_utf8.t b/t/web/offline_utf8.t
index 35501be..2a3e64d 100644
--- a/t/web/offline_utf8.t
+++ b/t/web/offline_utf8.t
@@ -23,8 +23,7 @@ close $fh;
 my ( $url, $m ) = RT::Test->started_ok;
 ok( $m->login, 'logged in' );
 
-$m->get( $url . '/Tools/Offline.html' );
-is( $m->{'status'}, 200, "Loaded /Tools/Offline.html" );
+$m->get_ok( $url . '/Tools/Offline.html' );
 
 $m->submit_form(
     form_name => 'TicketUpdate',
@@ -49,8 +48,7 @@ my $ticket = RT::Ticket->new( $RT::SystemUser );
 $ticket->Load( $ticket_id );
 is( $ticket->Subject, 'æ ‡é¢˜', 'subject in $ticket is right' );
 
-$m->get( $url . "/Ticket/Display.html?id=$ticket_id" );
-is( $m->{'status'}, 200, "Loaded /Ticket/Display.html?id=$ticket_id" );
+$m->get_ok( $url . "/Ticket/Display.html?id=$ticket_id" );
 $m->content_contains( '这是正文',
     'content is right in ticket display page' );
 
diff --git a/t/web/saved_search_chart.t b/t/web/saved_search_chart.t
index fe1bc7e..1051662 100644
--- a/t/web/saved_search_chart.t
+++ b/t/web/saved_search_chart.t
@@ -23,8 +23,7 @@ ok( $ret, "ticket created: $msg" );
 
 ok( $m->login, 'logged in' );
 
-$m->get( $url . "/Search/Chart.html?Query=" . 'id=1' );
-is( $m->{'status'}, 200, "Loaded /Search/Chart.html" );
+$m->get_ok( $url . "/Search/Chart.html?Query=" . 'id=1' );
 my ($owner) = $m->content =~ /value="(RT::User-\d+)"/;
 
 $m->submit_form(
diff --git a/t/web/ticket_update_without_content.t b/t/web/ticket_update_without_content.t
index 1ffa896..595cb74 100644
--- a/t/web/ticket_update_without_content.t
+++ b/t/web/ticket_update_without_content.t
@@ -23,8 +23,7 @@ ok( $ret, "ticket created: $msg" );
 
 ok( $m->login, 'logged in' );
 
-$m->get( $url . "/Ticket/ModifyAll.html?id=" . $ticket->id );
-is( $m->{'status'}, 200, "Loaded ModifyAll.html" );
+$m->get_ok( $url . "/Ticket/ModifyAll.html?id=" . $ticket->id );
 
 $m->submit_form(
     form_number => 3,
@@ -43,8 +42,7 @@ EOF
 
 ok( $ret, $msg );
 
-$m->get( $url . "/Ticket/ModifyAll.html?id=" . $ticket->id );
-is( $m->{'status'}, 200, "Loaded ModifyAll.html" );
+$m->get_ok( $url . "/Ticket/ModifyAll.html?id=" . $ticket->id );
 
 $m->submit_form(
     form_number => 3,

-----------------------------------------------------------------------