[Rt-commit] rt branch, create-action, created. 780c5cd12a9a2e69f84a42b67551141fdba5c190

[sartak at bestpractical.com]

The branch, create-action has been created
        at  780c5cd12a9a2e69f84a42b67551141fdba5c190 (commit)

- Log -----------------------------------------------------------------
commit b2fa3bb74bde1708e153c834244a7e6ff14a2e35
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue Jul 28 13:27:16 2009 -0400

    Checkpoint

diff --git a/Makefile.PL b/Makefile.PL
index 1375d89..14a6678 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -170,4 +170,7 @@ features(
 
 tests("t/*.t t/*/*.t");
 auto_install;
+
+install_prefix_jifty("/opt/rt4");
+
 WriteAll;

commit c1a70f9d564d09bcdf2705b815b4d45f90c922be
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Aug 26 18:21:54 2009 -0400

    Revert premature commit
    
    This reverts commit b2fa3bb74bde1708e153c834244a7e6ff14a2e35.

diff --git a/Makefile.PL b/Makefile.PL
index 14a6678..1375d89 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -170,7 +170,4 @@ features(
 
 tests("t/*.t t/*/*.t");
 auto_install;
-
-install_prefix_jifty("/opt/rt4");
-
 WriteAll;

commit 0f42214a328599addad20c344134e3786ab85b5d
Merge: 83326c4 c1a70f9
Author: Chia-liang Kao <clkao at clkao.org>
Date:   Thu Aug 27 13:28:17 2009 +0800

    Merge branch '3.999-trunk' of diesel.bestpractical.com:/git/rt


commit 32f6e51a9882eeea38c6bbc1c75b14e84c2dac86
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Aug 28 16:20:23 2009 +0800

    remove circular call stuff in RT/Report/Tickets.pm

diff --git a/lib/RT/Report/Tickets.pm b/lib/RT/Report/Tickets.pm
index 77c6b4f..14627cf 100644
--- a/lib/RT/Report/Tickets.pm
+++ b/lib/RT/Report/Tickets.pm
@@ -256,7 +256,9 @@ for, do that.
 sub add_empty_rows {
     my $self = shift;
     if ( $self->{'_group_by_field'} eq 'status' ) {
-        my %has = map { $_->__value('status') => 1 } @{ $self->items_array_ref || [] };
+#        ->tiems_array_ref will cause circular call loop see rt4#13813 for detail
+#        my %has = map { $_->__value('status') => 1 } @{ $self->items_array_ref || [] };
+        my %has = map { $_->__value('status') => 1 } @{ $self->{'items'} || [] };
 
         foreach my $status ( grep !$has{$_}, RT::Model::Queue->status_schema->valid ) {
 

commit f83a8c26d092f8031de63096d3b7b9e9cdd53828
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Aug 28 16:24:02 2009 +0800

    fix the "Modification of non-creatable array value" error

diff --git a/share/html/Search/Chart b/share/html/Search/Chart
index bac6c3c..a16e691 100644
--- a/share/html/Search/Chart
+++ b/share/html/Search/Chart
@@ -126,10 +126,10 @@ while ( my $entry = $tix->next ) {
     if ( $class ) {
         my $q = $class->new();
         $q->load( $entry->__value( $value_name ) );
-        push @keys, $q->name;
+        push @keys, $q->name || '';
     }
     else {
-        push @keys, $entry->__value($value_name);
+        push @keys, $entry->__value($value_name) || '';
     }
 
     $keys[-1] ||= _('(no value)');
diff --git a/share/html/Search/Elements/Chart b/share/html/Search/Elements/Chart
index ab756d0..2109b95 100644
--- a/share/html/Search/Elements/Chart
+++ b/share/html/Search/Elements/Chart
@@ -71,10 +71,10 @@ while ( my $entry = $tix->next ) {
     if ($class) {
         my $q = $class->new();
         $q->load( $entry->__value( $value_name ) );
-        push @keys, $q->name;
+        push @keys, $q->name || '';
     }
     else {
-        push @keys, $entry->__value( $value_name );
+        push @keys, $entry->__value( $value_name ) || '';
     }
     $keys[-1] ||= _('(no value)');
     push @values, $entry->__value( $count_name );

commit deab3227df6675204591c803d78df95a02df43ef
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Fri Aug 28 05:13:52 2009 -0400

    Do not render the field labels in CRUD
    
        CRUD is now table-based so it's clutter

diff --git a/lib/RT/View/CRUD.pm b/lib/RT/View/CRUD.pm
index 644ccc3..b2423ac 100644
--- a/lib/RT/View/CRUD.pm
+++ b/lib/RT/View/CRUD.pm
@@ -95,8 +95,6 @@ sub view_via_callback {
     $field->render_wrapper_start();
     $field->render_preamble();
 
-    $field->render_label();
-
     # render the value with a hyperlink
     span {
         attr { class is "@{[ $field->classes ]} value" };

commit 81ada69c303f7904d4af5ceea3af2fa436802f66
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Aug 28 19:23:21 2009 +0800

    ->__value does *not* work on RT::Report::Tickets::Entry

diff --git a/lib/RT/Report/Tickets.pm b/lib/RT/Report/Tickets.pm
index 14627cf..6dfacfb 100644
--- a/lib/RT/Report/Tickets.pm
+++ b/lib/RT/Report/Tickets.pm
@@ -258,7 +258,8 @@ sub add_empty_rows {
     if ( $self->{'_group_by_field'} eq 'status' ) {
 #        ->tiems_array_ref will cause circular call loop see rt4#13813 for detail
 #        my %has = map { $_->__value('status') => 1 } @{ $self->items_array_ref || [] };
-        my %has = map { $_->__value('status') => 1 } @{ $self->{'items'} || [] };
+        my %has =
+          map { $_->{'values'}{'status'} => 1 } @{ $self->{'items'} || [] };
 
         foreach my $status ( grep !$has{$_}, RT::Model::Queue->status_schema->valid ) {
 

commit 780c5cd12a9a2e69f84a42b67551141fdba5c190
Merge: 81ada69 deab322
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Aug 28 19:26:29 2009 +0800

    Merge branch '3.999-trunk' of diesel:/git/rt into 3.999-trunk


-----------------------------------------------------------------------